* Python: Fix pyright errors and move search provider to core (#1546)
* address pablo coments
* update azure ai search pypi version to latest prev
* init update
* Fix MyPy type annotation errors in search provider
- Add type annotation to DEFAULT_CONTEXT_PROMPT
- Add type annotation to vectorizable_fields
- Add union type annotation to vector_queries
* Fix DEFAULT_CONTEXT_PROMPT MyPy error and update test
- Rename DEFAULT_CONTEXT_PROMPT to _DEFAULT_SEARCH_CONTEXT_PROMPT to avoid conflict with base class Final variable
- Update test to use new constant name
- All core package tests passing (1123 passed)
* Python: Move Azure AI Search to separate package per PR feedback
Addresses reviewer feedback from PR #1546 by isolating the beta dependency
(azure-search-documents==11.7.0b2) into a new agent-framework-aisearch package.
Changes:
- Created new agent-framework-aisearch package with complete structure
- Moved AzureAISearchContextProvider from core to aisearch package
- Added AzureAISearchSettings class for environment variable auto-loading
- Added support for direct API key string (auto-converts to AzureKeyCredential)
- Added azure_openai_api_key parameter for Knowledge Base authentication
- Updated embedding_function type to Callable[[str], Awaitable[list[float]]]
- Moved Role import to top-level imports
- Maintained lazy loading through agent_framework.azure module
- Removed beta dependency from core package
- Updated all tests to use new package location
- All quality checks pass: ruff format/lint, pyright, mypy (0 errors)
- All 21 unit tests pass with 59% coverage
Semantic search mode verified working with both API key and managed identity authentication.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Python: Clarify top_k parameter only applies to semantic mode
Updated documentation to clarify that the top_k parameter only affects
semantic search mode. In agentic mode, the server-side Knowledge Base
determines retrieval based on query complexity and reasoning effort.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Python: Add Knowledge Base output mode and retrieval reasoning effort parameters
Added support for configurable Knowledge Base behavior in agentic mode:
- knowledge_base_output_mode: "extractive_data" (default) or "answer_synthesis"
Some knowledge sources require answer_synthesis mode for proper functionality.
- retrieval_reasoning_effort: "minimal" (default), "medium", or "low"
Controls query planning complexity and multi-hop reasoning depth.
These parameters give users fine-grained control over Knowledge Base behavior
and enable support for knowledge sources that require answer synthesis.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
* effort and outputmode query params
* Address PR review feedback for Azure AI Search context provider
* comments eduward
* ed latest comments
---------
Co-authored-by: Farzad Sunavala <farzad.sunavala.enovate.ai>
Co-authored-by: farzad528 <farzad528@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
* Add unit tests for create conversation executor
* Update indentation and comment typo.
* Added unit tests for declarative executor SetMultipleVariablesExecutor
* Updated comments and syntactic sugar
* Add unit test for declarative executor RetrieveConversationMessageExecutor
* Removed irrelevant code statements
* Updated based on copilot feedback.
Fixes#2219
Adds default=str to json.dumps() calls to handle non-JSON-serializable
types like datetime objects in tool function results.
Co-authored-by: kishikawa-hayato <84244732+HerBest-max@users.noreply.github.com>
* Potential fix for code scanning alert no. 18: Information exposure through an exception
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Fix test
---------
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* First working version
* Simplify the implementations
* Remove unused env var
* Update Python syntax
* Address feedbacks
* Fix a typo
* Update names as review suggestions
* Citation for self-reflection
* Move to independent folder
* Update python/samples/getting_started/evaluation/azure_ai_foundry/evaluation/README.md
Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
* Updated from parquet to JSONL and hide the default environment variables
* As review feedback, remove the purpose of using `run_self_reflection_batch` as a library, only use it as sample code
* Update python/samples/getting_started/evaluation/azure_ai_foundry/evaluation/self_reflection.py
Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
---------
Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
* first work on declarative
* initial version of the declarative support
* fix tests and mypy
* fix parameters of functiontool
* slight logic improvement
* remove path until merge
* updates from comments
* create dispatcher and spec type, json_schema method
* fix mypy, skipping model
* updated lock
* fixed declarative tests and renamed some other test files
* refined loader
* updated lock
* fix mypy
* added readme to samples folder
* fixes from review
* undid test file rename
Eduard van Valkenburg
·
2025-11-19 16:33:02 +00:00
* fix: resolve string annotations in FunctionExecutor
Enhance type hint validation in FunctionExecutor by importing `typing` and
using `get_type_hints` to correctly resolve annotations.
This fixes validation failures when `from __future__ import annotations`
is enabled, which stores annotations as strings.
Fixes#1808
* Update python/packages/core/tests/workflow/test_function_executor_future.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* ran pre commit
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fix bug where ChatAgent system instructions were not captured in Langfuse
traces due to incorrect attribute access.
The observability code was attempting to retrieve instructions using
getattr(self, "instructions", None), but ChatAgent stores instructions
in self.chat_options.instructions. This caused system_instructions to
always be None in Langfuse traces.
Changed both _trace_agent_run and _trace_agent_run_stream functions
to correctly retrieve instructions from chat_options.instructions.
Fixes affect:
- Line 1123: _trace_agent_run (non-streaming)
- Line 1192: _trace_agent_run_stream (streaming)
Update XML documentation to clarify exception behavior.
See `ChatClientAgentThreadTests.SetConversationIdThrowsWhenMessageStoreIsSet` which already verifies this is the actual behavior.
Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>