Commit Graph

232 Commits

  • Expose agent, agentInterface, and artifactsPanel as public in ChatPanel
    Make these properties public so they can be accessed externally for
    test automation and other programmatic control.
    
    Changes:
    - Change agent, agentInterface, artifactsPanel from private to public
  • Refactor JavaScript REPL tool description with consistent pattern
    Clean up and restructure JavaScript REPL description following consistent pattern:
    - Purpose section
    - When to Use section
    - Environment section
    - Common Libraries section
    - Important Notes section
    - Example section
    
    Removed buildJavaScriptReplDescription() function - no longer dynamically
    injecting runtime provider docs into tool description (will move to system prompt).
    
    Changes:
    - Replace JAVASCRIPT_REPL_BASE_DESCRIPTION with JAVASCRIPT_REPL_DESCRIPTION
    - Remove JAVASCRIPT_REPL_CHART_EXAMPLE and JAVASCRIPT_REPL_FOOTER
    - Remove buildJavaScriptReplDescription() function
    - Update javascript-repl tool to use static description
    - Simpler, more scannable structure with clear hierarchy
  • Improve artifacts tool description to emphasize update command
    Add clear decision tree and anti-patterns to prevent LLMs from using
    get + rewrite when they should use update for targeted edits.
    
    Changes:
    - Add CRITICAL workflow section at top with decision tree
    - Emphasize 'update' as PREFERRED for edits (token efficient)
    - Mark 'rewrite' as LAST RESORT only
    - Add ANTI-PATTERNS section showing wrong approaches
    - Clarify use cases for each command
    - Add examples emphasizing surgical modifications
  • Clarify when to use artifacts runtime functions vs artifacts tool
    Make it clear that runtime functions are ONLY for programmatically generated
    content (by code), not for content the LLM authors directly.
    
    Changes:
    - Add WHEN TO USE and DO NOT USE sections to runtime provider description
    - Emphasize that createOrUpdateArtifact is for code-generated content
    - Point users to artifacts tool for LLM-authored content like summaries
  • Replace hasArtifact with listArtifacts
    LLMs don't need to check existence - they can just list all artifacts.
    Simpler API that returns all filenames at once.
    
    Changes:
    - Replace hasArtifact(filename) with listArtifacts() returning string[]
    - Add 'list' action handler that returns all artifact keys
    - Update examples in prompt to use listArtifacts()
  • Merge createArtifact and updateArtifact into createOrUpdateArtifact
    LLMs get confused about when to use create vs update. The single function
    automatically detects if the artifact exists and chooses the right operation.
    
    Changes:
    - Replace createArtifact/updateArtifact with createOrUpdateArtifact in runtime
    - Update handler to check existence and use appropriate command (create/rewrite)
    - Simplify prompt documentation and examples
  • Fix abort detection to use message stopReason instead of global isStreaming
    When abort happens during tool call streaming, the tool result should show as aborted.
    Previously used global isStreaming state which would flip when new messages streamed in,
    causing spinner to reappear incorrectly.
    
    Changes:
    - Use message.stopReason === "aborted" to detect aborted tool calls
    - Create synthetic error result for aborted tool calls in ToolMessage component
    - Fix Ollama provider key test to return true (can't know which model to test)
    - Add newline before HTML execution logs in artifacts update
  • HTML artifacts call window.complete() when page loads
    - Inject <script>if (window.complete) window.complete();</script> before </html>
    - HTML artifacts are long-running and don't time out
    - Console logs are sent immediately, completion signals when page is ready
    - Removes need for artificial timeout in HTML artifacts
  • Simplify ArtifactsRuntimeProvider constructor
    - Take artifactsPanel and agent directly instead of 5 separate function parameters
    - Define minimal ArtifactsPanelLike and AgentLike interfaces to avoid circular deps
    - Update all call sites (ChatPanel, browser-javascript) to use simplified constructor
    - Much cleaner and easier to use
  • Fix javascript-repl to throw errors on execution failure
    - Throw error instead of returning output when result.success is false
    - Ensures tool call is marked as failed when code execution fails or is aborted
    - Matches browser-javascript error handling pattern
  • Fix console logging and message routing
    Console Logging Improvements:
    - Changed ConsoleRuntimeProvider to send logs immediately instead of batching
    - Track pending send promises and await them in onCompleted callback
    - Ensures REPL gets all logs before execution-complete
    - Enables real-time console logging for HTML artifacts
    
    Message Routing Fixes:
    - Remove "handled" concept from message routing - broadcast all messages to all providers/consumers
    - Change handleMessage return type from Promise<boolean> to Promise<void>
    - Add debug logging to RuntimeMessageRouter to trace message flow
    - Fix duplicate error logging (window error handler now only tracks errors, doesn't log them)
    
    Output Formatting Consistency:
    - Remove [LOG], [ERROR] prefixes from console output in both tools
    - Show console logs before error messages
    - Use "=> value" format for return values in both javascript-repl and browser-javascript
    - Remove duplicate "Error:" prefix and extra formatting
    
    Bug Fixes:
    - Fix race condition where execution-complete arrived before console logs
    - Fix ConsoleRuntimeProvider blocking execution-complete from reaching consumers
    - Remove duplicate console log collection from SandboxedIframe
    - Fix return value capture by wrapping user code in async function
  • Remove debug console.log statements causing duplicate error messages
    - console.log('Reporting execution error:', finalError) was logging the error
    - This caused duplicate error message in output
    - Removed all debug console.log statements from window.complete()
    - Error is only shown via execution-error message now
  • Display return values and fix duplicate error messages in REPL
    - javascript-repl now displays return values with => prefix
    - Objects are JSON.stringify'd with formatting
    - Removed console.error from wrapper to prevent duplicate error messages
    - Error is already captured and sent via execution-error message
    - Fixes missing return value display and duplicate error output
  • Pass return value through execution-complete message instead of logging
    - Return value now passed to window.complete(error, returnValue)
    - execution-complete message includes returnValue field
    - SandboxResult interface updated to include returnValue
    - executionConsumer passes returnValue in resolved promise
    - Return values properly captured and available to callers
  • Fix REPL timeout with return statements by wrapping user code in function
    - User code with return statement was exiting the async IIFE early
    - Completion callbacks and window.complete() were never reached
    - Now wrap user code in userCodeFunc to capture return value
    - Return statement returns from userCodeFunc, not outer IIFE
    - Completion callbacks and window.complete() always execute
    - Return value is logged to console output
    - Fixes 30-second timeout when using return statements in REPL
  • Fix message routing by broadcasting to all providers and consumers
    - Router was stopping propagation after first handler returned true
    - This prevented consumers from seeing messages that providers handled
    - executionConsumer never received execution-complete because ConsoleRuntimeProvider handled it first
    - Now all providers and consumers receive all messages
    - Fixes javascript_repl never completing
  • Fix ConsoleRuntimeProvider blocking execution-complete from reaching executionConsumer
    - ConsoleRuntimeProvider was handling execution-complete and returning true
    - This stopped message propagation before executionConsumer could handle it
    - ExecutionConsumer never got execution-complete, so promise never resolved
    - Now ConsoleRuntimeProvider responds but returns false to allow propagation
    - Fixes javascript_repl never completing (30s timeout)
  • Fix race condition by making window.complete() async and awaiting it
    - window.complete() was fire-and-forget, causing execution-complete to arrive before console messages
    - This caused sandbox to unregister before console message responses arrived
    - Made complete() async and await sendRuntimeMessage()
    - SandboxedIframe wrapper now awaits window.complete()
    - Ensures all messages are processed before cleanup/unregister
    - Fixes 30-second timeout on javascript_repl
  • Fix ConsoleRuntimeProvider hanging by calling respond()
    - ConsoleRuntimeProvider.handleMessage() was not calling respond()
    - This caused sendRuntimeMessage() to hang waiting for response (30s timeout)
    - Now properly acknowledges console, execution-complete, and execution-error messages
    - Fixes javascript_repl hanging on simple console.log() calls
  • Unify completion callback pattern across browser-javascript and javascript-repl
    - Remove fallback timeout from ConsoleRuntimeProvider (was causing 2s delays)
    - Add completion callback support to SandboxedIframe REPL wrapper
    - Call completion callbacks before window.complete() in both success/error paths
    - Both browser-javascript and javascript-repl now use identical completion pattern
    - Ensures console logs are batched and sent before execution completes
  • Add onCompleted callback system for guaranteed console log delivery
    - Add onCompleted() callback registration in RuntimeMessageBridge
    - Modify wrapperFunction to call completion callbacks before returning
    - Update ConsoleRuntimeProvider to immediate send + completion batch pattern
    - Extract DOWNLOADABLE_FILE_RUNTIME_DESCRIPTION from ATTACHMENTS_RUNTIME_DESCRIPTION
    - Logs sent immediately (fire-and-forget), unsent logs batched at completion
    - Ensures all console logs arrive before tool execution completes
  • Add debug logging to RuntimeMessageRouter and increase API key validation tokens
    - Add console.log for user script messages in RuntimeMessageRouter
    - Increase ProviderKeyInput maxTokens from 10 to 200 for better validation
  • Add runtime bridge architecture and fix HTML escaping
    Major refactoring to unify runtime providers across sandbox and user script contexts:
    
    1. Runtime Bridge & Router
       - Add RuntimeMessageBridge for unified messaging abstraction
       - Rename SandboxMessageRouter → RuntimeMessageRouter
       - Router now handles both iframe and user script messages
       - Guard for non-extension environments
    
    2. Provider Refactoring
       - ArtifactsRuntimeProvider: Add offline mode with snapshot fallback
       - AttachmentsRuntimeProvider: Remove returnDownloadableFile (moved to dedicated provider)
       - ConsoleRuntimeProvider: Add message collection, remove lifecycle logic
       - FileDownloadRuntimeProvider: New provider for file downloads
    
    3. HTML Escaping Fix
       - Escape </script> in JSON.stringify output to prevent premature tag closure
       - Applies when injecting provider data into <script> tags
       - JavaScript engine automatically unescapes, no runtime changes needed
    
    4. Function Renaming
       - listFiles → listAttachments
       - readTextFile → readTextAttachment
       - readBinaryFile → readBinaryAttachment
       - returnFile → returnDownloadableFile
    
    5. Updated Exports
       - Export new RuntimeMessageBridge and RuntimeMessageRouter
       - Export FileDownloadRuntimeProvider
       - Update all cross-references
    
    This sets the foundation for reusing providers in browser-javascript tool.
  • Add image artifact support with proper binary downloads
    - Add ImageArtifact component for displaying images (.png, .jpg, .jpeg, .gif, .webp, .bmp, .ico)
    - Images stored as base64, displayed via data URLs
    - Download button properly decodes base64 to Uint8Array for valid binary downloads
    - Fix Lit ChildPart error: use CSS rotation instead of innerHTML manipulation in collapsible headers
    
    Changes:
    - web-ui/src/tools/artifacts/ImageArtifact.ts: New image artifact component
    - web-ui/src/tools/artifacts/artifacts.ts: Add "image" file type support
    - web-ui/src/tools/renderer-registry.ts: Fix collapsible chevron to use CSS rotation
    - web-ui/src/index.ts: Export ImageArtifact
  • Add artifact message persistence for session reconstruction
    - Add ArtifactMessage type as core part of AppMessage union (not CustomMessages)
    - ArtifactsRuntimeProvider appends artifact messages on create/update/delete
    - MessageList filters out artifact messages (UI display only)
    - artifacts.ts reconstructFromMessages handles artifact messages
    - Export ARTIFACTS_RUNTIME_PROVIDER_DESCRIPTION from main index
    - Fix artifact creation bug: pass filename as title instead of mimeType
    
    Changes:
    - web-ui/src/components/Messages.ts: Add ArtifactMessage to BaseMessage union
    - web-ui/src/components/MessageList.ts: Skip artifact messages in render
    - web-ui/src/components/sandbox/ArtifactsRuntimeProvider.ts: Append messages, fix title parameter
    - web-ui/src/ChatPanel.ts: Pass agent.appendMessage callback
    - web-ui/src/tools/artifacts/artifacts.ts: Handle artifact messages in reconstructFromMessages
    - web-ui/src/index.ts: Export ARTIFACTS_RUNTIME_PROVIDER_DESCRIPTION
    - web-ui/example/src/custom-messages.ts: Update message transformer to filter artifacts
  • Add ollama dependency and dialog backdrop blur
    - Add ollama package to web-ui dependencies for ModelSelector
    - Add backdrop blur to SettingsDialog (bg-black/50 backdrop-blur-sm)
    - Update mini-lit to 0.1.9 for backdropClassName prop support
    - Fix TypeScript errors in ModelSelector (ollama import, parameter types)
    - Add backward compatibility methods to SessionsStore (saveSession, loadSession, getLatestSessionId)
  • Fix IndexedDB in-line vs out-of-line key handling
    - Check if store has keyPath before calling put()
    - If keyPath exists (in-line keys), only pass value: store.put(value)
    - If no keyPath (out-of-line keys), pass both: store.put(value, key)
    - Apply fix to both set() and transaction.set()
    - Fixes DataError when saving sessions with keyPath: 'id'
  • Refactor to Store-based architecture
    - Create base Store class with private backend and protected getBackend()
    - Add SettingsStore, ProviderKeysStore, SessionsStore
    - Each store defines its own schema via getConfig()
    - AppStorage now takes stores + backend in constructor
    - Remove SessionsRepository (logic moved to SessionsStore)
    - Update all consumers to use store API (storage.settings.get/set, storage.providerKeys.get/set)
    - Update example app to follow new pattern: create stores, gather configs, create backend, wire
    - Benefits: stores own their schema, no circular deps, cleaner separation
  • Implement unified storage architecture
    - Replace fragmented storage backends with single IndexedDBStorageBackend
    - Create multi-store StorageBackend interface (storeName parameter)
    - Remove old backends: IndexedDBBackend, LocalStorageBackend, SessionIndexedDBBackend, WebExtensionStorageBackend
    - Remove old repositories: ProviderKeysRepository, SessionRepository, SettingsRepository
    - Simplify AppStorage to directly expose storage methods (getSetting/setSetting, getProviderKey/setProviderKey)
    - Create SessionsRepository for session-specific operations
    - Update all consumers to use new simplified API
    - Update example app to use new storage architecture
    - Benefits: 10GB+ quota (vs 10MB chrome.storage), single database, consistent API
  • Fix spinner showing on aborted tool calls in javascript-repl and artifacts renderers
    When isStreaming is false and there's no result (aborted state), show 'complete' state instead of 'inprogress' to avoid showing the spinner.
  • Prevent default and stop propagation when clicking artifact pill
    This prevents the collapsible header from toggling when the pill is clicked.
  • Make renderHeader and renderCollapsibleHeader accept string | TemplateResult
    - Update renderHeader and renderCollapsibleHeader in renderer-registry.ts to accept `text: string | TemplateResult`
    - Remove duplicated renderCollapsibleHeaderWithPill helper in artifacts-tool-renderer.ts
    - Update all artifact renderer calls to use renderHeaderWithPill() inline
    - Remove all separate pill rendering below headers
    
    This allows artifact pills to be rendered inline with header text without code duplication.
  • Add clickable artifact pills to tool renderer
    - Create ArtifactPill component (similar to SkillPill)
    - Renders filename as clickable pill with FileCode2 icon
    - Clicking pill opens artifacts panel and selects that artifact
    - Update ArtifactsToolRenderer to accept artifactsPanel reference
    - Pass artifactsPanel from ChatPanel to renderer on initialization
    - Display artifact pill below header for all commands
    - Pill only clickable when artifactsPanel reference is available
  • Update artifacts-tool-renderer to use collapsible headers
    - All actions except DELETE now use collapsible headers
    - CREATE/UPDATE/REWRITE/GET/LOGS: code/output collapsed by default
    - DELETE: keeps simple non-collapsible header
    - Fix isStreaming parameter usage for proper spinner state
    - Add smooth 300ms animation on expand/collapse
    - Full header is clickable to toggle collapse state
  • Make entire collapsible header clickable
    - Changed outer div to button element
    - Added w-full and text-left classes
    - Now click anywhere on header (icon, text, chevron) to expand/collapse
  • Add collapsible tool renderers with animated expand/collapse
    - Add renderCollapsibleHeader() to renderer-registry
      - Places chevron on right, spinner on left
      - Toggles between ChevronRight (collapsed) and ChevronDown (expanded)
      - Uses max-h-0/max-h-[2000px] with transition-all for smooth animation
      - Dynamically adds/removes mt-3 to avoid margin when collapsed
    
    - Update javascript-repl renderer to use collapsible sections
      - Code and console output hidden by default
      - Only file attachments remain visible
      - 300ms smooth animation on expand/collapse
    
    - Export renderCollapsibleHeader from web-ui index
  • Refactor artifacts renderer and add Console component
    - Extract ArtifactsToolRenderer from ArtifactsPanel into standalone renderer
    - Fix ChatPanel to register ArtifactsToolRenderer instead of panel
    - Implement command-specific rendering logic (create/update/rewrite/get/logs/delete)
    - Create reusable Console component with copy button and autoscroll toggle
    - Replace custom console implementation with ExpandableSection and Console
    - Fix Lit reactivity for HtmlArtifact logs using spread operator
    - Add Lucide icons (FileCode2, ChevronsDown, Lock) for UI consistency
    - Follow skill.ts patterns with renderHeader and state handling
    - Add i18n strings for all artifact actions and console features
  • Rename ChromeStorageBackend to WebExtensionStorageBackend for cross-browser support
    - Rename chrome-storage-backend.ts to web-extension-storage-backend.ts
    - Update to use globalThis.browser || globalThis.chrome for Firefox/Chrome compatibility
    - Export both names for backward compatibility
    - Fix tsc --preserveWatchOutput in web-ui dev script to prevent console clearing
    
    This fixes the "browser is not defined" error in Chrome extensions.
  • Make mini-lit a peer dependency in pi-web-ui
    - Move mini-lit from dependencies to peerDependencies
    - Keep in devDependencies for development
    - Prevents bundlers from including mini-lit when consuming pi-web-ui
    - Consumer (sitegeist) provides mini-lit, esbuild bundles it once
    - Fixes duplicate mini-lit bundling issue permanently
  • Clean up browser-extension references from monorepo
    - Update README.md to reference sitegeist repo
    - Update CLAUDE.md to replace browser-extension with web-ui
    - Update packages/web-ui/README.md examples to point to sitegeist
    - Remove browser-extension exclude from tsconfig.json
    - Remove browser-extension from .claude/settings.local.json permissions