jifandGitHub 1391d786bc Scope command approvals by execution environment (#28738) ...

## Why

Command approval cache keys included the command and working directory,
but not the execution environment. An approval for `/workspace` locally
could therefore be reused for the same command and path on an executor.

## What changed

- Include the selected environment ID in shell and unified-exec approval
cache keys.
- Carry that ID through the normal command approval request so clients
can show which environment is being approved.
- Expose the environment through app-server as a required nullable
`environmentId` and show it in the inline TUI approval prompt.
- Keep older recorded approval events compatible when the environment is
absent.

For example, `echo ok` in local `/workspace` and `echo ok` in executor
`/workspace` now produce different approval keys and separate prompts.

## Scope

This PR does not change network approvals, Guardian review actions, MCP
elicitation, full-screen TUI rendering, or environment-ID validation.
Remote `shell_command` execution itself remains in #28722; this PR only
makes its approval key environment-aware.

2026-06-17 19:52:43 +02:00

..

agent

Replace SkillsManager with SkillsService (#28705)

2026-06-17 17:01:06 +02:00

apps

Split DeveloperInstructions into individual fragments. (#18813)

2026-04-21 10:22:36 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

config

Replace SkillsManager with SkillsService (#28705)

2026-06-17 17:01:06 +02:00

context

[codex] core: restore absolute turn context cwd (#28629)

2026-06-16 19:05:26 -07:00

context_manager

Add join key for MAv2 inter-agent messages (#28561)

2026-06-17 14:48:56 +02:00

guardian

Replace SkillsManager with SkillsService (#28705)

2026-06-17 17:01:06 +02:00

plugins

[codex] Add created-by-me remote plugin marketplace (#28203)

2026-06-15 22:07:07 +00:00

sandboxing

Run fs helper through Windows sandbox wrapper (#28359)

2026-06-17 10:00:42 -07:00

session

Scope command approvals by execution environment (#28738)

2026-06-17 19:52:43 +02:00

state

Replace SkillsManager with SkillsService (#28705)

2026-06-17 17:01:06 +02:00

tasks

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

tools

Scope command approvals by execution environment (#28738)

2026-06-17 19:52:43 +02:00

unified_exec

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

utils

…

agents_md_tests.rs

app-server: preserve target-native environment cwd (#28146)

2026-06-16 21:42:28 +00:00

agents_md.rs

app-server: preserve target-native environment cwd (#28146)

2026-06-16 21:42:28 +00:00

apply_patch_tests.rs

[codex] Migrate apply_patch to executor filesystem (#17027)

2026-04-07 21:20:22 +00:00

apply_patch.rs

Support multi-environment apply_patch selection (#21617)

2026-05-11 16:33:44 -07:00

attestation.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client_common_tests.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

client_common.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

client_tests.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

client.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

codex_delegate_tests.rs

Scope command approvals by execution environment (#28738)

2026-06-17 19:52:43 +02:00

codex_delegate.rs

Scope command approvals by execution environment (#28738)

2026-06-17 19:52:43 +02:00

codex_thread.rs

[codex] core: restore absolute turn context cwd (#28629)

2026-06-16 19:05:26 -07:00

command_canonicalization_tests.rs

…

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

compact_remote_v2.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

compact_remote.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

compact_tests.rs

Add join key for MAv2 inter-agent messages (#28561)

2026-06-17 14:48:56 +02:00

compact.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

config_lock.rs

Use plugin-service MCP as the hosted plugin runtime (#27198)

2026-06-10 12:54:21 +02:00

connectors_tests.rs

[codex] Reuse Apps policy evaluation across MCP tool exposure (#27813)

2026-06-15 15:24:33 -07:00

connectors.rs

[codex] Reuse Apps policy evaluation across MCP tool exposure (#27813)

2026-06-15 15:24:33 -07:00

consequential_tool_message_templates.json

…

environment_selection.rs

app-server: preserve target-native environment cwd (#28146)

2026-06-16 21:42:28 +00:00

event_mapping_tests.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

event_mapping.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

exec_env_tests.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_env.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_policy_tests.rs

[codex] Respect Windows sandbox backend in exec policy (#26307)

2026-06-05 11:20:52 -07:00

exec_policy_windows_tests.rs

[codex] Respect Windows sandbox backend in exec policy (#26307)

2026-06-05 11:20:52 -07:00

exec_policy.rs

[codex] Respect Windows sandbox backend in exec policy (#26307)

2026-06-05 11:20:52 -07:00

exec_tests.rs

core: stop threading SandboxPolicy through exec (#25700)

2026-06-03 10:41:41 -07:00

exec.rs

Run fs helper through Windows sandbox wrapper (#28359)

2026-06-17 10:00:42 -07:00

function_tool.rs

feat: extract shared tool executor interface (#22359)

2026-05-13 11:31:27 +02:00

git_info_tests.rs

[codex] preserve fsmonitor for worktree Git reads (#26880)

2026-06-08 21:32:46 -07:00

hook_runtime.rs

core: surface terminal subagent errors to parent agents (#28375)

2026-06-16 14:34:54 +02:00

image_preparation_tests.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

image_preparation.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

installation_id.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

landlock.rs

linux-sandbox: switch helper plumbing to PermissionProfile (#20106)

2026-04-28 19:43:44 -07:00

lib.rs

Replace SkillsManager with SkillsService (#28705)

2026-06-17 17:01:06 +02:00

mcp_openai_file.rs

app-server: preserve target-native environment cwd (#28146)

2026-06-16 21:42:28 +00:00

mcp_skill_dependencies.rs

feat: use encrypted local secrets for MCP OAuth (#27541)

2026-06-12 22:03:51 +00:00

mcp_tool_approval_templates.rs

Uprev Rust toolchain pins to 1.95.0 (#24684)

2026-05-26 20:59:47 -07:00

mcp_tool_call_tests.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

mcp_tool_call.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

mcp_tool_exposure_test.rs

[codex] Reuse Apps policy evaluation across MCP tool exposure (#27813)

2026-06-15 15:24:33 -07:00

mcp_tool_exposure.rs

[codex] Reuse Apps policy evaluation across MCP tool exposure (#27813)

2026-06-15 15:24:33 -07:00

mcp.rs

Add selected-plugin precedence and attribution to the MCP catalog (#27884)

2026-06-15 11:10:51 +02:00

memory_usage.rs

[codex] simplify memory read metrics (#28164)

2026-06-15 08:28:02 -07:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

network_policy_decision_tests.rs

extract models manager and related ownership from core (#16508)

2026-04-02 23:00:02 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

network_proxy_loader_tests.rs

Use named MITM permissions config (#18240)

2026-05-20 17:10:37 -07:00

network_proxy_loader.rs

[codex] Remove async_trait from first-party code (#27475)

2026-06-11 18:16:39 -07:00

original_image_detail.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

otel_init.rs

Add process-scoped SQLite telemetry (#22154)

2026-05-11 11:32:40 -07:00

personality_migration_tests.rs

Add multi-agent runtime metadata types (#25720)

2026-06-02 12:10:14 +02:00

personality_migration.rs

feat(app-server): filter threads by parent (#26662)

2026-06-14 00:14:26 -07:00

prompt_debug.rs

[codex] core: restore absolute turn context cwd (#28629)

2026-06-16 19:05:26 -07:00

realtime_context_tests.rs

Revert thread recencyAt for sidebar ordering (#28655)

2026-06-16 21:39:30 -07:00

realtime_context.rs

feat: render typed envelopes for multi-agent v2 messages (#28368)

2026-06-16 11:46:59 +02:00

realtime_conversation_tests.rs

Add realtime speech append control (#27917)

2026-06-15 16:15:58 -07:00

realtime_conversation.rs

Add a toggle for realtime startup context (#28405)

2026-06-15 17:14:22 -07:00

realtime_prompt.rs

[codex] Consolidate shared prompts in codex-prompts (#25151)

2026-06-01 18:45:07 +00:00

responses_metadata.rs

core: Consolidate Responses API Codex metadata (#27122)

2026-06-11 13:42:09 -07:00

responses_retry.rs

centralize Responses retry policy (#24131)

2026-05-26 11:01:18 +02:00

review_format.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

rollout.rs

app-server: remove experimental persist_extended_history bool flag (#25712)

2026-06-01 23:33:42 +00:00

safety_tests.rs

Make deny canonical for filesystem permission entries (#23493)

2026-05-19 11:03:47 -07:00

safety.rs

Make turn diff tracking operation backed (#21180)

2026-05-07 11:33:47 +02:00

sandbox_tags_tests.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

sandbox_tags.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

session_prefix_tests.rs

core: surface terminal subagent errors to parent agents (#28375)

2026-06-16 14:34:54 +02:00

session_prefix.rs

core: surface terminal subagent errors to parent agents (#28375)

2026-06-16 14:34:54 +02:00

session_rollout_init_error.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

session_startup_prewarm.rs

Add spans to turn lifecycle gaps (#27623)

2026-06-11 16:55:01 -07:00

shell_snapshot_tests.rs

[codex] Bind shell snapshots to retained thread environments (#28421)

2026-06-15 20:10:53 -07:00

shell_snapshot.rs

app-server: preserve target-native environment cwd (#28146)

2026-06-16 21:42:28 +00:00

shell_tests.rs

[codex] simplify shell snapshot ownership (#27756)

2026-06-15 08:18:13 -07:00

shell.rs

[codex] simplify shell snapshot ownership (#27756)

2026-06-15 08:18:13 -07:00

skills.rs

Replace SkillsManager with SkillsService (#28705)

2026-06-17 17:01:06 +02:00

spawn.rs

core: stop threading SandboxPolicy through exec (#25700)

2026-06-03 10:41:41 -07:00

state_db_bridge.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

stream_events_utils_tests.rs

[codex] [2/4] Generalize plugin suggestion presentation (#28400)

2026-06-16 22:44:10 +00:00

stream_events_utils.rs

[codex] Persist built-in image results reported as generating (#28656)

2026-06-17 06:03:00 +00:00

test_support.rs

core: Consolidate Responses API Codex metadata (#27122)

2026-06-11 13:42:09 -07:00

thread_manager_tests.rs

app-server: preserve target-native environment cwd (#28146)

2026-06-16 21:42:28 +00:00

thread_manager.rs

Replace SkillsManager with SkillsService (#28705)

2026-06-17 17:01:06 +02:00

thread_rollout_truncation_tests.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

thread_rollout_truncation.rs

Support plaintext agent messages (#27830)

2026-06-12 13:50:04 -07:00

turn_diff_tracker_tests.rs

core: cache turn diff rendering (#27489)

2026-06-10 17:17:44 -07:00

turn_diff_tracker.rs

core: cache turn diff rendering (#27489)

2026-06-10 17:17:44 -07:00

turn_metadata_tests.rs

core: Consolidate Responses API Codex metadata (#27122)

2026-06-11 13:42:09 -07:00

turn_metadata.rs

core: Consolidate Responses API Codex metadata (#27122)

2026-06-11 13:42:09 -07:00

turn_timing_tests.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

turn_timing.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00

user_shell_command_tests.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

user_shell_command.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

util_tests.rs

Trim TUI legacy core helper usage (#22695)

2026-05-14 16:54:59 -07:00

util.rs

Trim TUI legacy core helper usage (#22695)

2026-05-14 16:54:59 -07:00

web_search.rs

…

windows_sandbox_read_grants_tests.rs

windows-sandbox: pass workspace roots to runner (#24108)

2026-05-28 15:26:55 -07:00

windows_sandbox_read_grants.rs

windows-sandbox: pass workspace roots to runner (#24108)

2026-05-28 15:26:55 -07:00

windows_sandbox_tests.rs

config: remove legacy profile v1 resolution (#24051)

2026-05-22 12:13:52 +02:00

windows_sandbox.rs

Add Windows sandbox provisioning setup command (#24831)

2026-05-29 11:01:44 -07:00