Eric Traut 281b0eae8b Don't allow model_supports_reasoning_summaries to disable reasoning (#11833) ...

The `model_supports_reasoning_summaries` config option was originally
added so users could enable reasoning for custom models (models that
codex doesn't know about). This is how it was documented in the source,
but its implementation didn't match. It was implemented such that it can
also be used to disable reasoning for models that otherwise support
reasoning. This leads to bad behavior for some reasoning models like
`gpt-5.3-codex`. Diagnosing this is difficult, and it has led to many
support issues.

This PR changes the handling of `model_supports_reasoning_summaries` so
it matches its original documented behavior. If it is set to false, it
is a no-op. That is, it never disables reasoning for models that are
known to support reasoning. It can still be used for its intended
purpose -- to enable reasoning for unknown models.

281b0eae8b · 2026-02-17 07:19:28 -08:00

History

..

cache.rs

Add logs to model cache (#11551)

2026-02-11 23:25:31 -08:00

collaboration_mode_presets.rs

Remove test-support feature from codex-core and replace it with explicit test toggles (#11405)

2026-02-10 22:44:02 -08:00

manager.rs

fix: show user warning when using default fallback metadata (#11690)

2026-02-15 18:46:05 -08:00

mod.rs

Remove test-support feature from codex-core and replace it with explicit test toggles (#11405)

2026-02-10 22:44:02 -08:00

model_info.rs

Don't allow model_supports_reasoning_summaries to disable reasoning (#11833)

2026-02-17 07:19:28 -08:00

model_presets.rs

Remove test-support feature from codex-core and replace it with explicit test toggles (#11405)

2026-02-10 22:44:02 -08:00