mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
pakrym-oai
e752f7b4ae
The workspace denies `clippy::expect_used` in production. Although `clippy.toml` allows `expect` in tests, Bazel Clippy compiles integration-test helper code in a way that does not receive that exemption, which encouraged verbose `unwrap_or_else(... panic!(...))` and equivalent `match`/`let else` forms. This allows `clippy::expect_used` once at each integration-test crate root (including aggregated suites and test-support libraries), then replaces manual panic-based Result and Option unwraps with `expect`/`expect_err`. Standalone `tests/*.rs` files remain their own crate roots. Intentional assertion and unexpected-variant panics remain unchanged, and the production `expect_used = "deny"` lint remains in place. The cleanup is mechanical and net-negative in line count.
73 lines
2.3 KiB
Rust
73 lines
2.3 KiB
Rust
#![cfg(not(target_os = "windows"))]
|
|
#![allow(clippy::unwrap_used)]
|
|
|
|
use core_test_support::responses;
|
|
use core_test_support::test_codex_exec::test_codex_exec;
|
|
|
|
/// Verify that the --add-dir flag is accepted and the command runs successfully.
|
|
/// This test confirms the CLI argument is properly wired up.
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 1)]
|
|
async fn accepts_add_dir_flag() -> anyhow::Result<()> {
|
|
let test = test_codex_exec();
|
|
|
|
let server = responses::start_mock_server().await;
|
|
let body = responses::sse(vec![
|
|
responses::ev_response_created("response_1"),
|
|
responses::ev_assistant_message("response_1", "Task completed"),
|
|
responses::ev_completed("response_1"),
|
|
]);
|
|
responses::mount_sse_once(&server, body).await;
|
|
|
|
// Create temporary directories to use with --add-dir
|
|
let temp_dir1 = tempfile::tempdir()?;
|
|
let temp_dir2 = tempfile::tempdir()?;
|
|
|
|
test.cmd_with_server(&server)
|
|
.arg("--skip-git-repo-check")
|
|
.arg("--sandbox")
|
|
.arg("workspace-write")
|
|
.arg("--add-dir")
|
|
.arg(temp_dir1.path())
|
|
.arg("--add-dir")
|
|
.arg(temp_dir2.path())
|
|
.arg("test with additional directories")
|
|
.assert()
|
|
.code(0);
|
|
|
|
Ok(())
|
|
}
|
|
|
|
/// Verify that multiple --add-dir flags can be specified.
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn accepts_multiple_add_dir_flags() -> anyhow::Result<()> {
|
|
let test = test_codex_exec();
|
|
|
|
let server = responses::start_mock_server().await;
|
|
let body = responses::sse(vec![
|
|
responses::ev_response_created("response_1"),
|
|
responses::ev_assistant_message("response_1", "Multiple directories accepted"),
|
|
responses::ev_completed("response_1"),
|
|
]);
|
|
responses::mount_sse_once(&server, body).await;
|
|
|
|
let temp_dir1 = tempfile::tempdir()?;
|
|
let temp_dir2 = tempfile::tempdir()?;
|
|
let temp_dir3 = tempfile::tempdir()?;
|
|
|
|
test.cmd_with_server(&server)
|
|
.arg("--skip-git-repo-check")
|
|
.arg("--sandbox")
|
|
.arg("workspace-write")
|
|
.arg("--add-dir")
|
|
.arg(temp_dir1.path())
|
|
.arg("--add-dir")
|
|
.arg(temp_dir2.path())
|
|
.arg("--add-dir")
|
|
.arg(temp_dir3.path())
|
|
.arg("test with three directories")
|
|
.assert()
|
|
.code(0);
|
|
|
|
Ok(())
|
|
}
|