2178 Commits

• refactor: centralize filesystem permissions precedence (#14174)

  ## Stack
  
     fix: fail closed for unsupported split windows sandboxing #14172
     fix: preserve split filesystem semantics in linux sandbox #14173
     fix: align core approvals with split sandbox policies #14171
  -> refactor: centralize filesystem permissions precedence #14174
  
  ## Summary
  - add a shared per-path split filesystem precedence helper in
  `FileSystemSandboxPolicy`
  - derive readable, writable, and unreadable roots from the same
  most-specific resolution rules
  - add regression coverage for nested `write` / `read` / `none` carveouts
  and legacy bridge enforcement detection
  
  ## Testing
  - cargo test -p codex-protocol
  - cargo clippy -p codex-protocol --tests -- -D warnings

  viyatb-oai · 2026-03-12 01:35:44 +00:00
  f276325cdc
• feat: search_tool migrate to bring you own tool of Responses API (#14274)

  ## Why
  
  to support a new bring your own search tool in Responses
  API(https://developers.openai.com/api/docs/guides/tools-tool-search#client-executed-tool-search)
  we migrating our bm25 search tool to use official way to execute search
  on client and communicate additional tools to the model.
  
  ## What
  - replace the legacy `search_tool_bm25` flow with client-executed
  `tool_search`
  - add protocol, SSE, history, and normalization support for
  `tool_search_call` and `tool_search_output`
  - return namespaced Codex Apps search results and wire namespaced
  follow-up tool calls back into MCP dispatch

  Anton Panasenko · 2026-03-11 17:51:51 -07:00
  77b0c75267
• Let models opt into original image detail (#14175)

  ## Summary
  
  This PR narrows original image detail handling to a single opt-in
  feature:
  
  - `image_detail_original` lets the model request `detail: "original"` on
  supported models
  - Omitting `detail` preserves the default resized behavior
  
  The model only sees `detail: "original"` guidance when the active model
  supports it:
  
  - JS REPL instructions include the guidance and examples only on
  supported models
  - `view_image` only exposes a `detail` parameter when the feature and
  model can use it
  
  The image detail API is intentionally narrow and consistent across both
  paths:
  
  - `view_image.detail` supports only `"original"`; otherwise omit the
  field
  - `codex.emitImage(..., detail)` supports only `"original"`; otherwise
  omit the field
  - Unsupported explicit values fail clearly at the API boundary instead
  of being silently reinterpreted
  - Unsupported explicit `detail: "original"` requests fall back to normal
  behavior when the feature is disabled or the model does not support
  original detail

  Curtis 'Fjord' Hawthorne · 2026-03-11 15:25:07 -07:00
  8791f0ab9a
• Add js_repl cwd and homeDir helpers (#14385)

  ## Summary
  
  This PR adds two read-only path helpers to `js_repl`:
  
  - `codex.cwd`
  - `codex.homeDir`
  
  They are exposed alongside the existing `codex.tmpDir` helper so the
  REPL can reference basic host path context without reopening direct
  `process` access.
  
  ## Implementation
  
  - expose `codex.cwd` and `codex.homeDir` from the js_repl kernel
  - make `codex.homeDir` come from the kernel process environment
  - pass session dependency env through js_repl kernel startup so
  `codex.homeDir` matches the env a shell-launched process would see
  - keep existing shell `HOME` population behavior unchanged
  - update js_repl prompt/docs and add runtime/integration coverage for
  the new helpers

  Curtis 'Fjord' Hawthorne · 2026-03-11 14:44:44 -07:00
  5a89660ae4
• Defer initial context insertion until the first turn (#14313)

  ## Summary
  - defer fresh-session `build_initial_context()` until the first real
  turn instead of seeding model-visible context during startup
  - rely on the existing `reference_context_item == None` turn-start path
  to inject full initial context on that first real turn (and again after
  baseline resets such as compaction)
  - add a regression test for `InitialHistory::New` and update affected
  deterministic tests / snapshots around developer-message layout,
  collaboration instructions, personality updates, and compact request
  shapes
  
  ## Notes
  - this PR does not add any special empty-thread `/compact` behavior
  - most of the snapshot churn is the direct result of moving the initial
  model-visible context from startup to the first real turn, so first-turn
  request layouts no longer contain a pre-user startup copy of permissions
  / environment / other developer-visible context
  - remote manual `/compact` with no prior user still skips the remote
  compact request; local first-turn `/compact` still issues a compact
  request, but that request now reflects the lack of startup-seeded
  context
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  Charley Cunningham · 2026-03-11 12:33:10 -07:00
  f5bb338fdb
• Clarify locked role settings in spawn prompt (#14283)

  - tell agents when a role pins model or reasoning effort so they know
  those settings are not changeable
  - add prompt-builder coverage for the locked-setting notes

  Ahmed Ibrahim · 2026-03-11 12:33:10 -07:00
  c32c445f1c
• feat(core): emit turn metric for network proxy state (#14250)

  ## Summary
  - add a per-turn `codex.turn.network_proxy` metric constant
  - emit the metric from turn completion using the live managed proxy
  enabled state
  - add focused tests for active and inactive tag emission

  viyatb-oai · 2026-03-11 12:33:10 -07:00
  52a3bde6cc
• spawn prompt (#14362)

  # External (non-OpenAI) Pull Request Requirements
  
  Before opening this Pull Request, please read the dedicated
  "Contributing" markdown file or your PR may be closed:
  https://github.com/openai/codex/blob/main/docs/contributing.md
  
  If your PR conforms to our contribution guidelines, replace this text
  with a detailed and high quality description of your changes.
  
  Include a link to a bug report or enhancement request.

  Ahmed Ibrahim · 2026-03-11 12:33:10 -07:00
  8f8a0f55ce
• Add ALL_TOOLS export to code mode (#14294)

  So code mode can search for tools.

  pakrym-oai · 2026-03-11 12:33:10 -07:00
  65b325159d
• chore: wire through plugin policies + category from marketplace.json (#14305)

  wire plugin marketplace metadata through app-server endpoints:
  - `plugin/list` has `installPolicy` and `authPolicy`
  - `plugin/install` has plugin-level `authPolicy`
  
  `plugin/install` also now enforces `NOT_AVAILABLE` `installPolicy` when
  installing.
  
  
  added tests.

  sayan-oai · 2026-03-11 12:33:10 -07:00
  7b2cee53db
• fix(otel): make HTTP trace export survive app-server runtimes (#14300)

  ## Summary
  
  This PR fixes OTLP HTTP trace export in runtimes where the previous
  exporter setup was unreliable, especially around app-server usage. It
  also removes the old `codex_otel::otel_provider` compatibility shim and
  switches remaining call sites over to the crate-root
  `codex_otel::OtelProvider` export.
  
  ## What changed
  
  - Use a runtime-safe OTLP HTTP trace exporter path for Tokio runtimes.
  - Add an async HTTP client path for trace export when we are already
  inside a multi-thread Tokio runtime.
  - Make provider shutdown flush traces before tearing down the tracer
  provider.
  - Add loopback coverage that verifies traces are actually sent to
  `/v1/traces`:
    - outside Tokio
    - inside a multi-thread Tokio runtime
    - inside a current-thread Tokio runtime
  - Remove the `codex_otel::otel_provider` shim and update remaining
  imports.
  
  ## Why
  
  I hit cases where spans were being created correctly but never made it
  to the collector. The issue turned out to be in exporter/runtime
  behavior rather than the span plumbing itself. This PR narrows that gap
  and gives us regression coverage for the actual export path.

  Owen Lin · 2026-03-11 12:33:10 -07:00
  fa1242c83b
• Allow bool web_search in ToolsToml (#14352)

  Summary
  - add a custom deserializer so `[tools].web_search` can be a bool
  (treated as disabled) or a config object
  - extend core and app-server tests to cover bool handling in TOML config
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-03-11 12:33:10 -07:00
  548583198a
• Revert "Pass more params to compaction" (#14298)
  Rasmus Rygaard · 2026-03-11 12:33:10 -07:00
  7f22329389
• Responses: set x-client-request-id as convesration_id when talking to responses (#14312)

  Right now we're sending the header session_id to responses which is
  ignored/dropped. This sets a useful x-client-request-id to the
  conversation_id.

  Channing Conger · 2026-03-11 12:33:10 -07:00
  fd4a673525
• fix(arc_monitor): api path (#14290)

  This PR just fixes the API path for ARC monitor.

  Fouad Matin · 2026-03-11 12:33:10 -07:00
  f385199cc0
• Add snippets annotated with types to tools when code mode enabled (#14284)

  Main purpose is for code mode to understand the return type.

  pakrym-oai · 2026-03-11 12:33:09 -07:00
  12ee9eb6e0
• Split spawn_csv from multi_agent (#14282)

  - make `spawn_csv` a standalone feature for CSV agent jobs
  - keep `spawn_csv -> multi_agent` one-way and preserve restricted
  subagent disable paths

  Ahmed Ibrahim · 2026-03-11 12:33:09 -07:00
  a4d884c767
• Add realtime start instructions config override (#14270)

  - add `realtime_start_instructions` config support
  - thread it into realtime context updates, schema, docs, and tests

  Ahmed Ibrahim · 2026-03-11 12:33:09 -07:00
  39c1bc1c68
• Make unified exec session_id numeric (#14279)

  It's a number on the write_stdin input, make it a number on the output
  and also internally.

  pakrym-oai · 2026-03-11 12:33:09 -07:00
  31bf1dbe63
• Prefix code mode output with success or failure message and include error stack (#14272)
  pakrym-oai · 2026-03-11 12:33:09 -07:00
  01792a4c61
• Stabilize websocket response.failed error delivery (#14017)

  ## What changed
  - Drop failed websocket connections immediately after a terminal stream
  error instead of awaiting a graceful close handshake before forwarding
  the error to the caller.
  - Keep the success path and the closed-connection guard behavior
  unchanged.
  
  ## Why this fixes the flake
  - The failing integration test waits for the second websocket stream to
  surface the model error before issuing a follow-up request.
  - On slower runners, the old error path awaited
  `ws_stream.close().await` before sending the error downstream. If that
  close handshake stalled, the test kept waiting for an error that had
  already happened server-side and nextest timed it out.
  - Dropping the failed websocket immediately makes the terminal error
  observable right away and marks the session closed so the next request
  reconnects cleanly instead of depending on a best-effort close
  handshake.
  
  ## Code or test?
  - This is a production logic fix in `codex-api`. The existing websocket
  integration test already exercises the regression path.

  Ahmed Ibrahim · 2026-03-11 12:33:09 -07:00
  c8446d7cf3
• Show spawned agent model and effort in TUI (#14273)

  - include the requested sub-agent model and reasoning effort in the
  spawn begin event\n- render that metadata next to the spawned agent name
  and role in the TUI transcript
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  Ahmed Ibrahim · 2026-03-11 12:33:09 -07:00
  285b3a5143
• Rename code mode tool to exec (#14254)

  Summary
  - update the code-mode handler, runner, instructions, and error text to
  refer to the `exec` tool name everywhere that used to say `code_mode`
  - ensure generated documentation strings and tool specs describe `exec`
  and rely on the shared `PUBLIC_TOOL_NAME`
  - refresh the suite tests so they invoke `exec` instead of the old name
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-03-11 12:33:09 -07:00
  8a099b3dfb
• prompt changes to guardian (#14263)

  ## Summary
    - update the guardian prompting
  - clarify the guardian rejection message so an action may still proceed
  if the user explicitly approves it after being informed of the risk
  
    ## Testing
    - cargo run on selected examples

  maja-openai · 2026-03-11 12:33:09 -07:00
  e77b2fd925
• chore: add a separate reject-policy flag for skill approvals (#14271)

  ## Summary
  - add `skill_approval` to `RejectConfig` and the app-server v2
  `AskForApproval::Reject` payload so skill-script prompts can be
  configured independently from sandbox and rule-based prompts
  - update Unix shell escalation to reject prompts based on the actual
  decision source, keeping prefix rules tied to `rules`, unmatched command
  fallbacks tied to `sandbox_approval`, and skill scripts tied to
  `skill_approval`
  - regenerate the affected protocol/config schemas and expand
  unit/integration coverage for the new flag and skill approval behavior

  Celia Chen · 2026-03-11 12:33:09 -07:00
  c1a424691f
• Add store/load support for code mode (#14259)

  adds support for transferring state across code mode invocations.

  pakrym-oai · 2026-03-11 12:33:09 -07:00
  83b22bb612
• Pass more params to compaction (#14247)

  Pass more params to /compact. This should give us parity with the
  /responses endpoint to improve caching.
  
  I'm torn about the MCP await. Blocking will give us parity but it seems
  like we explicitly don't block on MCPs. Happy either way

  Rasmus Rygaard · 2026-03-11 12:33:09 -07:00
  2621ba17e3
• feat: Add additional macOS Sandbox Permissions for Launch Services, Contacts, Reminders (#14155)

  Add additional macOS Sandbox Permissions levers for the following:
  
  - Launch Services
  - Contacts
  - Reminders

  Leo Shimonaka · 2026-03-11 12:33:09 -07:00
  889b4796fc
• Add code_mode output helpers for text and images (#14244)

  Summary
  - document how code-mode can import `output_text`/`output_image` and
  ensure `add_content` stays compatible
  - add a synthetic `@openai/code_mode` module that appends content items
  and validates inputs
  - cover the new behavior with integration tests for structured text and
  image outputs
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-03-11 12:33:08 -07:00
  07c22d20f6
• Clarify close_agent tool description (#14269)

  - clarify the `close_agent` tool description so it nudges models to
  close agents they no longer need
  - keep the change scoped to the tool spec text only
  
  Co-authored-by: Codex <noreply@openai.com>

  Ahmed Ibrahim · 2026-03-11 12:33:08 -07:00
  ce1d9abf11
• Load agent metadata from role files (#14177)
  gabec-openai · 2026-03-11 12:33:08 -07:00
  a67660da2d
• Add model-controlled truncation for code mode results (#14258)

  Summary
  - document that `@openai/code_mode` exposes
  `set_max_output_tokens_per_exec_call` and that `code_mode` truncates the
  final Rust-side output when the budget is exceeded
  - enforce the configured budget in the Rust tool runner, reusing
  truncation helpers so text-only outputs follow the unified-exec wrapper
  and mixed outputs still fit within the limit
  - ensure the new behavior is covered by a code-mode integration test and
  string spec update
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-03-11 12:33:08 -07:00
  3d41ff0b77
• Add output schema to MCP tools and expose MCP tool results in code mode (#14236)

  Summary
  - drop `McpToolOutput` in favor of `CallToolResult`, moving its helpers
  to keep MCP tooling focused on the final result shape
  - wire the new schema definitions through code mode, context, handlers,
  and spec modules so MCP tools serialize the exact output shape expected
  by the model
  - extend code mode tests to cover multiple MCP call scenarios and ensure
  the serialized data matches the new schema
  - refresh JS runner helpers and protocol models alongside the schema
  changes
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-03-11 12:33:08 -07:00
  ee8f84153e
• unifying all image saves to /tmp to bug-proof (#14149)

  image-gen feature will have the model saving to /tmp by default + at all
  times

  Won Park · 2026-03-11 12:33:08 -07:00
  722e8f08e1
• Add spawn_agent model overrides (#14160)

  - add `model` and `reasoning_effort` to the `spawn_agent` schema so the
  values pass through
  - validate requested models against `model.model` and only check that
  the selected model supports the requested reasoning effort
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  Ahmed Ibrahim · 2026-03-11 12:33:08 -07:00
  91ca20c7c3
• feat: Allow sync with remote plugin status. (#14176)

  Add forceRemoteSync to plugin/list.
  When it is set to True, we will sync the local plugin status with the
  remote one (backend-api/plugins/list).

  xl-openai · 2026-03-11 12:33:08 -07:00
  d751e68f44
• add(core): arc_monitor (#13936)

  ## Summary
  - add ARC monitor support for MCP tool calls by serializing MCP approval
  requests into the ARC action shape and sending the relevant
  conversation/policy context to the `/api/codex/safety/arc` endpoint
  - route ARC outcomes back into MCP approval flow so `ask-user` falls
  back to a user prompt and `steer-model` blocks the tool call, with
  guardian/ARC tests covering the new request shape
  - update the TUI approval copy from “Approve Once” to “Allow” / “Allow
  for this session” and refresh the related
    snapshots
  
  ---------
  
  Co-authored-by: Fouad Matin <fouad@openai.com>
  Co-authored-by: Fouad Matin <169186268+fouad-openai@users.noreply.github.com>

  Matthew Zeng · 2026-03-11 12:33:08 -07:00
  f2d66fadd8
• Reuse McpToolOutput in McpHandler (#14229)

  We already have a type to represent the MCP tool output, reuse it
  instead of the custom McpHandlerOutput

  pakrym-oai · 2026-03-11 12:33:07 -07:00
  c4d35084f5
• Expose strongly-typed result for exec_command (#14183)

  Summary
  - document output types for the various tool handlers and registry so
  the API exposes richer descriptions
  - update unified execution helpers and client tests to align with the
  new output metadata
  - clean up unused helpers across tool dispatch paths
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-03-11 12:33:07 -07:00
  00ea8aa7ee
• Log ChatGPT user ID for feedback tags (#13901)

  There are some bug investigations that currently require us to ask users
  for their user ID even though they've already uploaded logs and session
  details via `/feedback`. This frustrates users and increases the time
  for diagnosis.
  
  This PR includes the ChatGPT user ID in the metadata uploaded for
  `/feedback` (both the TUI and app-server).

  Eric Traut · 2026-03-11 12:33:07 -07:00
  f9cba5cb16
• Fix Linux tmux segfault in user shell lookup (#13900)

  Replace the Unix shell lookup path in `codex-rs/core/src/shell.rs` to
  use
  `libc::getpwuid_r()` instead of `libc::getpwuid()` when resolving the
  current
  user's shell.
  
  Why:
  - `getpwuid()` can return pointers into libc-managed shared storage
  - on the musl static Linux build, concurrent callers can race on that
  storage
  - this matches the crash pattern reported in tmux/Linux sessions with
  parallel
    shell activity
  
  Refs:
  - Fixes #13842

  Eric Traut · 2026-03-11 12:33:07 -07:00
  026cfde023
• Fix release-mode integration test compiler failure (#13603)

  Addresses #13586
  
  This doesn't affect our CI scripts. It was user-reported.
  
  Summary
  - add `wiremock::ResponseTemplate` and `body_string_contains` imports
  behind `#[cfg(not(debug_assertions))]` in
  `codex-rs/core/tests/suite/view_image.rs` so release builds only pull
  the helpers they actually use

  Eric Traut · 2026-03-11 12:33:07 -07:00
  7144f84c69
• Fix unified exec test output assertion (#14184)

  ## Summary
  - update the unified exec test to use truncated_output() instead of the
  removed output field
  - fix the compile failure on latest main after ExecCommandToolOutput
  changed shape

  Ahmed Ibrahim · 2026-03-09 23:12:36 -07:00
  6b7253b123
• Stabilize incomplete SSE retry test (#13879)

  ## What changed
  - The retry test now uses the same streaming SSE test server used by
  production-style tests instead of a wiremock sequence.
  - The fixture is resolved via `find_resource!`, and the test asserts
  that exactly two outbound requests were sent.
  
  ## Why this fixes the flake
  - The old wiremock sequence approximated early-close behavior, but it
  did not reproduce the same streaming semantics the real client sees.
  - That meant the retry path depended on mock implementation details
  instead of on the actual transport behavior we care about.
  - Switching to the streaming SSE helper makes the test exercise the real
  early-close/retry contract, and counting requests directly verifies that
  we retried exactly once rather than merely hoping the sequence aligned.
  
  ## Scope
  - Test-only change.

  Ahmed Ibrahim · 2026-03-09 22:34:44 -07:00
  aa6a57dfa2
• Use realtime transcript for handoff context (#14132)

  - collect input/output transcript deltas into active handoff transcript
  state
  - attach and clear that transcript on each handoff, and regenerate
  schema/tests

  Ahmed Ibrahim · 2026-03-09 22:30:03 -07:00
  2e24be2134
• Implemented thread-level atomic elicitation counter for stopwatch pausing (#12296)

  ### Purpose
  While trying to build out CLI-Tools for the agent to use under skills we
  have found that those tools sometimes need to invoke a user elicitation.
  These elicitations are handled out of band of the codex app-server but
  need to indicate to the exec manager that the command running is not
  going to progress on the usual timeout horizon.
  
  ### Example
  Model calls universal exec:
  `$ download-credit-card-history --start-date 2026-01-19 --end-date
  2026-02-19 > credit_history.jsonl`
  
  download-cred-card-history might hit a hosted/preauthenticated service
  to fetch data. That service might decide that the request requires an
  end user approval the access to the personal data. It should be able to
  signal to the running thread that the command in question is blocked on
  user elicitation. In that case we want the exec to continue, but the
  timeout to not expire on the tool call, essentially freezing time until
  the user approves or rejects the command at which point the tool would
  signal the app-server to decrement the outstanding elicitation count.
  Now timeouts would proceed as normal.
  
  ### What's Added
  
  - New v2 RPC methods:
      - thread/increment_elicitation
      - thread/decrement_elicitation
  - Protocol updates in:
      - codex-rs/app-server-protocol/src/protocol/common.rs
      - codex-rs/app-server-protocol/src/protocol/v2.rs
  - App-server handlers wired in:
      - codex-rs/app-server/src/codex_message_processor.rs
  
  ### Behavior
  
  - Counter starts at 0 per thread.
  - increment atomically increases the counter.
  - decrement atomically decreases the counter; decrement at 0 returns
  invalid request.
  - Transition rules:
  - 0 -> 1: broadcast pause state, pausing all active stopwatches
  immediately.
      - \>0 -> >0: remain paused.
      - 1 -> 0: broadcast unpause state, resuming stopwatches.
  - Core thread/session logic:
      - codex-rs/core/src/codex_thread.rs
      - codex-rs/core/src/codex.rs
      - codex-rs/core/src/mcp_connection_manager.rs
  
  ### Exec-server stopwatch integration
  
  - Added centralized stopwatch tracking/controller:
      - codex-rs/exec-server/src/posix/stopwatch_controller.rs
  - Hooked pause/unpause broadcast handling + stopwatch registration:
      - codex-rs/exec-server/src/posix/mcp.rs
      - codex-rs/exec-server/src/posix/stopwatch.rs
      - codex-rs/exec-server/src/posix.rs

  Channing Conger · 2026-03-09 22:29:26 -07:00
  c6343e0649
• [apps] Fix apps enablement condition. (#14011)

  - [x] Fix apps enablement condition to check both the feature flag and
  that the user is not an API key user.

  Matthew Zeng · 2026-03-09 22:25:43 -07:00
  566e4cee4b
• Move exec command truncation into ExecCommandToolOutput (#14169)

  Summary
  - relocate truncation logic for exec command output into the new
  `ExecCommandToolOutput` response helper instead of centralized handler
  code
  - update all affected tools and unified exec handling to use the new
  response item structure and eliminate `Function(FunctionToolOutput)`
  responses
  - adjust context, registry, and handler interfaces to align with the new
  response semantics and error fields
  
  Testing
  - Not run (not requested)

  pakrym-oai · 2026-03-09 22:13:48 -07:00
  a9ae43621b
• feat: support disabling bundled system skills (#13792)

  Support disable bundled system skills with a config:
  
  [skills.bundled]
  enabled = false

  xl-openai · 2026-03-09 22:02:53 -07:00
  0c33af7746
• Export tools module into code mode runner (#14167)

  **Summary**
  - allow `code_mode` to pass enabled tools metadata to the runner and
  expose them via `tools.js`
  - import tools inside JavaScript rather than relying only on globals or
  proxies for nested tool calls
  - update specs, docs, and tests to exercise the new bridge and explain
  the tooling changes
  
  **Testing**
  - Not run (not requested)

  pakrym-oai · 2026-03-09 21:59:09 -07:00
  710682598d