codex

otel test: retry WouldBlock errors (#8915 )

This test looks flaky on Windows:

```
        FAIL [   0.034s] (1442/2802) codex-otel::tests suite::otlp_http_loopback::otlp_http_exporter_sends_metrics_to_collector
  stdout ───

    running 1 test
    test suite::otlp_http_loopback::otlp_http_exporter_sends_metrics_to_collector ... FAILED

    failures:

    failures:
        suite::otlp_http_loopback::otlp_http_exporter_sends_metrics_to_collector

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 14 filtered out; finished in 0.02s
    
  stderr ───
    Error: ProviderShutdown { source: InternalFailure("[InternalFailure(\"Failed to shutdown\")]") }

────────────
     Summary [ 175.360s] 2802 tests run: 2801 passed, 1 failed, 15 skipped
        FAIL [   0.034s] (1442/2802) codex-otel::tests suite::otlp_http_loopback::otlp_http_exporter_sends_metrics_to_collector
```

gt-oai · 2026-01-08 18:18:49 +00:00

93dec9045e

clean: all history cloning (#8916 )

jif-oai · 2026-01-08 18:17:18 +00:00

69898e3dba

[fix] app server flaky thread/resume tests (#8870 )

Fix flakiness of CI tests:
https://github.com/openai/codex/actions/runs/20350530276/job/58473691443?pr=8282

This PR does two things:
1. test with responses API instead of chat completions API in
thread_resume tests;
2. have a new responses API fixture that mocks out arbitrary numbers of
responses API calls (including no calls) and have the same repeated
response.

Tested by CI

Celia Chen · 2026-01-08 10:17:05 -08:00

c4af304c77

feat: add list loaded threads to app server (#8902 )

jif-oai · 2026-01-08 17:48:20 +00:00

5b7707dfb1

fix: reduce duplicate include_str!() calls (#8914 )

Michael Bolin · 2026-01-08 17:20:41 +00:00

59d6937550

config requirements: improve requirement error messages (#8843 )

**Before:**
```
Error loading configuration: value `Never` is not in the allowed set [OnRequest]
```

**After:**
```
Error loading configuration: invalid value for `approval_policy`: `Never` is not in the
allowed set [OnRequest] (set by MDM com.openai.codex:requirements_toml_base64)
```

Done by introducing a new struct `ConfigRequirementsWithSources` onto
which we `merge_unset_fields` now. Also introduces a pair of requirement
value and its `RequirementSource` (inspired by `ConfigLayerSource`):

```rust
pub struct Sourced<T> {
    pub value: T,
    pub source: RequirementSource,
}
```

gt-oai · 2026-01-08 16:11:14 +00:00

932a5a446f

gitignore bazel-* (#8911 )

QoL improvement so we don't accidentally add these dirs while we
prototype bazel things

zbarsky-openai · 2026-01-08 07:50:58 -08:00

484f6f4c26

feat: add a few metrics (#8910 )

jif-oai · 2026-01-08 15:39:57 +00:00

5522663f92

nit: drop unused function call error (#8903 )

jif-oai · 2026-01-08 15:07:30 +00:00

98e171258c

chore: drop useless interaction_input (#8907 )

jif-oai · 2026-01-08 15:01:07 +00:00

da667b1f56

fix: leverage codex_utils_cargo_bin() in codex-rs/core/tests/suite (#8887 )

This eliminates our dependency on the `escargot` crate and better
prepares us for Bazel builds: https://github.com/openai/codex/pull/8875.

Michael Bolin · 2026-01-08 14:56:16 +00:00

1e29774fce

Avoid setpgid for inherited stdio on macOS (#8691 )

## Summary
- avoid setting a new process group when stdio is inherited (keeps child
in foreground PG)
- keep process-group isolation when stdio is redirected so killpg
cleanup still works
- prevents macOS job-control SIGTTIN stops that look like hangs after
output

## Testing
- `cargo build -p codex-cli`
- `GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_NOSYSTEM=1
CARGO_BIN_EXE_codex=/Users/denis/Code/codex/codex-rs/target/debug/codex
/opt/homebrew/bin/timeout 30m cargo test -p codex-core -p codex-exec`

## Context
This fixes macOS sandbox hangs for commands like `elixir -v` / `erl
-noshell`, where the child was moved into a new process group while
still attached to the controlling TTY. See issue #8690.

## Authorship & collaboration
- This change and analysis were authored by **Codex** (AI coding agent).
- Human collaborator: @seeekr provided repro environment, context, and
review guidance.
- CLI used: `codex-cli 0.77.0`.
- Model: `gpt-5.2-codex (xhigh)`.

Co-authored-by: Eric Traut <etraut@openai.com>

Denis Andrejew · 2026-01-08 07:50:40 -07:00

9ce6bbc43e

fix: leverage find_resource! macro in load_sse_fixture_with_id (#8888 )

This helps prepare us for Bazel builds:
https://github.com/openai/codex/pull/8875.

Michael Bolin · 2026-01-08 09:34:05 -05:00

7520d8ba58

chore: add small debug client (#8894 )

Small debug client, do not use in production

jif-oai · 2026-01-08 13:40:14 +00:00

0318f30ed8

fix: include project instructions in /review subagent (#8899 )

Include project-level AGENTS.md and skills in /review sessions so the
review sub-agent uses the same instruction pipeline as standard runs,
keeping reviewer context aligned with normal sessions.

Thibault Sottiaux · 2026-01-08 13:31:01 +00:00

be212db0c8

chore: align error limit comment (#8896 )

Thibault Sottiaux · 2026-01-08 13:30:33 +00:00

5b022c2904

chore: drop metrics exporter config (#8892 )

Dropped for now as enterprises should not be able to use it

jif-oai · 2026-01-08 13:20:18 +00:00

e21ce6c5de

fix: stabilize list_dir pagination order (#8826 )

Sort list_dir entries before applying offset/limit so pagination matches
the displayed order, update pagination/truncation expectations, and add
coverage for sorted pagination. This ensures stable, predictable
directory pages when list_dir is enabled.

Thibault Sottiaux · 2026-01-08 03:51:47 -08:00

267c05fb30

feat: metrics capabilities (#8318 )

Add metrics capabilities to Codex. The `README.md` is up to date.

This will not be merged with the metrics before this PR of course:
https://github.com/openai/codex/pull/8350

jif-oai · 2026-01-08 11:47:36 +00:00

634650dd25

chore: add list thread ids on manager (#8855 )

jif-oai · 2026-01-08 10:53:58 +00:00

8a0c2e5841

fix: windows can now paste non-ascii multiline text (#8774 )

## Summary
This PR builds _heavily_ on the work from @occurrent in #8021 - I've
only added a small fix, added additional tests, and propagated the
changes to tui2.

From the original PR:

> On Windows, Codex relies on PasteBurst for paste detection because
bracketed paste is not reliably available via crossterm.
> 
> When pasted content starts with non-ASCII characters, input is routed
through handle_non_ascii_char, which bypasses the normal paste burst
logic. This change extends the paste burst window for that path, which
should ensure that Enter is correctly grouped as part of the paste.


## Testing
- [x] tested locally cross-platform
- [x] added regression tests

---------

Co-authored-by: occur <occurring@outlook.com>

Dylan Hurd · 2026-01-07 23:21:49 -08:00

0f8bb4579b

fix: make the find_resource! macro responsible for the absolutize() call (#8884 )

https://github.com/openai/codex/pull/8879 introduced the
`find_resource!` macro, but now that I am about to use it in more
places, I realize that it should take care of this normalization case
for callers.

Note the `use $crate::path_absolutize::Absolutize;` line is there so
that users of `find_resource!` do not have to explicitly include
`path-absolutize` to their own `Cargo.toml`.

Michael Bolin · 2026-01-07 23:03:43 -08:00

35fd69a9f0

add ability to disable input temporarily in the TUI. (#8876 )

We will disable input while the elevated sandbox setup is running.

iceweasel-oai · 2026-01-07 20:56:48 -08:00

ccba737d26

Support UserInput::Skill in V2 API. (#8864 )

Allow client to specify explicit skill invocation in v2 API.

xl-openai · 2026-01-07 18:26:35 -08:00

75076aabfe

feat: introduce find_resource! macro that works with Cargo or Bazel (#8879 )

To support Bazelification in https://github.com/openai/codex/pull/8875,
this PR introduces a new `find_resource!` macro that we use in place of
our existing logic in tests that looks for resources relative to the
compile-time `CARGO_MANIFEST_DIR` env var.

To make this work, we plan to add the following to all `rust_library()`
and `rust_test()` Bazel rules in the project:

```
rustc_env = {
    "BAZEL_PACKAGE": native.package_name(),
},
```

Our new `find_resource!` macro reads this value via
`option_env!("BAZEL_PACKAGE")` so that the Bazel package _of the code
using `find_resource!`_ is injected into the code expanded from the
macro. (If `find_resource()` were a function, then
`option_env!("BAZEL_PACKAGE")` would always be
`codex-rs/utils/cargo-bin`, which is not what we want.)

Note we only consider the `BAZEL_PACKAGE` value when the `RUNFILES_DIR`
environment variable is set at runtime, indicating that the test is
being run by Bazel. In this case, we have to concatenate the runtime
`RUNFILES_DIR` with the compile-time `BAZEL_PACKAGE` value to build the
path to the resource.

In testing this change, I discovered one funky edge case in
`codex-rs/exec-server/tests/common/lib.rs` where we have to _normalize_
(but not canonicalize!) the result from `find_resource!` because the
path contains a `common/..` component that does not exist on disk when
the test is run under Bazel, so it must be semantically normalized using
the [`path-absolutize`](https://crates.io/crates/path-absolutize) crate
before it is passed to `dotslash fetch`.

Because this new behavior may be non-obvious, this PR also updates
`AGENTS.md` to make humans/Codex aware that this API is preferred.

Michael Bolin · 2026-01-07 18:06:08 -08:00

f6b563ec64

add footer note to TUI (#8867 )

This will be used by the elevated sandbox NUX to give a hint on how to
run the elevated sandbox when in the non-elevated mode.

iceweasel-oai · 2026-01-07 16:44:28 -08:00

357e4c902b

fix: use tokio for I/O in an async function (#8868 )

I thought this might solve a bug I'm working on, but it turned out to be
a red herring. Nevertheless, this seems like the right thing to do here.

Michael Bolin · 2026-01-07 16:36:23 -08:00

ef8b8ebc94

fix: update resource path resolution logic so it works with Bazel (#8861 )

The Bazelification work in-flight over at
https://github.com/openai/codex/pull/8832 needs this fix so that Bazel
can find the path to the DotSlash file for `bash`.

With this change, the following almost works:

```
bazel test --test_output=errors //codex-rs/exec-server:exec-server-all-test
```

That is, now the `list_tools` test passes, but
`accept_elicitation_for_prompt_rule` still fails because it runs
Seatbelt itself, so it needs to be run outside Bazel's local sandboxing.

Michael Bolin · 2026-01-07 22:33:05 +00:00

54b290ec1d

Feat: appServer.requirementList for requirement.toml (#8800 )

### Summary
We are exposing requirements via `requirement/list` method from
app-server so that we can conditionally disable the agent mode dropdown
selection in VSCE and correctly setting the default value.

### Sample output
#### `etc/codex/requirements.toml`
<img width="497" height="49" alt="Screenshot 2026-01-06 at 11 32 06 PM"
src="https://github.com/user-attachments/assets/fbd9402e-515f-4b9e-a158-2abb23e866a0"
/>

#### App server response
<img width="1107" height="79" alt="Screenshot 2026-01-06 at 11 30 18 PM"
src="https://github.com/user-attachments/assets/c0d669cd-54ef-4789-a26c-adb2c41950af"
/>

Shijie Rao · 2026-01-07 13:57:44 -08:00

efd0c21b9b

Support symlink for skills discovery. (#8801 )

Skills discovery now follows symlink entries for SkillScope::User
($CODEX_HOME/skills) and SkillScope::Admin (e.g. /etc/codex/skills).

Added cycle protection: directories are canonicalized and tracked in a
visited set to prevent infinite traversal from circular links.

Added per-root traversal limits to avoid accidentally scanning huge
trees:
- max depth: 6
- max directories: 2000 (logs a warning if truncated)

For now, symlink stat failures and traversal truncation are logged
rather than surfaced as UI “invalid SKILL.md” warnings.

xl-openai · 2026-01-07 13:34:48 -08:00

61e81af887

Warn in /model if BASE_URL set (#8847 )

<img width="763" height="349" alt="Screenshot 2026-01-07 at 18 37 59"
src="https://github.com/user-attachments/assets/569d01cb-ea91-4113-889b-ba74df24adaf"
/>

It may not make sense to use the `/model` menu with a custom
OPENAI_BASE_URL. But some model proxies may support it, so we shouldn't
disable it completely. A warning is a reasonable compromise.

gt-oai · 2026-01-07 21:24:18 +00:00

f07b8aa591

Clarify YAML frontmatter formatting in skill-creator (#8610 )

Fixes #8609

# Summary

Emphasize single-line name/description values and quoting when values
could be interpreted as YAML syntax.

# Testing

Not run (skill-only change.)

darlingm · 2026-01-07 14:24:02 -07:00

5f3f70203c

Add feature for optional request compression (#8767 )

Adds a new feature
`enable_request_compression` that will compress using zstd requests to
the codex-backend. Currently only enabled for codex-backend so only enabled for openai providers when using chatgpt::auth even when the feature is enabled

Added a new info log line too for evaluating the compression ratio and
overhead off compressing before requesting. You can enable with
`RUST_LOG=$RUST_LOG,codex_client::transport=info`

```
2026-01-06T00:09:48.272113Z  INFO codex_client::transport: Compressed request body with zstd pre_compression_bytes=28914 post_compression_bytes=11485 compression_duration_ms=0
```

Channing Conger · 2026-01-07 13:21:40 -08:00

21c6d40a44

Simplify error managment in run_turn (#8849 )

Ahmed Ibrahim · 2026-01-07 13:15:46 -08:00

a9b5e8a136

Override truncation policy at model info level (#8856 )

We used to override truncation policy by comparing model info vs config
value in context manager. A better way to do it is to construct model
info using the config value

Ahmed Ibrahim · 2026-01-07 13:06:20 -08:00

187924d761

fix: implement 'Allow this session' for apply_patch approvals (#8451 )

**Summary**
This PR makes “ApprovalDecision::AcceptForSession / don’t ask again this
session” actually work for `apply_patch` approvals by caching approvals
based on absolute file paths in codex-core, properly wiring it through
app-server v2, and exposing the choice in both TUI and TUI2.
- This brings `apply_patch` calls to be at feature-parity with general
shell commands, which also have a "Yes, and don't ask again" option.
- This also fixes VSCE's "Allow this session" button to actually work.

While we're at it, also split the app-server v2 protocol's
`ApprovalDecision` enum so execpolicy amendments are only available for
command execution approvals.

**Key changes**
- Core: per-session patch approval allowlist keyed by absolute file
paths
- Handles multi-file patches and renames/moves by recording both source
and destination paths for `Update { move_path: Some(...) }`.
- Extend the `Approvable` trait and `ApplyPatchRuntime` to work with
multiple keys, because an `apply_patch` tool call can modify multiple
files. For a request to be auto-approved, we will need to check that all
file paths have been approved previously.
- App-server v2: honor AcceptForSession for file changes
- File-change approval responses now map AcceptForSession to
ReviewDecision::ApprovedForSession (no longer downgraded to plain
Approved).
- Replace `ApprovalDecision` with two enums:
`CommandExecutionApprovalDecision` and `FileChangeApprovalDecision`
- TUI / TUI2: expose “don’t ask again for these files this session”
- Patch approval overlays now include a third option (“Yes, and don’t
ask again for these files this session (s)”).
    - Snapshot updates for the approval modal.

**Tests added/updated**
- Core:
- Integration test that proves ApprovedForSession on a patch skips the
next patch prompt for the same file
- App-server:
- v2 integration test verifying
FileChangeApprovalDecision::AcceptForSession works properly

**User-visible behavior**
- When the user approves a patch “for session”, future patches touching
only those previously approved file(s) will no longer prompt gain during
that session (both via app-server v2 and TUI/TUI2).

**Manual testing**
Tested both TUI and TUI2 - see screenshots below.

TUI:
<img width="1082" height="355" alt="image"
src="https://github.com/user-attachments/assets/adcf45ad-d428-498d-92fc-1a0a420878d9"
/>


TUI2:
<img width="1089" height="438" alt="image"
src="https://github.com/user-attachments/assets/dd768b1a-2f5f-4bd6-98fd-e52c1d3abd9e"
/>

Owen Lin · 2026-01-07 20:11:12 +00:00

66450f0445

[chore] update app server doc with skills (#8853 )

Celia Chen · 2026-01-07 20:07:01 +00:00

e8421c761c

chore: drop some deprecated (#8848 )

jif-oai · 2026-01-07 19:54:45 +00:00

fe460e0f9a

chore: drop useless feature flags (#8850 )

jif-oai · 2026-01-07 19:54:32 +00:00

1253d19641

Fix app-server write_models_cache to treat models with less priority number as higher priority. (#8844 )

Rank models with p0 higher than p1. This shouldn't result in any
behavioral changes. Just reordering.

Ahmed Ibrahim · 2026-01-07 11:22:13 -08:00

4c9b4b684f

Stop using AuthManager as the source of codex_home (#8846 )

pakrym-oai · 2026-01-07 18:56:20 +00:00

018de994b0

remove unnecessary todos (#8842 )

> // todo(aibrahim): why are we passing model here while it can change?

we update it on each turn with `.with_model`

> //TODO(aibrahim): run CI in release mode.

although it's good to have, release builds take double the time tests
take.

> // todo(aibrahim): make this async function

we figured out another way of doing this sync

Ahmed Ibrahim · 2026-01-07 10:43:10 -08:00

c31960b13a

Merge Modelfamily into modelinfo (#8763 )

- Merge ModelFamily into ModelInfo
- Remove logic for adding instructions to apply patch
- Add compaction limit and visible context window to `ModelInfo`

Ahmed Ibrahim · 2026-01-07 10:35:09 -08:00

9179c9deac

fix: upgrade lru crate to 0.16.3 (#8845 )

See https://rustsec.org/advisories/RUSTSEC-2026-0002.

Though our `ratatui` fork has a transitive dep on an older version of
the `lru` crate, so to get CI green ASAP, this PR also adds an exception
to `deny.toml` for `RUSTSEC-2026-0002`, but hopefully this will be
short-lived.

Michael Bolin · 2026-01-07 10:11:27 -08:00

a1e81180f8

Move tests below auth manager (#8840 )

To simplify future diffs

pakrym-oai · 2026-01-07 17:36:44 +00:00

fedcb8f63c

chore: unify conversation with thread name (#8830 )

Done and verified by Codex + refactor feature of RustRover

jif-oai · 2026-01-07 17:04:53 +00:00

116059c3a0

fix: handle early codex exec exit (#8825 )

Fixes CodexExec to avoid missing early process exits by registering the
exit handler up front and deferring the error until after stdout is
drained, and adds a regression test that simulates a fast-exit child
while still producing output so hangs are caught.

Thibault Sottiaux · 2026-01-07 08:54:27 -08:00

0d788e6263

chore: rename unified exec sessions (#8822 )

Renaming done by Codex

jif-oai · 2026-01-07 16:12:47 +00:00

4cef89a122

fix: handle /review arguments in TUI (#8823 )

Handle /review <instructions> in the TUI and TUI2 by routing it as a
custom review command instead of plain text, wiring command dispatch and
adding composer coverage so typing /review text starts a review directly
rather than posting a message. User impact: /review with arguments now
kicks off the review flow, previously it would just forward as a plain
command and not actually start a review.

Thibault Sottiaux · 2026-01-07 13:14:55 +00:00

124a09e577

fix: parse git apply paths correctly (#8824 )

Fixes apply.rs path parsing so 
- quoted diff headers are tokenized and extracted correctly, 
- /dev/null headers are ignored before prefix stripping to avoid bogus
dev/null paths, and
- git apply output paths are unescaped from C-style quoting.

**Why**
This prevents potentially missed staging and misclassified paths when
applying or reverting patches, which could lead to incorrect behavior
for repos with spaces or escaped characters in filenames.

**Impact**
I checked and this is only used in the cloud tasks support and `codex
apply <task_id>` flow.

Thibault Sottiaux · 2026-01-07 13:00:31 +00:00

a59052341d

2715 Commits