5402 Commits

This Branch

This Branch

All Branches

• Re-enable it (#18002)

  Reverts openai/codex#17981

  jif-oai · 2026-04-15 22:09:41 +01:00
  83dc8da9cc
• Dismiss stale app-server requests after remote resolution (#15134)

  Dismiss stale TUI app-server approvals after remote resolution
  
  When an approval, user-input prompt, or elicitation request is resolved
  by another client, the TUI now dismisses the matching local UI instead
  of leaving stale prompts behind and emitting a misleading local
  cancellation.
  
  This change teaches pending app-server request tracking to map
  `serverRequest/resolved` notifications back to the concrete request type
  and stable request key, then propagates that resolved request into TUI
  prompt state. Approval, request-user-input, and MCP elicitation overlays
  now drop the resolved current or queued request quietly, advance to the
  next queued request when present, and avoid emitting abort/cancel events
  for stale UI.
  
  The latest update also retires matching prompts while they are still
  deferred behind active streaming and suppresses buffered active-thread
  requests whose app-server request id has already been resolved before
  drain. `ChatWidget` removes a resolved request from both the deferred
  interrupt queue and the materialized bottom-pane stack, while
  active-thread request handling verifies the app-server request is still
  pending before showing a prompt. Lifecycle events such as exec begin/end
  remain queued so approved work can still render normally.
  
  Tests cover resolved-request mapping, overlay dismissal behavior,
  deferred prompt pruning for same-turn user input, exec approval IDs,
  lifecycle-event retention, and the buffered active-thread ordering
  regression.
  
  Validation:
  - `just fmt`
  - `git diff --check`
  - `cargo test -p codex-tui
  resolved_buffered_approval_does_not_become_actionable_after_drain`
  - `cargo test -p codex-tui
  enqueue_primary_thread_session_replays_buffered_approval_after_attach`
  - `cargo test -p codex-tui chatwidget::interrupts`
  - `just fix -p codex-tui`
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  Eugene Brevdo · 2026-04-15 13:57:41 -07:00
  bc969b6516
• [codex] Restore remote exec-server filesystem tests (#17989)

  ## Summary
  
  - Re-enable remote variants for the exec-server filesystem
  sandbox/symlink tests that were made local-only in PR #17671.
  - Restore `use_remote` parameterization for the readable-root,
  normalized symlink escape, symlink removal, and symlink
  copy-preservation cases.
  - Preserve `mode={use_remote}` context on key async filesystem failures
  so CI failures point at the local or remote lane.
  
  ## Validation
  
  - `cd codex-rs && just fmt`
  - Not run: `bazel test
  //codex-rs/exec-server:exec-server-file_system-test` per local Codex
  development guidance to avoid test runs unless explicitly requested.
  
  Co-authored-by: Codex <noreply@openai.com>

  starr-openai · 2026-04-15 20:48:13 +00:00
  ba36415a30
• Migrate archive/unarchive to local ThreadStore (#17892)

  # Summary
  - implement local ThreadStore archive/unarchive operations
  - implement local ThreadStore read_thread operation
  - break up the various ThreadStore local method implementations into
  separate files
  - migrate app-server archive/unarchive and core archive fixture to use
  ThreadStore (but not all read operations yet!)
  - use the ThreadStore's read operation as a proxy check for thread
  persistence/existence in the app server code
  - move all other filesystem operations related to archive (path
  validation etc) into the local thread store.
  
  # Tests
  - add dedicated local store archive/unarchive tests

  Tom · 2026-04-15 20:48:09 +00:00
  50d3128269
• Auto install start-codex-exec.sh dependencies (#17990)
  pakrym-oai · 2026-04-15 13:27:17 -07:00
  ab715021e6
• [docs] Add security boundaries reference in SECURITY.md (#17848)

  ## Summary
  1. Add a Security Boundaries section to `SECURITY.md`.
  2. Point readers to the Codex Agent approvals and security documentation
  for sandboxing, approvals, and network controls.
  
  ## Validation
  1. Reviewed the `SECURITY.md` diff in a clean worktree.
  2. No tests run. Docs only change.

  evawong-oai · 2026-04-15 20:12:46 +00:00
  0bb438bca6
• Support remote compaction for Azure responses providers (#17958)

  Azure Responses providers were still falling back to local compaction
  because the compaction gate only checked
  `ModelProviderInfo::is_openai()`.
  
  Move the capability check onto `ModelProviderInfo` with
  `supports_remote_compaction()`, backed by the existing Azure Responses
  endpoint detection used in `codex-api`, and have `core::compact`
  delegate to that helper.
  
  Add regression coverage for:
  - OpenAI providers using remote compaction
  - Azure providers using remote compaction
  - non-OpenAI/non-Azure providers staying on the local path
  
  resolves #17773
  
  ---------
  
  Co-authored-by: Michael Bolin <mbolin@openai.com>

  Ivan Murashko · 2026-04-15 13:05:11 -07:00
  f2a4925f63
• chore: tmp disable (#17981)
  jif-oai · 2026-04-15 20:40:41 +01:00
  6696e0bbc3
• chore(tui) cleanup (#17920)

  ## Summary
  Cleanup extraneous plugins.

  Dylan Hurd · 2026-04-15 12:36:55 -07:00
  81d9cde9cb
• fix: propagate log db (#17953)

  It restores the TRACE logs in the DB and `/feedback`
  Fix https://github.com/openai/codex/pull/16184 
  
  Result:
  https://openai.sentry.io/issues/6972946529/?project=4510195390611458&query=019d91e9-f931-7451-8852-c5240514a419&referrer=issue-stream

  jif-oai · 2026-04-15 20:25:53 +01:00
  7e7b35b4d2
• mcp: remove codex/sandbox-state custom request support (#17957)

  ## Why
  
  #17763 moved sandbox-state delivery for MCP tool calls to request
  `_meta` via the `codex/sandbox-state-meta` experimental capability.
  Keeping the older `codex/sandbox-state` capability meant Codex still
  maintained a second transport that pushed updates with the custom
  `codex/sandbox-state/update` request at server startup and when the
  session sandbox policy changed.
  
  That duplicate MCP path is redundant with the per-tool-call metadata
  path and makes the sandbox-state contract larger than needed. The
  existing managed network proxy refresh on sandbox-policy changes is
  still needed, so this keeps that behavior separate from the removed MCP
  notification.
  
  ## What Changed
  
  - Removed the exported `MCP_SANDBOX_STATE_CAPABILITY` and
  `MCP_SANDBOX_STATE_METHOD` constants.
  - Removed detection of `codex/sandbox-state` during MCP initialization
  and stopped sending `codex/sandbox-state/update` at server startup.
  - Removed the `McpConnectionManager::notify_sandbox_state_change`
  plumbing while preserving the managed network proxy refresh when a user
  turn changes sandbox policy.
  - Slimmed `McpConnectionManager::new` so startup paths pass only the
  initial `SandboxPolicy` needed for MCP elicitation state.
  - Kept `codex/sandbox-state-meta` support intact; servers that opt in
  still receive the current `SandboxState` on tool-call request `_meta`
  ([remaining call
  path](https://github.com/openai/codex/blob/ff2d3c1e72ff08ce13743b99605d19d338edd51c/codex-rs/core/src/mcp_tool_call.rs#L487-L526)).
  - Added regression coverage for refreshing the live managed network
  proxy on a per-turn sandbox-policy change.
  
  ## Verification
  
  - `cargo test -p codex-core
  new_turn_refreshes_managed_network_proxy_for_sandbox_change`
  - `cargo test -p codex-mcp`

  Michael Bolin · 2026-04-15 12:02:40 -07:00
  66533ddc61
• app-server: track remote-control seq IDs per stream (#17902)

  ## Summary
  
  - Track outbound remote-control sequence IDs independently for each
  client stream.
  - Retain unacked outbound messages per stream using FIFO buffers.
  - Require stream-scoped acks and update tests for contiguous per-stream
  sequencing.
  
  ## Why
  
  The remote-control peer uses outbound sequence gaps to detect lost
  messages and re-initialize. A single global outbound sequence counter
  can create apparent gaps on an individual stream when another stream
  receives an interleaved message.
  
  ## Validation
  
  - `just fmt`
  - `cargo test -p codex-app-server remote_control`
  - `just fix -p codex-app-server`
  - `git diff --check`

  Ruslan Nigmatullin · 2026-04-15 11:52:53 -07:00
  83abf67d20
• Refactor auth providers to mutate request headers (#17866)

  ## Summary
  - Move auth header construction into the
  `AuthProvider::add_auth_headers` contract.
  - Inline `CoreAuthProvider` header mutation in its provider impl and
  remove the shared header-map helper.
  - Update HTTP, websocket, file upload, sideband websocket, and test auth
  callsites to use the provider method.
  - Add direct coverage for `CoreAuthProvider` auth header mutation.
  
  ## Testing
  - `just fmt`
  - `cargo test -p codex-api`
  - `cargo test -p codex-core
  client::tests::auth_request_telemetry_context_tracks_attached_auth_and_retry_phase`
  - `cargo test -p codex-core` failed on unrelated/reproducible
  `tools::handlers::multi_agents::tests::multi_agent_v2_followup_task_interrupts_busy_child_without_losing_message`
  
  ---------
  
  Co-authored-by: Celia Chen <celia@openai.com>

  pakrym-oai · 2026-04-15 11:52:51 -07:00
  f5e8eac2ae
• Add CLI update announcement (#17942)

  ## Summary
  - Keep the existing local-build test announcement as the first
  announcement entry
  - Add the CLI update reminder for versions below `0.120.0`
  - Remove expired onboarding and gpt-5.3-codex announcement entries
  <img width="1576" height="276" alt="Screenshot 2026-04-15 at 1 32 53 PM"
  src="https://github.com/user-attachments/assets/10b55d0b-09cd-4de0-ab51-4293d811b80c"
  />

  Shijie Rao · 2026-04-15 11:39:06 -07:00
  f53210d332
• [codex] Add local thread store listing (#17824)

  Builds on top of #17659 
  
  Move the filesystem + sqlite thread listing-related operations inside of
  a local ThreadStore implementation and call ThreadStore from the places
  that used to perform these filesystem/sqlite operations.
  
  This is the first of a series of PRs that will implement the rest of the
  local ThreadStore.
  
  Testing:
  - added unit tests for the thread store implementation
  - adjusted some unit tests in the realtime + personality packages whose
  callsites changed. Specifically I'm trying to hide ThreadMetadata inside
  of the local implementation and make ThreadMetadata a sqlite
  implementation detail concern rather than a public interface, preferring
  the more generate StoredThread interface instead
  - added a corner case test for the personality migration package that
  wasn't covered by the existing test suite
  - adjust the behavior of searched thread listing to run the existing
  local rollout repair/backfill pass _before_ querying SQLite results, so
  callers using ThreadStore::list_threads do not miss matches after a
  partial metadata warm-up

  Tom · 2026-04-15 11:34:27 -07:00
  cdfcd2ca92
• Fix empty tool descriptions (#17946)

  ## Summary
  - Ensure direct namespaced MCP tool groups are emitted with a non-empty
  namespace description even when namespace metadata is missing or blank.
  - Add regression coverage for missing MCP namespace descriptions.
  
  ## Cause
  Latest `main` can serialize a direct namespaced MCP tool group with an
  empty top-level `description`. The namespace description path used
  `unwrap_or_default()` when `tool_namespaces` did not include metadata
  for that namespace, so the outbound Responses API payload could contain
  a tool like `{"type":"namespace","description":""}`. The Responses API
  rejects that because namespace tool descriptions must be a non-empty
  string.
  
  ## Fix
  - Add a fallback namespace description: `Tools in the <namespace>
  namespace.`
  - Preserve provided namespace descriptions after trimming, but treat
  blank descriptions as missing.
  
  ### Issue I am seeing
  This is what I am seeing on the local build.
  <img width="1593" height="488" alt="Screenshot 2026-04-15 at 10 55 55
  AM"
  src="https://github.com/user-attachments/assets/bab668ba-bf17-4c71-be4e-b102202fce57"
  />
  
  ---------
  
  Co-authored-by: Sayan Sisodiya <sayan@openai.com>

  Shijie Rao · 2026-04-15 18:14:43 +00:00
  78ce61c78e
• fix: rename is_azure_responses_wire_base_url to is_azure_responses_provider (#17965)

  ## Why
  
  While reviewing https://github.com/openai/codex/pull/17958, the helper
  name `is_azure_responses_wire_base_url` looked misleading because the
  helper returns true for either the `azure` provider name or an Azure
  Responses `base_url`. The new name makes both inputs part of the
  contract.
  
  ## What
  
  - Rename `is_azure_responses_wire_base_url` to
  `is_azure_responses_provider`.
  - Move the `openai.azure.` marker into
  `matches_azure_responses_base_url` so all base URL marker matching is
  centralized.
  - Keep `Provider::is_azure_responses_endpoint()` behavior unchanged.
  
  ## Verification
  
  - Compared the parent and current implementations.
  `name.eq_ignore_ascii_case("azure")` still returns true before
  consulting `base_url`, `None` still returns false, base URLs are still
  lowercased before marker matching, and the same Azure marker set is
  checked.
  - Ran `cargo test -p codex-api`.

  Michael Bolin · 2026-04-15 11:07:57 -07:00
  aca781b3a7
• chore(features) codex dependencies feat (#17960)

  ## Summary
  Setting this up
  
  ## Testing
  - [x] Unit tests pass

  Dylan Hurd · 2026-04-15 10:59:59 -07:00
  652380d362
• Fix fs/readDirectory to skip broken symlinks (#17907)

  ## Summary
  - Skip directory entries whose metadata lookup fails during
  `fs/readDirectory`
  - Add an exec-server regression test covering a broken symlink beside
  valid entries
  
  ## Testing
  - `just fmt`
  - `cargo test -p codex-exec-server` (started, but dependency/network
  updates stalled before completion in this environment)

  willwang-openai · 2026-04-15 10:50:22 -07:00
  a3d475d33f
• Register agent identities behind use_agent_identity (#17386)

  ## Summary
  
  Stack PR 2 of 4 for feature-gated agent identity support.
  
  This PR adds agent identity registration behind
  `features.use_agent_identity`. It keeps the app-server protocol
  unchanged and starts registration after ChatGPT auth exists rather than
  requiring a client restart.
  
  ## Stack
  
  - PR1: https://github.com/openai/codex/pull/17385 - add
  `features.use_agent_identity`
  - PR2: https://github.com/openai/codex/pull/17386 - this PR
  - PR3: https://github.com/openai/codex/pull/17387 - register agent tasks
  when enabled
  - PR4: https://github.com/openai/codex/pull/17388 - use `AgentAssertion`
  downstream when enabled
  
  ## Validation
  
  Covered as part of the local stack validation pass:
  
  - `just fmt`
  - `cargo test -p codex-core --lib agent_identity`
  - `cargo test -p codex-core --lib agent_assertion`
  - `cargo test -p codex-core --lib websocket_agent_task`
  - `cargo test -p codex-api api_bridge`
  - `cargo build -p codex-cli --bin codex`
  
  ## Notes
  
  The full local app-server E2E path is still being debugged after PR
  creation. The current branch stack is directionally ready for review
  while that follow-up continues.

  Adrian · 2026-04-15 10:08:27 -07:00
  8e784bba2f
• Remove exec-server fs sandbox request preflight (#17883)

  ## Summary
  - Remove the exec-server-side manual filesystem request path preflight
  before invoking the sandbox helper.
  - Keep sandbox helper policy construction and platform sandbox
  enforcement as the access boundary.
  - Add a portable local+remote regression for writing through an
  explicitly configured alias root.
  - Remove the metadata symlink-escape assertion that depended on the
  deleted manual preflight; no replacement metadata-specific access probe
  is added.
  
  ## Tests
  - `cargo test -p codex-exec-server --lib`
  - `cargo test -p codex-exec-server --test file_system`
  - `git diff --check`

  pakrym-oai · 2026-04-15 09:28:30 -07:00
  1dead46c90
• feat: reset memories button (#17937)

  <img width="720" height="175" alt="Screenshot 2026-04-15 at 14 35 02"
  src="https://github.com/user-attachments/assets/041d73ff-8c16-42a9-8e92-c245805084f0"
  />

  jif-oai · 2026-04-15 15:34:25 +01:00
  da86cedbd4
• feat: sanitize rollouts before phase 1 (#17938)
  jif-oai · 2026-04-15 15:00:27 +01:00
  ec13aaac89
• nit: doc (#17941)
  jif-oai · 2026-04-15 14:51:20 +01:00
  ea13527961
• register all mcp tools with namespace (#17404)

  stacked on #17402.
  
  MCP tools returned by `tool_search` (deferred tools) get registered in
  our `ToolRegistry` with a different format than directly available
  tools. this leads to two different ways of accessing MCP tools from our
  tool catalog, only one of which works for each. fix this by registering
  all MCP tools with the namespace format, since this info is already
  available.
  
  also, direct MCP tools are registered to responsesapi without a
  namespace, while deferred MCP tools have a namespace. this means we can
  receive MCP `FunctionCall`s in both formats from namespaces. fix this by
  always registering MCP tools with namespace, regardless of deferral
  status.
  
  make code mode track `ToolName` provenance of tools so it can map the
  literal JS function name string to the correct `ToolName` for
  invocation, rather than supporting both in core.
  
  this lets us unify to a single canonical `ToolName` representation for
  each MCP tool and force everywhere to use that one, without supporting
  fallbacks.

  sayan-oai · 2026-04-15 21:02:59 +08:00
  0df7e9a820
• feat: memories menu (#17632)

  Add menu that:
  1. If memories feature is not enabled, propose to enable it
  2. Let you choose if you want to generate memories and to use memories

  jif-oai · 2026-04-15 14:02:35 +01:00
  9402347f34
• nit: stable test (#17924)
  jif-oai · 2026-04-15 12:05:50 +01:00
  544b4e39e3
• chore: do not disable memories for past rollouts on reset (#17919)
  jif-oai · 2026-04-15 12:05:39 +01:00
  5e544be3c9
• [codex] Fix current main CI blockers (#17917)

  ## Summary
  - Fix marketplace-add local path detection on Windows by using
  `Path::is_absolute()`.
  - Make marketplace-add local-source tests parse/write TOML through the
  same helpers instead of raw string matching.
  - Update `rand` 0.9.x to 0.9.3 and document the remaining audited `rand`
  0.8.5 advisory exception.
  - Refresh `MODULE.bazel.lock` after the Cargo.lock update.
  
  ## Why
  Latest `main` had two independent CI blockers: marketplace-add tests
  were not portable to Windows path/TOML escaping, and cargo-deny still
  reported `RUSTSEC-2026-0097` after the recent rustls-webpki fix.
  
  ## Validation
  - `cargo test -p codex-core marketplace_add -- --nocapture`
  - `cargo deny --all-features check`
  - `just bazel-lock-check`
  - `just fix -p codex-core`
  - `just fmt`
  - `git diff --check`

  sayan-oai · 2026-04-15 11:47:26 +01:00
  b99a62c526
• chore: exp flag (#17921)
  jif-oai · 2026-04-15 11:47:01 +01:00
  af9230d74d
• feat: cleaning of memories extension (#17844)
  jif-oai · 2026-04-15 10:38:11 +01:00
  b6244f776d
• feat: add endpoint to delete memories (#17913)
  jif-oai · 2026-04-15 10:35:06 +01:00
  7579d5ad75
• fix: cargo deny (#17915)
  jif-oai · 2026-04-15 10:14:54 +01:00
  13248008f9
• Support Unix socket allowlists in macOS sandbox (#17654)

  ## Changes
  
  Allows sandboxes to restrict overall network access while granting
  access to specific unix sockets on mac.
  
  ## Details
  
  - `codex sandbox macos`: adds a repeatable `--allow-unix-socket` option.
  - `codex-sandboxing`: threads explicit Unix socket roots into the macOS
  Seatbelt profile generation.
  - Preserves restricted network behavior when only Unix socket IPC is
  requested, and preserves full network behavior when full network is
  already enabled.
  
  ## Verification
  
  - `cargo test -p codex-cli -p codex-sandboxing`
  - `cargo build -p codex-cli --bin codex`
  - verified that `codex sandbox macos --allow-unix-socket /tmp/test.sock
  -- test-client` grants access as expected

  aaronl-openai · 2026-04-15 00:53:24 -07:00
  2e1003728c
• Send sandbox state through MCP tool metadata (#17763)

  ## Changes
  
  Allows MCPs to opt in to receiving sandbox config info through `_meta`
  on model-initiated tool calls. This lets MCPs adhere to the thread's
  sandbox if they choose to.
  
  ## Details
  
  - Adds the `codex/sandbox-state-meta` experimental MCP capability.
  - Tracks whether each MCP server advertises that capability.
  - When a server opts in, `codex-core` injects the current `SandboxState`
  into model-initiated MCP tool-call request `_meta`.
  
  ## Verification
  
  - added an integration test for the capability

  aaronl-openai · 2026-04-15 00:49:15 -07:00
  42528a905d
• fix: add websocket capability token hash support (#17871)

  ## Summary
  - Allow app-server websocket capability auth to accept a precomputed
  SHA-256 digest via `--ws-token-sha256`.
  - Keep token-file support and enforce exactly one capability token
  source.
  - Document the new auth flag.
  
  ## Testing
  - `just fmt`
  - `cargo test -p codex-app-server transport::auth::tests`
  - `cargo test -p codex-app-server
  websocket_capability_token_sha256_args_parse`
  - `cargo test -p codex-cli app_server_capability_token_flags_parse`
  - `cargo clippy -p codex-app-server --all-targets -- -D warnings`
  - `just fix -p codex-cli`
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  viyatb-oai · 2026-04-14 22:06:39 -07:00
  e4a3612f11
• fix: cleanup the contract of the general-purpose exec() function (#17870)

  `exec()` had a number of arguments that were unused, making the function
  signature misleading. This PR aims to clean things up to clarify the
  role of this function and to clarify which fields of `ExecParams` are
  unused and why.

  Michael Bolin · 2026-04-15 04:40:12 +00:00
  c6defb1f0f
• sandbox: remove dead seatbelt helper and update tests (#17859)

  ## Why
  
  `spawn_command_under_seatbelt()` in `codex-rs/core/src/seatbelt.rs` had
  fallen out of production use and was only referenced by test-only
  wrappers. That left us with sandbox tests that could stay green even if
  the actual seatbelt exec path regressed, because production shell
  execution now flows through `SandboxManager::transform()` and
  `ExecRequest::from_sandbox_exec_request()` instead of that helper.
  
  Removing the dead helper also exposed one downstream `codex-exec`
  integration test that still imported it, which broke `just clippy`.
  
  ## What Changed
  
  - Removed `codex-rs/core/src/seatbelt.rs` and stopped exporting
  `codex_core::seatbelt`.
  - Removed the redundant `codex-rs/core/tests/suite/seatbelt.rs` coverage
  that only exercised the dead helper.
  - Kept the `openpty` regression check, but moved it into
  `codex-rs/core/tests/suite/exec.rs` so it now runs through
  `process_exec_tool_call()`.
  - Fixed the seatbelt denial test in `codex-rs/core/tests/suite/exec.rs`
  to use `/usr/bin/touch`, so it actually exercises the sandbox instead of
  a nonexistent path.
  - Updated `codex-rs/exec/tests/suite/sandbox.rs` on macOS to build the
  sandboxed command through `build_exec_request()` and spawn the
  transformed command, instead of importing the removed helper.
  - Left the lower-level seatbelt policy coverage in
  `codex-rs/sandboxing/src/seatbelt_tests.rs`, where the policy generator
  is still covered directly.
  
  ## Verification
  
  - `cargo test -p codex-core suite::exec::`
  - `cargo test -p codex-exec`
  - `cargo clippy -p codex-exec --tests -- -D warnings`

  Michael Bolin · 2026-04-14 20:48:01 -07:00
  d34bc66466
• Reuse remote exec-server in core tests (#17837)

  ## Summary
  - reuse a shared remote exec-server for remote-aware codex-core
  integration tests within a test binary process
  - keep per-test remote cwd creation and cleanup so tests retain
  workspace isolation
  - leave codex_self_exe, codex_linux_sandbox_exe, cwd_path(), and
  workspace_path() behavior unchanged
  
  ## Validation
  - rustfmt codex-rs/core/tests/common/test_codex.rs
  - git diff --check
  - CI is running on the updated branch

  starr-openai · 2026-04-14 20:42:03 -07:00
  e063596c67
• Fix clippy warnings in external agent config migration (#17884)

  Fix clippy warnings in external agent config migration
  
  ```
  error: this expression creates a reference which is immediately dereferenced by the compiler
     --> core/src/external_agent_config.rs:188:55
      |
  188 |             let migrated = build_config_from_external(&settings)?;
      |                                                       ^^^^^^^^^ help: change this to: `settings`
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
      = note: requested on the command line with `-D clippy::needless-borrow`
  
  error: useless conversion to the same type: `codex_utils_absolute_path::AbsolutePathBuf`
     --> core/src/external_agent_config.rs:355:27
      |
  355 |                       match AbsolutePathBuf::try_from(
      |  ___________________________^
  356 | |                         add_marketplace_outcome
  357 | |                             .installed_root
  358 | |                             .join(INSTALLED_MARKETPLACE_MANIFEST_RELATIVE_PATH),
  359 | |                     ) {
      | |_____________________^
      |
      = help: consider removing `AbsolutePathBuf::try_from()`
      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
      = note: `-D clippy::useless-conversion` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
  
  error: aborting due to 2 previous errors
  ```

  canvrno-oai · 2026-04-14 20:36:48 -07:00
  679f63ba06
• Wrap delegated input text (#17868)

  ## Summary
  - wrap routed delegation text in a small XML envelope before submitting
  it as a user turn
  - escape XML text content so the envelope stays well formed
  - update focused coverage for the wrapper and the affected routed-turn
  expectations

  guinness-oai · 2026-04-14 19:58:58 -07:00
  6f5ddd408b
• Disable hooks in guardian review sessions (#17872)

  ## What
  Disable `Feature::CodexHooks` when building guardian review session
  config
  
  ## Why
  Guardian review sessions were respecting the Stop hook and could ingest
  synthetic `<hook_prompt>` user turns Guardian should ignore hooks, while
  the main session and regular subagents continue to respect them
  
  In other words Guardian was getting ralph-looped
  
  Co-authored-by: Codex <noreply@openai.com>

  Abhinav · 2026-04-14 19:47:50 -07:00
  130b047beb
• support plugins in external agent config migration (#17855)
  alexsong-oai · 2026-04-14 19:39:10 -07:00
  ca650561d6
• Fix for CI Tests failing from stack overflow (#17846)

  ### **Issue**
  guardian_parallel_reviews_fork_from_last_committed_trunk_history was
  failing on Windows/Bazel with a stack overflow:
  
  `thread
  'guardian::tests::guardian_parallel_reviews_fork_from_last_committed_trunk_history'
  has overflowed its stack`
  
  - This problem was a stack-headroom problem
  
  ### **Solution**
  
  Reduced stack pressure in the guardian async path by boxing thin wrapper
  futures, and run the affected test on a dedicated 2 MiB thread stack.
  
  Concretely:
  - added Box::pin(...) around thin async wrapper hops in the guardian
  review/delegate path
  - changed
  guardian_parallel_reviews_fork_from_last_committed_trunk_history to run
  inside an explicitly sized thread stack so it has enough headroom in
  low-stack environments

  Won Park · 2026-04-14 18:04:35 -07:00
  2bfa627613
• [codex] Support local marketplace sources (#17756)

  ## Summary
  
  - Port marketplace source support into the shared core marketplace-add
  flow
  - Support local marketplace directory sources
  - Support direct `marketplace.json` URL sources
  - Persist the new source types in config/schema and cover them in CLI
  and app-server tests
  
  ## Validation
  
  - `cargo test -p codex-core marketplace_add`
  - `cargo test -p codex-cli marketplace_add`
  - `cargo test -p codex-app-server marketplace_add`
  - `just write-config-schema`
  - `just fmt`
  - `just fix -p codex-core`
  - `just fix -p codex-cli`
  
  ## Context
  
  Current `main` moved marketplace-add behavior into shared core code and
  still assumed only git-backed sources. This change keeps that structure
  but restores support for local directories and direct manifest URLs in
  the shared path.

  xli-oai · 2026-04-14 15:58:14 -07:00
  3cc689fb23
• Make skill loading filesystem-aware (#17720)

  Migrates skill loading to support reading repo skills from the remote
  environment.

  pakrym-oai · 2026-04-14 15:40:40 -07:00
  96254a763a
• Add Bazel verify-release-build job (#17705)

  ## Why
  
  `main` recently needed
  [#17691](https://github.com/openai/codex/pull/17691) because code behind
  `cfg(not(debug_assertions))` was not being compiled by the Bazel PR
  workflow. Our existing CI only built the fast/debug configuration, so
  PRs could stay green while release-only Rust code still failed to
  compile. This PR adds a release-style compile check that is cheap enough
  to run on every PR.
  
  ## What Changed
  
  - Added a `verify-release-build` job to `.github/workflows/bazel.yml`.
  - Represented each supported OS once in that job's matrix: x64 Linux,
  arm64 macOS, and x64 Windows.
  - Kept the build close to fastbuild cost by using
  `--compilation_mode=fastbuild` while forcing Rust to compile with
  `-Cdebug-assertions=no`, which makes `cfg(not(debug_assertions))` true
  without also turning on release optimizations or debug-info generation.
  - Added comments in `.github/workflows/bazel.yml` and
  `scripts/list-bazel-release-targets.sh` to make the job's intent and
  target scope explicit.
  - Restored the Bazel repository cache save behavior to run after every
  non-cancelled job, matching
  [#16926](https://github.com/openai/codex/pull/16926), and removed the
  now-unused `repository-cache-hit` output from `prepare-bazel-ci`.
  - Reused the shared `prepare-bazel-ci` action from the parent PR so the
  new job does not duplicate Bazel setup boilerplate.
  
  ## Verification
  
  - Used `bazel aquery` on `//codex-rs/tui:codex-tui` to confirm the Rust
  compile still uses `opt-level=0` and `debuginfo=0` while passing
  `-Cdebug-assertions=no`.
  - Parsed `.github/workflows/bazel.yml` as YAML locally.
  - Ran `bash -n scripts/list-bazel-release-targets.sh`.

  Michael Bolin · 2026-04-14 15:36:51 -07:00
  5ecaf09ab0
• Adjust default tool search result caps (#17684)

  ## Summary
  
  - Allows selected MCP results to return a larger default result set.
  - Keeps the existing default cap for other MCP results.
  - Applies the cap consistently when higher explicit limits are
  requested.
  
  ## Testing
  
  - `cargo test -p codex-core tool_search`
  - Ran a local CLI smoke test with two stdio MCP servers exposing 100
  tools each; the selected-server query returned 20 tools and the
  regular-server query returned 8.

  malone hedges · 2026-04-14 14:57:19 -07:00
  78835d7e63
• Add realtime wire trace logs (#17838)

  - Add trace-only wire logging for realtime websocket request/event text
  payloads and the WebRTC call SDP request.
  - Gate raw realtime logs behind
  `RUST_LOG=codex_api::realtime_websocket::wire=trace` so normal logs stay
  quiet.
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  Ahmed Ibrahim · 2026-04-14 14:39:28 -07:00
  8b7d0e9201
• fix: apply patch bin refresh (#17808)

  Make sure the link to apply patch binary (i.e. codex) does not die in
  case of an update
  
  Fix this:
  https://openai.slack.com/archives/C08MGJXUCUQ/p1776183247771849
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  jif-oai · 2026-04-14 22:27:47 +01:00
  42166ba260