5348 Commits

This Branch

This Branch

All Branches

• Fix remote skill popup loading (#17702)

  ## Summary
  
  Fix the TUI `$` skill popup so personal skills appear reliably when
  Codex is connected to a remote app-server.
  
  ## What changed
  
  - load skills on TUI startup with an explicit forced refresh
  - refresh skills using the actual current cwd instead of an empty `cwds`
  list
  - resync an already-open `$` popup when skill mentions are updated
  - add a regression test for refreshing an open mention popup
  
  ## Root cause
  
  The TUI was sometimes sending `list_skills` with `cwds: []` after
  `SessionConfigured`.
  
  For the launchd app-server flow, the server resolved that empty cwd list
  to its own process cwd, which was `/`. The response therefore came back
  tagged with `cwd: "/"`, and the TUI later filtered skills by exact cwd
  match against the actual project cwd such as `/Users/starr/code/dream`.
  That dropped all personal skills from the mention list, so `$` only
  showed plugins/apps.
  
  ## Verification
  
  Built successfully with remote cache disabled:
  
  ```bash
  cd /Users/starr/code/codex-worktrees/starr-skill-popup-20260413130509
  bazel --output_base=/tmp/codex-bazel-verify-starr-skill-popup build //codex-rs/cli:codex --noremote_accept_cached --noremote_upload_local_results --disk_cache=
  ```
  
  Also verified interactively in a PTY against the live app-server at
  `ws://127.0.0.1:4511`:
  - launched the built TUI
  - typed `$`
  - confirmed personal skills appeared in the popup, including entries
  such as `Applied Devbox`, `CI Debug`, `Channel Summarization`, `Codex PR
  Review`, and `Daily Digest`
  
  ## Files changed
  
  - `codex-rs/tui/src/app.rs`
  - `codex-rs/tui/src/chatwidget.rs`
  - `codex-rs/tui/src/bottom_pane/chat_composer.rs`
  
  Co-authored-by: Codex <noreply@openai.com>

  starr-openai · 2026-04-14 12:49:49 -07:00
  706f830dc6
• Route apply_patch through the environment filesystem (#17674)

  ## Summary
  - route apply_patch runtime execution through the selected Environment
  filesystem instead of the local self-exec path
  - keep the standalone apply_patch command surface intact while restoring
  its launcher/test/docs contract
  - add focused apply_patch filesystem sandbox regression coverage
  
  ## Validation
  - remote devbox Bazel run in progress
  - passed: //codex-rs/apply-patch:apply-patch-unit-tests
  --test_filter=test_read_file_utf8_with_context_reports_invalid_utf8
  - in progress / follow-up: focused core and exec Bazel test slices on
  dev
  
  ## Follow-up under review
  - remote pre-verification and approval/retry behavior still need
  explicit scrutiny for delete/update flows
  - runtime sandbox-denial classification may need a tighter assertion
  path than rendered stderr matching
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  starr-openai · 2026-04-14 12:49:02 -07:00
  c24124b37d
• Refactor Bazel CI job setup (#17704)

  ## Why
  
  This stack adds a new Bazel CI lane that verifies Rust code behind
  `cfg(not(debug_assertions))`, but adding that job directly to
  `.github/workflows/bazel.yml` would duplicate the same setup in multiple
  places. Extracting the shared setup first keeps the follow-up change
  easier to review and reduces the chance that future Bazel workflow edits
  drift apart.
  
  ## What Changed
  
  - Added `.github/actions/prepare-bazel-ci/action.yml` as a composite
  action for the Bazel job bootstrap shared by multiple workflow jobs.
  - Moved the existing Bazel setup, repository-cache restore, and
  execution-log setup behind that action.
  - Updated the `test` and `clippy` jobs in `.github/workflows/bazel.yml`
  to call `prepare-bazel-ci`.
  - Exposed `repository-cache-hit` and `repository-cache-path` outputs so
  callers can keep the existing cache-save behavior without duplicating
  the restore step.
  
  ## Verification
  
  - Parsed `.github/workflows/bazel.yml` as YAML locally after rebasing
  the stack.
  - CI will exercise the refactored jobs end to end.
  
  ---
  [//]: # (BEGIN SAPLING FOOTER)
  Stack created with [Sapling](https://sapling-scm.com). Best reviewed
  with [ReviewStack](https://reviewstack.dev/openai/codex/pull/17704).
  * #17705
  * __->__ #17704

  Michael Bolin · 2026-04-14 12:37:36 -07:00
  440597c7e7
• app-server: prepare to run initialized rpcs concurrently (#17372)

  ## Summary
  
  - Refactors `MessageProcessor` and per-connection session state so
  initialized service RPC handling can be moved into spawned tasks in a
  follow-up PR.
  - Shares the processor and initialized session data with
  `Arc`/`OnceLock` instead of mutable borrowed connection state.
  - Keeps initialized request handling synchronous in this PR; it does
  **not** call `tokio::spawn` for service RPCs yet.
  
  ## Testing
  
  - `just fmt`
  - `cargo test -p codex-app-server` *(fails on existing hardening gaps
  covered by #17375, #17376, and #17377; the pipelined config regression
  passed before the unrelated failures)*
  - `just fix -p codex-app-server`

  Ruslan Nigmatullin · 2026-04-14 11:24:34 -07:00
  23d4098c0f
• Keep image_detail_original as a removed feature flag (#17803)
  Curtis 'Fjord' Hawthorne · 2026-04-14 18:06:50 +00:00
  769b1c3d7e
• Redirect debug client output to a file (#17234)

  In the app-server debug client, allow redirecting output to a file in
  addition to just stdout. Shell redirecting works OK but is a bit weird
  with the interactive mode of the debug client since a bunch of newlines
  get dumped into the shell. With async messages from MCPs starting it's
  also tricky to actually type in a prompt.

  Rasmus Rygaard · 2026-04-14 09:53:17 -07:00
  d013576f8b
• fix: Revert danger-full-access denylist-only mode (#17732)

  ## Summary
  
  - Reverts openai/codex#16946 and removes the danger-full-access
  denylist-only network mode.
  - Removes the corresponding config requirements, app-server
  protocol/schema, config API, TUI debug output, and network proxy
  behavior.
  - Drops stale tests that depended on the reverted mode while preserving
  newer managed allowlist-only coverage.
  
  ## Verification
  
  - `just write-app-server-schema`
  - `just fmt`
  - `cargo test -p codex-config network_requirements`
  - `cargo test -p codex-core network_proxy_spec`
  - `cargo test -p codex-core
  managed_network_proxy_decider_survives_full_access_start`
  - `cargo test -p codex-app-server map_requirements_toml_to_api`
  - `cargo test -p codex-tui debug_config_output`
  - `cargo test -p codex-app-server-protocol`
  - `just fix -p codex-config -p codex-core -p codex-app-server-protocol
  -p codex-app-server -p codex-tui`
  - `git diff --cached --check`
  
  Not run: full workspace `cargo test` (repo instructions ask for
  confirmation before that broader run).

  viyatb-oai · 2026-04-14 09:50:14 -07:00
  81c0bcc921
• feat: codex sampler (#17784)

  Add a pure sampler using the Codex auth and model config. To be used by
  other binary such as tape recorder

  jif-oai · 2026-04-14 17:00:18 +01:00
  b3ae531b3a
• Moving updated-at timestamps to unique millisecond times (#17489)

  To allow the ability to have guaranteed-unique cursors, we make two
  important updates:
  * Add new updated_at_ms and created_at_ms columns that are in
  millisecond precision
  * Guarantee uniqueness -- if multiple items are inserted at the same
  millisecond, bump the new one by one millisecond until it becomes unique
  
  This lets us use single-number cursors for forwards and backwards paging
  through resultsets and guarantee that the cursor is a fixed point to do
  (timestamp > cursor) and get new items only.
  
  This updated implementation is backwards-compatible since multiple
  appservers can be running and won't handle the previous method well.

  David de Regt · 2026-04-14 11:55:34 -04:00
  4f2fc3e3fa
• [codex-analytics] add session source to client metadata (#17374)

  ## Summary
  
  Adds `thread_source` field to the existing Codex turn metadata sent to
  Responses API
  - Sends `thread_source: "user"` for user-initiated sessions: CLI, VS
  Code, and Exec
  - Sends `thread_source: "subagent"` for subagent sessions
  - Omits `thread_source` for MCP, custom, and unknown session sources
  - Uses the existing turn metadata transport:
    - HTTP requests send through the `x-codex-turn-metadata` header
  - WebSocket `response.create` requests send through
  `client_metadata["x-codex-turn-metadata"]`
  
  ## Testing
  - `cargo test -p codex-protocol
  session_source_thread_source_name_classifies_user_and_subagent_sources`
  - `cargo test -p codex-core turn_metadata_state`
  - `cargo test -p codex-core --test responses_headers
  responses_stream_includes_turn_metadata_header_for_git_workspace_e2e --
  --nocapture`

  marksteinbrick-oai · 2026-04-14 08:55:12 -07:00
  61fe23159e
• Always enable original image detail on supported models (#17665)

  ## Summary
  
  This PR removes `image_detail_original` as a runtime experiment and
  makes original image detail available whenever the selected model
  supports it.
  
  Concretely, this change:
  - drops the `image_detail_original` feature flag from the feature
  registry and generated config schema
  - makes tool-emitted image detail depend only on
  `ModelInfo.supports_image_detail_original`
  - updates `view_image` and `code_mode`/`js_repl` image emission to use
  that capability check directly
  - removes now-redundant experiment-specific tests and instruction
  coverage
  - keeps backward compatibility for existing configs by silently ignoring
  a stale `features.image_detail_original` entry
  
  The net effect is that `detail: "original"` is always available on
  supported models, without requiring an experiment toggle.

  Curtis 'Fjord' Hawthorne · 2026-04-14 08:15:56 -07:00
  f030ab62eb
• feat: add context percent to status line (#17637)

  Co-authored-by: Codex <noreply@openai.com>

  jif-oai · 2026-04-14 14:27:24 +01:00
  e6947f85f6
• nit: feature flag (#17777)
  jif-oai · 2026-04-14 13:44:01 +01:00
  34a9ca083e
• Add realtime output modality and transcript events (#17701)

  - Add outputModality to thread/realtime/start and wire text/audio output
  selection through app-server, core, API, and TUI.\n- Rename the realtime
  transcript delta notification and add a separate transcript done
  notification that forwards final text from item done without correlating
  it with deltas.

  Ahmed Ibrahim · 2026-04-14 00:13:13 -07:00
  2f6fc7c137
• Log realtime call location (#17761)

  Add a trace-level log for the realtime call Location header when
  decoding the call id.

  Ahmed Ibrahim · 2026-04-13 23:33:51 -07:00
  a6b03a22cc
• [codex-analytics] feature plumbing and emittance (#16640)

  ---
  [//]: # (BEGIN SAPLING FOOTER)
  Stack created with [Sapling](https://sapling-scm.com). Best reviewed
  with [ReviewStack](https://reviewstack.dev/openai/codex/pull/16640).
  * #16870
  * #16706
  * #16641
  * __->__ #16640

  rhan-oai · 2026-04-13 23:11:49 -07:00
  b704df85b8
• [codex] drain mailbox only at request boundaries (#17749)

  This changes multi-agent v2 mailbox handling so incoming inter-agent
  messages no longer preempt an in-flight sampling stream at reasoning or
  commentary output-item boundaries.

  Thibault Sottiaux · 2026-04-13 22:09:51 -07:00
  05c5829923
• [codex] Initialize ICU data for code mode V8 (#17709)

  Link ICU data into code mode, otherwise locale-dependent methods cause a
  panic and a crash.

  pakrym-oai · 2026-04-13 22:01:58 -07:00
  ad37389c18
• Refactor plugin loading to async (#17747)

  Simplifies skills migration.

  pakrym-oai · 2026-04-13 21:52:56 -07:00
  3b24a9a532
• [codex] Refactor marketplace add into shared core flow (#17717)

  ## Summary
  
  Move `codex marketplace add` onto a shared core implementation so the
  CLI and app-server path can use one source of truth.
  
  This change:
  - adds shared marketplace-add orchestration in `codex-core`
  - switches the CLI command to call that shared implementation
  - removes duplicated CLI-only marketplace add helpers
  - preserves focused parser and add-path coverage while moving the shared
  behavior into core tests
  
  ## Why
  
  The new `marketplace/add` RPC should reuse the same underlying
  marketplace-add flow as the CLI. This refactor lands that consolidation
  first so the follow-up app-server PR can be mostly protocol and handler
  wiring.
  
  ## Validation
  
  - `cargo test -p codex-core marketplace_add`
  - `cargo test -p codex-cli marketplace_cmd`
  - `just fix -p codex-core`
  - `just fix -p codex-cli`
  - `just fmt`

  xli-oai · 2026-04-13 20:37:11 -07:00
  ff584c5a4b
• fix: pin inputs (#17471)

  ## Summary
  - Pin Rust git patch dependencies to immutable revisions and make
  cargo-deny reject unknown git and registry sources unless explicitly
  allowlisted.
  - Add checked-in SHA-256 coverage for the current rusty_v8 release
  assets, wire those hashes into Bazel, and verify CI override downloads
  before use.
  - Add rusty_v8 MODULE.bazel update/check tooling plus a Bazel CI guard
  so future V8 bumps cannot drift from the checked-in checksum manifest.
  - Pin release/lint cargo installs and all external GitHub Actions refs
  to immutable inputs.
  
  ## Future V8 bump flow
  Run these after updating the resolved `v8` crate version and checksum
  manifest:
  
  ```bash
  python3 .github/scripts/rusty_v8_bazel.py update-module-bazel
  python3 .github/scripts/rusty_v8_bazel.py check-module-bazel
  ```
  
  The update command rewrites the matching `rusty_v8_<crate_version>`
  `http_file` SHA-256 values in `MODULE.bazel` from
  `third_party/v8/rusty_v8_<crate_version>.sha256`. The check command is
  also wired into Bazel CI to block drift.
  
  ## Notes
  - This intentionally excludes RustSec dependency upgrades and
  bubblewrap-related changes per request.
  - The branch was rebased onto the latest origin/main before opening the
  PR.
  
  ## Validation
  - cargo fetch --locked
  - cargo deny check advisories
  - cargo deny check
  - cargo deny check sources
  - python3 .github/scripts/rusty_v8_bazel.py check-module-bazel
  - python3 .github/scripts/rusty_v8_bazel.py update-module-bazel
  - python3 -m unittest discover -s .github/scripts -p
  'test_rusty_v8_bazel.py'
  - python3 -m py_compile .github/scripts/rusty_v8_bazel.py
  .github/scripts/rusty_v8_module_bazel.py
  .github/scripts/test_rusty_v8_bazel.py
  - repo-wide GitHub Actions `uses:` audit: all external action refs are
  pinned to 40-character SHAs
  - yq eval on touched workflows and local actions
  - git diff --check
  - just bazel-lock-check
  
  ## Hash verification
  - Confirmed `MODULE.bazel` hashes match
  `third_party/v8/rusty_v8_146_4_0.sha256`.
  - Confirmed GitHub release asset digests for denoland/rusty_v8
  `v146.4.0` and openai/codex `rusty-v8-v146.4.0` match the checked-in
  hashes.
  - Streamed and SHA-256 hashed all 10 `MODULE.bazel` rusty_v8 asset URLs
  locally; every downloaded byte stream matched both `MODULE.bazel` and
  the checked-in manifest.
  
  ## Pin verification
  - Confirmed signing-action pins match the peeled commits for their tag
  comments: `sigstore/cosign-installer@v3.7.0`, `azure/login@v2`, and
  `azure/trusted-signing-action@v0`.
  - Pinned the remaining tag-based action refs in Bazel CI/setup:
  `actions/setup-node@v6`, `facebook/install-dotslash@v2`,
  `bazelbuild/setup-bazelisk@v3`, and `actions/cache/restore@v5`.
  - Normalized all `bazelbuild/setup-bazelisk@v3` refs to the peeled
  commit behind the annotated tag.
  - Audited Cargo git dependencies: every manifest git dependency uses
  `rev` only, every `Cargo.lock` git source has `?rev=<sha>#<same-sha>`,
  and `cargo deny check sources` passes with `required-git-spec = "rev"`.
  - Shallow-fetched each distinct git dependency repo at its pinned SHA
  and verified Git reports each object as a commit.

  viyatb-oai · 2026-04-14 01:45:41 +00:00
  d9a385ac8c
• [codex] Remove unused Rust helpers (#17146)

  ## Summary
  
  Removes high-confidence unused Rust helper functions and exports across
  `codex-tui`, `codex-shell-command`, and utility crates.
  
  The cleanup includes dead TUI helper methods, unused
  path/string/elapsed/fuzzy-match utilities, an unused Windows PowerShell
  lookup helper, and the unused terminal palette version counter. This
  keeps the remaining public surface smaller without changing behavior.
  
  ## Validation
  
  - `just fmt`
  - `cargo test -p codex-tui -p codex-shell-command -p codex-utils-elapsed
  -p codex-utils-fuzzy-match -p codex-utils-string -p codex-utils-path`
  - `just fix -p codex-tui -p codex-shell-command -p codex-utils-elapsed
  -p codex-utils-fuzzy-match -p codex-utils-string -p codex-utils-path`
  - `git diff --check`

  pakrym-oai · 2026-04-13 18:27:00 -07:00
  0c8f3173e4
• [codex] Add symlink flag to fs metadata (#17719)

  Add `is_symlink` to FsMetadata struct.

  pakrym-oai · 2026-04-13 17:46:56 -07:00
  f3cbe3d385
• guardian timeout fix pr 3 - ux touch for timeouts (#17557)

  This PR teaches the TUI to render guardian review timeouts as explicit
  terminal history entries instead of dropping them from the live
  timeline.
  It adds timeout-specific history cells for command, patch, MCP tool, and
  network approval reviews.
  It also adds snapshot tests covering both the direct guardian event path
  and the app-server notification path.

  Won Park · 2026-04-13 17:43:19 -07:00
  495ed22dfb
• Stabilize exec-server filesystem tests in CI (#17671)

  ## Summary\n- add an exec-server package-local test helper binary that
  can run exec-server and fs-helper flows\n- route exec-server filesystem
  tests through that helper instead of cross-crate codex helper
  binaries\n- stop relying on Bazel-only extra binary wiring for these
  tests\n\n## Testing\n- not run (per repo guidance for codex changes)
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  starr-openai · 2026-04-13 16:53:42 -07:00
  280a4a6d42
• Add turn item injection API (#17703)

  ## Summary
  - Add `turn/inject_items` app-server v2 request support for appending
  raw Responses API items to a loaded thread history without starting a
  turn.
  - Generate JSON schema and TypeScript protocol artifacts for the new
  params and empty response.
  - Document the new endpoint and include a request/response example.
  - Preserve compatibility with the typo alias `turn/injet_items` while
  returning the canonical method name.
  
  ## Testing
  - Not run (not requested)

  pakrym-oai · 2026-04-13 16:11:05 -07:00
  d4be06adea
• Add supports_parallel_tool_calls flag to included mcps (#17667)

  ## Why
  
  For more advanced MCP usage, we want the model to be able to emit
  parallel MCP tool calls and have Codex execute eligible ones
  concurrently, instead of forcing all MCP calls through the serial block.
  
  The main design choice was where to thread the config. I made this
  server-level because parallel safety depends on the MCP server
  implementation. Codex reads the flag from `mcp_servers`, threads the
  opted-in server names into `ToolRouter`, and checks the parsed
  `ToolPayload::Mcp { server, .. }` at execution time. That avoids relying
  on model-visible tool names, which can be incomplete in
  deferred/search-tool paths or ambiguous for similarly named
  servers/tools.
  
  ## What was added
  
  Added `supports_parallel_tool_calls` for MCP servers.
  
  Before:
  
  ```toml
  [mcp_servers.docs]
  command = "docs-server"
  ```
  
  After:
  
  ```toml
  [mcp_servers.docs]
  command = "docs-server"
  supports_parallel_tool_calls = true
  ```
  
  MCP calls remain serial by default. Only tools from opted-in servers are
  eligible to run in parallel. Docs also now warn to enable this only when
  the server’s tools are safe to run concurrently, especially around
  shared state or read/write races.
  
  ## Testing
  
  Tested with a local stdio MCP server exposing real delay tools. The
  model/Responses side was mocked only to deterministically emit two MCP
  calls in the same turn.
  
  Each test called `query_with_delay` and `query_with_delay_2` with `{
  "seconds": 25 }`.
  
  | Build/config | Observed | Wall time |
  | --- | --- | --- |
  | main with flag enabled | serial | `58.79s` |
  | PR with flag enabled | parallel | `31.73s` |
  | PR without flag | serial | `56.70s` |
  
  PR with flag enabled showed both tools start before either completed;
  main and PR-without-flag completed the first delay before starting the
  second.
  
  Also added an integration test.
  
  Additional checks:
  
  - `cargo test -p codex-tools` passed
  - `cargo test -p codex-core
  mcp_parallel_support_uses_exact_payload_server` passed
  - `git diff --check` passed

  josiah-openai · 2026-04-13 15:16:34 -07:00
  937dd3812d
• change realtime tool description (#17699)

  # External (non-OpenAI) Pull Request Requirements
  
  Before opening this Pull Request, please read the dedicated
  "Contributing" markdown file or your PR may be closed:
  https://github.com/openai/codex/blob/main/docs/contributing.md
  
  If your PR conforms to our contribution guidelines, replace this text
  with a detailed and high quality description of your changes.
  
  Include a link to a bug report or enhancement request.

  Ahmed Ibrahim · 2026-04-13 14:31:31 -07:00
  0e31dc0d4a
• Cap realtime mirrored user turns (#17685)

  Cap mirrored user text sent to realtime with the existing 300-token turn
  budget while preserving the full model turn.
  
  Adds integration coverage for capped realtime mirror payloads.
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>

  Ahmed Ibrahim · 2026-04-13 14:31:18 -07:00
  ec0133f5f8
• Remove unnecessary tests (#17395)

  # External (non-OpenAI) Pull Request Requirements
  
  Before opening this Pull Request, please read the dedicated
  "Contributing" markdown file or your PR may be closed:
  https://github.com/openai/codex/blob/main/docs/contributing.md
  
  If your PR conforms to our contribution guidelines, replace this text
  with a detailed and high quality description of your changes.
  
  Include a link to a bug report or enhancement request.

  Kevin Liu · 2026-04-13 21:02:12 +00:00
  ecdd733a48
• Update phase 2 memory model to gpt-5.4 (#17384)

  ### Motivation
  - Switch the default model used for memory Phase 2 (consolidation) to
  the newer `gpt-5.4` model.
  
  ### Description
  - Change the Phase 2 model constant from `"gpt-5.3-codex"` to
  `"gpt-5.4"` in `codex-rs/core/src/memories/mod.rs`.
  
  ### Testing
  - Ran `just fmt`, which completed successfully.
  - Attempted `cargo test -p codex-core`, but the build failed in this
  environment because the `codex-linux-sandbox` crate requires the system
  `libcap` pkg-config entry and the required system packages could not be
  installed, so the test run was blocked.
  
  ------
  [Codex
  Task](https://chatgpt.com/codex/cloud/tasks/task_i_69d977693b48832a967e78d73c66dc8e)

  Kevin Liu · 2026-04-13 20:59:03 +00:00
  ec72b1ced9
• Fix tui compilation (#17691)

  The recent release broke, codex suggested this as the fix
  
  Source failure:
  https://github.com/openai/codex/actions/runs/24362949066/job/71147202092
  
  Probably from
  https://github.com/openai/codex/commit/ac82443d073f7f9a2248bad51bae2fa424ef4946
  
  For why it got in:
  ```
  The relevant setup:
  
  .github/workflows/rust-ci.yml (line 1) runs on PRs, but for codex-rs it only does:
  
  cargo fmt --check
  cargo shear
  argument-comment lint via Bazel
  no cargo check, no cargo clippy over the workspace, no cargo test over codex-tui
  .github/workflows/rust-ci-full.yml (line 1) runs on pushes to main and branches matching **full-ci**. That one does compile TUI because:
  
  codex-rs/Cargo.toml includes "tui" as a workspace member
  lint_build runs cargo clippy --target ... --tests --profile ...
  the matrix includes both dev and release profiles
  tests runs cargo nextest run ..., but only dev-profile tests
  Release CI also compiles it indirectly. .github/workflows/rust-release.yml (line 235) builds --bin codex, and cli/Cargo.toml (line 46) depends on codex-tui.
  ```
  
  Codex tested locally with `cargo check -p codex-tui --release` and was
  able to repro, and verified that this fixed it

  David Z Hao · 2026-04-13 21:43:33 +01:00
  7c43f8bb5e
• only specify remote ports when the rule needs them (#17669)

  Windows gives an error when you combine `protocol = ANY` with
  `SetRemotePorts`
  This fixes that

  iceweasel-oai · 2026-04-13 12:28:26 -07:00
  7b5e1ad3dc
• app-server: Only unload threads which were unused for some time (#17398)

  Currently app-server may unload actively running threads once the last
  connection disconnects, which is not expected.
  Instead track when was the last active turn & when there were any
  subscribers the last time, also add 30 minute idleness/no subscribers
  timer to reduce the churn.

  Ruslan Nigmatullin · 2026-04-13 12:25:26 -07:00
  a5507b59c4
• feat: Avoid reloading curated marketplaces for tool-suggest discovera… (#17638)

  - stop `list_tool_suggest_discoverable_plugins()` from reloading the
  curated marketplace for each discoverable plugin
  - reuse a direct plugin-detail loader against the already-resolved
  marketplace entry
  
  
  The trigger was to stop those logs spamming:
  ```
  d=019d81cf-6f69-7230-98aa-74294ff2dc5a}:submission_dispatch{otel.name="op.dispatch.user_input" submission.id="019d86c8-0a8e-7013-b442-109aabbf75c9" codex.op="user_input"}:turn{otel.name="session_task.turn" thread.id=019d81cf-6f69-7230-98aa-74294ff2dc5a turn.id=019d86c8-0a8e-7013-b442-109aabbf75c9 model=gpt-5.4}: ignoring interface.defaultPrompt: prompt must be at most 128 characters path=/Users/jif/.codex/.tmp/plugins/plugins/life-science-research/.codex-plugin/plugin.json
  2026-04-13T12:27:30.402Z WARN  [019d81cf-6f69-7230-98aa-74294ff2dc5a] codex_core::plugins::manifest - session_loop{thread_id=019d81cf-6f69-7230-98aa-74294ff2dc5a}:submission_dispatch{otel.name="op.dispatch.user_input" submission.id="019d86c8-0a8e-7013-b442-109aabbf75c9" codex.op="user_input"}:turn{otel.name="session_task.turn" thread.id=019d81cf-6f69-7230-98aa-74294ff2dc5a turn.id=019d86c8-0a8e-7013-b442-109aabbf75c9 model=gpt-5.4}: ignoring interface.defaultPrompt: prompt must be at most 128 characters path=/Users/jif/.codex/.tmp/plugins/plugins/build-ios-apps/.codex-plugin/plugin.json
  2026-04-13T12:27:30.402Z WARN  [019d81cf-6f69-7230-98aa-74294ff2dc5a] codex_core::plugins::manifest - session_loop{thread_id=019d81cf-6f69-7230-98aa-74294ff2dc5a}:submission_dispatch{otel.name="op.dispatch.user_input" submission.id="019d86c8-0a8e-7013-b442-109aabbf75c9" codex.op="user_input"}:turn{otel.name="session_task.turn" thread.id=019d81cf-6f69-7230-98aa-74294ff2dc5a turn.id=019d86c8-0a8e-7013-b442-109aabbf75c9 model=gpt-5.4}: ignoring interface.defaultPrompt: prompt must be at most 128 characters path=/Users/jif/.codex/.tmp/plugins/plugins/life-science-research/.codex-plugin/plugin.json
  2026-04-13T12:27:30.405Z WARN  [019d81cf-6f69-7230-98aa-74294ff2dc5a] codex_core::plugins::manifest - session_loop{thread_id=019d81cf-6f69-7230-98aa-74294ff2dc5a}:submission_dispatch{otel.name="op.dispatch.user_input" submission.id="019d86c8-0a8e-7013-b442-109aabbf75c9" codex.op="user_input"}:turn{otel.name="session_task.turn" thread.id=019d81cf-6f69-7230-98aa-74294ff2dc5a turn.id=019d86c8-0a8e-7013-b442-109aabbf75c9 model=gpt-5.4}: ignoring interface.defaultPrompt: prompt must be at most 128 characters path=/Users/jif/.codex/.tmp/plugins/plugins/build-ios-apps/.codex-plugin/plugin.json
  2026-04-13T12:27:30.406Z WARN  [019d81cf-6f69-7230-98aa-74294ff2dc5a] codex_core::plugins::manifest - session_loop{thread_id=019d81cf-6f69-7230-98aa-74294ff2dc5a}:submission_dispatch{otel.name="op.dispatch.user_input" submission.id="019d86c8-0a8e-7013-b442-109aabbf75c9" codex.op="user_input"}:turn{otel.name="session_task.turn" thread.id=019d81cf-6f69-7230-98aa-74294ff2dc5a turn.id=019d86c8-0a8e-7013-b442-109aabbf75c9 model=gpt-5.4}: ignoring interface.defaultPrompt: prompt must be at most 128 characters path=/Users/jif/.codex/.tmp/plugins/plugins/life-science-research/.codex-plugin/plugin.json
  2026-04-13T12:27:30.408Z WARN  [019d81cf-6f69-7230-98aa-74294ff2dc5a] codex_core::plugins::manifest - session_loop{thread_id=019d81cf-6f69-7230-98aa-74294ff2dc5a}:submission_dispatch{otel.name="op.dispatch.user_input" submission.id="019d86c8-0a8e-7013-b442-109aabbf75c9" codex.op="user_input"}:turn{otel.name="session_task.turn" thread.id=019d81cf-6f69-7230-98aa-74294ff2dc5a turn.id=019d86c8-0a8e-7013-b442-109aabbf75c9 model=gpt-5.4}: ignoring interface.defaultPrompt: prompt must be at most 128 characters path=/Users/jif/.codex/.tmp/plugins/plugins/build-ios-apps/.codex-plugin/plugin.json
  ```

  jif-oai · 2026-04-13 19:08:43 +00:00
  d905376628
• Include legacy deny paths in elevated Windows sandbox setup (#17365)

  ## Summary
  
  This updates the Windows elevated sandbox setup/refresh path to include
  the legacy `compute_allow_paths(...).deny` protected children in the
  same deny-write payload pipe added for split filesystem carveouts.
  
  Concretely, elevated setup and elevated refresh now both build
  deny-write payload paths from:
  
  - explicit split-policy deny-write paths, preserving missing paths so
  setup can materialize them before applying ACLs
  - legacy `compute_allow_paths(...).deny`, which includes existing
  `.git`, `.codex`, and `.agents` children under writable roots
  
  This lets the elevated backend protect `.git` consistently with the
  unelevated/restricted-token path, and removes the old janky hard-coded
  `.codex` / `.agents` elevated setup helpers in favor of the shared
  payload path.
  
  ## Root Cause
  
  The landed split-carveout PR threaded a `deny_write_paths` pipe through
  elevated setup/refresh, but the legacy workspace-write deny set from
  `compute_allow_paths(...).deny` was not included in that payload. As a
  result, elevated workspace-write did not apply the intended deny-write
  ACLs for existing protected children like `<cwd>/.git`.
  
  ## Notes
  
  The legacy protected children still only enter the deny set if they
  already exist, because `compute_allow_paths` filters `.git`, `.codex`,
  and `.agents` with `exists()`. Missing explicit split-policy deny paths
  are preserved separately because setup intentionally materializes those
  before applying ACLs.
  
  ## Validation
  
  - `cargo fmt --check -p codex-windows-sandbox`
  - `cargo test -p codex-windows-sandbox`
  - `cargo build -p codex-cli -p codex-windows-sandbox --bins`
  - Elevated `codex exec` smoke with `windows.sandbox='elevated'`: fresh
  git repo, attempted append to `.git/config`, observed `Access is
  denied`, marker not written, Deny ACE present on `.git`
  - Unelevated `codex exec` smoke with `windows.sandbox='unelevated'`:
  fresh git repo, attempted append to `.git/config`, observed `Access is
  denied`, marker not written, Deny ACE present on `.git`

  iceweasel-oai · 2026-04-13 10:49:42 -07:00
  0131f99fd5
• feat: disable memory endpoint (#17626)
  jif-oai · 2026-04-13 18:29:49 +01:00
  46a266cd6a
• Use AbsolutePathBuf in skill loading and codex_home (#17407)

  Helps with FS migration later

  pakrym-oai · 2026-04-13 10:26:51 -07:00
  ac82443d07
• Do not fail thread start when trust persistence fails (#17595)

  Addresses #17593
  
  Problem: A regression introduced in
  https://github.com/openai/codex/pull/16492 made thread/start fail when
  Codex could not persist trusted project state, which crashes startup for
  users with read-only config.toml.
  
  Solution: Treat trusted project persistence as best effort and keep the
  current thread's config trusted in memory when writing config.toml
  fails.

  Eric Traut · 2026-04-13 10:03:21 -07:00
  d25a9822a7
• Fix TUI compaction item replay (#17657)

  Problem: PR #17601 updated context-compaction replay to call a new
  ChatWidget handler, but the handler was never implemented, breaking
  codex-tui compilation on main.
  
  Solution: Render context-compaction replay through the existing
  info-message path, preserving the intended `Context compacted` UI marker
  without adding a one-off handler.

  Eric Traut · 2026-04-13 09:20:10 -07:00
  313ad29ad7
• Suppress duplicate compaction and terminal wait events (#17601)

  Addresses #17514
  
  Problem: PR #16966 made the TUI render the deprecated context-compaction
  notification, while v2 could also receive legacy unified-exec
  interaction items alongside terminal-interaction notifications, causing
  duplicate "Context compacted" and "Waited for background terminal"
  messages.
  
  Solution: Suppress deprecated context-compaction notifications and
  legacy unified-exec interaction command items from the app-server v2
  projection, and render canonical context-compaction items through the
  existing TUI info-event path.

  Eric Traut · 2026-04-13 08:59:19 -07:00
  7c797c6544
• Wrap status reset timestamps in narrow layouts (#17481)

  Addresses #17453
  
  Problem: /status rate-limit reset timestamps can be truncated in narrow
  layouts, leaving users with partial times or dates.
  
  Solution: Let narrow rate-limit rows drop the fixed progress bar to
  preserve the percent summary, and wrap reset timestamps onto
  continuation lines instead of truncating them.

  Eric Traut · 2026-04-13 08:53:37 -07:00
  370be363f1
• Emit plan-mode prompt notifications for questionnaires (#17417)

  Addresses #17252
  
  Problem: Plan-mode clarification questionnaires used the generic
  user-input notification type, so configs listening for plan-mode-prompt
  did not fire when request_user_input waited for an answer.
  
  Solution: Map request_user_input prompts to the plan-mode-prompt
  notification and remove the obsolete user-input TUI notification
  variant.

  Eric Traut · 2026-04-13 08:52:14 -07:00
  ce5ad7b295
• Fix custom tool output cleanup on stream failure (#17470)

  Addresses #16255
  
  Problem: Incomplete Responses streams could leave completed custom tool
  outputs out of cleanup and retry prompts, making persisted history
  inconsistent and retries stale.
  
  Solution: Route stream and output-item errors through shared cleanup,
  and rebuild retry prompts from fresh session history after the first
  attempt.

  Eric Traut · 2026-04-13 08:35:17 -07:00
  a5783f90c9
• Make forked agent spawns keep parent model config (#17247)

  ## Summary
  
  When a `spawn_agent` call does a full-history fork, keep the parent's
  effective agent type and model configuration instead of applying child
  role/model overrides.
  
  This is the minimal config-inheritance slice of #16055. Prompt-cache key
  inheritance and MCP tool-surface stability are split into follow-up PRs.
  
  ## Design
  
  - Reject `agent_type`, `model`, and `reasoning_effort` for v1
  `fork_context` spawns.
  - Reject `agent_type`, `model`, and `reasoning_effort` for v2
  `fork_turns = "all"` spawns.
  - Keep v2 partial-history forks (`fork_turns = "N"`) configurable;
  requested model/reasoning overrides and role config still apply there.
  - Keep non-forked spawn behavior unchanged.
  
  ## Tests
  
  - `cargo +1.93.1 test -p codex-core spawn_agent_fork_context --lib`
  - `cargo +1.93.1 test -p codex-core multi_agent_v2_spawn_fork_turns
  --lib`
  - `cargo +1.93.1 test -p codex-core
  multi_agent_v2_spawn_partial_fork_turns_allows_agent_type_override
  --lib`

  friel-openai · 2026-04-13 15:28:40 +00:00
  776246c3f5
• fix: dedup compact (#17643)
  jif-oai · 2026-04-13 16:08:53 +01:00
  3f62b5cc61
• fix: stability exec server (#17640)
  jif-oai · 2026-04-13 14:52:12 +01:00
  49ca7c9f24
• nit: change consolidation model (#17633)
  jif-oai · 2026-04-13 13:02:07 +01:00
  86bd0bc95c
• Build remote exec env from exec-server policy (#17216)

  ## Summary
  - add an exec-server `envPolicy` field; when present, the server starts
  from its own process env and applies the shell environment policy there
  - keep `env` as the exact environment for local/embedded starts, but
  make it an overlay for remote unified-exec starts
  - move the shell-environment-policy builder into `codex-config` so Core
  and exec-server share the inherit/filter/set/include behavior
  - overlay only runtime/sandbox/network deltas from Core onto the
  exec-server-derived env
  
  ## Why
  Remote unified exec was materializing the shell env inside Core and
  forwarding the whole map to exec-server, so remote processes could
  inherit the orchestrator machine's `HOME`, `PATH`, etc. This keeps the
  base env on the executor while preserving Core-owned runtime additions
  like `CODEX_THREAD_ID`, unified-exec defaults, network proxy env, and
  sandbox marker env.
  
  ## Validation
  - `just fmt`
  - `git diff --check`
  - `cargo test -p codex-exec-server --lib`
  - `cargo test -p codex-core --lib unified_exec::process_manager::tests`
  - `cargo test -p codex-core --lib exec_env::tests`
  - `cargo test -p codex-core --lib exec_env_tests` (compile-only; filter
  matched 0 tests)
  - `cargo test -p codex-config --lib shell_environment` (compile-only;
  filter matched 0 tests)
  - `just bazel-lock-update`
  
  ## Known local validation issue
  - `just bazel-lock-check` is not runnable in this checkout: it invokes
  `./scripts/check-module-bazel-lock.sh`, which is missing.
  
  ---------
  
  Co-authored-by: Codex <noreply@openai.com>
  Co-authored-by: pakrym-oai <pakrym@openai.com>

  jif-oai · 2026-04-13 09:59:08 +01:00
  bacb92b1d7
• feat: ignore keyring on 0.0.0 (#17221)

  To prevent the spammy: 
  <img width="424" height="172" alt="Screenshot 2026-04-09 at 13 36 16"
  src="https://github.com/user-attachments/assets/b5ece9e3-c561-422f-87ec-041e7bd6813d"
  />

  jif-oai · 2026-04-13 09:58:47 +01:00
  4ffe6c2ce6