agent/codex
1
0
Fork 0
mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add timestamped SQLite /feedback logs without schema changes (#13645)

Browse Source 
## Summary
- keep the SQLite schema unchanged (no migrations)
- add timestamps to SQLite-backed `/feedback` log exports
- keep the existing SQL-side byte cap behavior and newline handling
- document the remaining fidelity gap (span prefixes + structured
fields) with TODOs

## Details
- update `query_feedback_logs` to format each exported line as:
  - `YYYY-MM-DDTHH:MM:SS.ffffffZ {level} {message}`
- continue scoping rows to requested-thread + same-process threadless
logs
- continue capping in SQL before returning rows
- keep the existing fallback behavior unchanged when SQLite returns no
rows
- update parity tests to normalize away the new timestamp prefix while
we still only store `message`

## Follow-up
- TODO already in code: persist enough span/event metadata in SQLite to
reproduce span prefixes and structured fields in `/feedback` exports

## Testing
- `cargo test -p codex-state`
- `just fmt`

---------

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Charley Cunningham
2026-03-05 16:53:37 -08:00
committed by GitHub
Unverified
parent e15e191ff7
commit 9f91c7f90f
2 changed files with 34 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/state/src/log_db.rs
+15 -3
View File
@@ -420,11 +420,23 @@ mod tests {
drop(guard);
// TODO(ccunningham): Store enough span metadata in SQLite to reproduce span
// prefixes like `feedback-thread{thread_id="thread-1"}:` in feedback exports.
// SQLite exports now include timestamps, while this test writer has
// `.without_time()`. Compare bodies after stripping the SQLite prefix.
let feedback_logs = writer
.snapshot()
.replace("feedback-thread{thread_id=\"thread-1\"}: ", "");
let strip_sqlite_timestamp = |logs: &str| {
logs.lines()
.map(|line| {
line.split_once(' ')
.map_or_else(|| line.to_string(), |(_, rest)| rest.to_string())
})
.collect::<Vec<_>>()
};
let feedback_lines = feedback_logs
.lines()
.map(ToString::to_string)
.collect::<Vec<_>>();
let deadline = Instant::now() + Duration::from_secs(2);
loop {
let sqlite_logs = String::from_utf8(
@@ -434,7 +446,7 @@ mod tests {
.expect("query feedback logs"),
)
.expect("valid utf-8");
if sqlite_logs == feedback_logs {
if strip_sqlite_timestamp(&sqlite_logs) == feedback_lines {
break;
}
assert!(
codex-rs/state/src/runtime/logs.rs
+19 -5
View File
@@ -288,6 +288,8 @@ WHERE id IN (
/// Query per-thread feedback logs, capped to the per-thread SQLite retention budget.
pub async fn query_feedback_logs(&self, thread_id: &str) -> anyhow::Result<Vec<u8>> {
let max_bytes = LOG_PARTITION_SIZE_LIMIT_BYTES;
// TODO(ccunningham): Store rendered span/event fields in SQLite so this
// export can match feedback formatting beyond timestamp + level + message.
let lines = sqlx::query_scalar::<_, String>(
r#"
WITH latest_process AS (
@@ -299,12 +301,24 @@ WITH latest_process AS (
),
feedback_logs AS (
SELECT
printf('%5s %s', level, message) || CASE
printf(
'%s.%06dZ %5s %s',
strftime('%Y-%m-%dT%H:%M:%S', ts, 'unixepoch'),
ts_nanos / 1000,
level,
message
) || CASE
WHEN substr(message, -1, 1) = char(10) THEN ''
ELSE char(10)
END AS line,
length(CAST(
printf('%5s %s', level, message) || CASE
printf(
'%s.%06dZ %5s %s',
strftime('%Y-%m-%dT%H:%M:%S', ts, 'unixepoch'),
ts_nanos / 1000,
level,
message
) || CASE
WHEN substr(message, -1, 1) = char(10) THEN ''
ELSE char(10)
END AS BLOB
@@ -830,7 +844,7 @@ mod tests {
assert_eq!(
String::from_utf8(bytes).expect("valid utf-8"),
" INFO alpha\n INFO bravo\n INFO charlie\n"
"1970-01-01T00:00:01.000000Z INFO alpha\n1970-01-01T00:00:02.000000Z INFO bravo\n1970-01-01T00:00:03.000000Z INFO charlie\n"
);
let _ = tokio::fs::remove_dir_all(codex_home).await;
@@ -952,7 +966,7 @@ mod tests {
assert_eq!(
String::from_utf8(bytes).expect("valid utf-8"),
" INFO threadless-before\n INFO thread-scoped\n INFO threadless-after\n"
"1970-01-01T00:00:01.000000Z INFO threadless-before\n1970-01-01T00:00:02.000000Z INFO thread-scoped\n1970-01-01T00:00:03.000000Z INFO threadless-after\n"
);
let _ = tokio::fs::remove_dir_all(codex_home).await;
@@ -1026,7 +1040,7 @@ mod tests {
assert_eq!(
String::from_utf8(bytes).expect("valid utf-8"),
" INFO old-process-thread\n INFO new-process-thread\n INFO new-process-threadless\n"
"1970-01-01T00:00:02.000000Z INFO old-process-thread\n1970-01-01T00:00:03.000000Z INFO new-process-thread\n1970-01-01T00:00:04.000000Z INFO new-process-threadless\n"
);
let _ = tokio::fs::remove_dir_all(codex_home).await;