mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
Remove just bench-smoke from just test. (#26716)
## Why `just test` should run the test suite without also compiling and executing benchmark smoke tests. Keeping benchmark validation explicit avoids adding unrelated work to every project-specific test invocation. ## What changed - Remove the `just bench-smoke` step from the Unix and Windows `test` recipes. - Document `just bench` and `just bench-smoke` as the explicit benchmark commands in `AGENTS.md`. ## Validation - `just test -p codex-arg0` - `just --dry-run test` - `just --dry-run bench-smoke`
This commit is contained in:
committed by
GitHub
Unverified
parent
cbac22dabe
commit
3ea9e98333
@@ -192,6 +192,12 @@ If you don’t have the tool:
|
||||
|
||||
- `cargo install --locked cargo-insta`
|
||||
|
||||
### Benchmarks
|
||||
|
||||
cargo benchmarks can be run with `just bench`, use the divan crate to write new ones.
|
||||
|
||||
Use `just bench-smoke` to dry-run the benchmark for a single iteration to ensure it works.
|
||||
|
||||
### Test assertions
|
||||
|
||||
- Tests should use pretty_assertions::assert_eq for clearer diffs. Import this at the top of the test module if it isn't already.
|
||||
|
||||
@@ -76,12 +76,10 @@ install:
|
||||
[unix]
|
||||
test *args:
|
||||
RUST_MIN_STACK={{ rust_min_stack }} cargo nextest run --no-fail-fast "$@"
|
||||
just bench-smoke
|
||||
|
||||
[windows]
|
||||
test *args:
|
||||
$env:RUST_MIN_STACK = "{{ rust_min_stack }}"; cargo nextest run --no-fail-fast @($args | Select-Object -Skip 1)
|
||||
just bench-smoke
|
||||
|
||||
# Run from the repository root so scripts that resolve paths from `cwd` see
|
||||
# the same layout they use in GitHub Actions.
|
||||
|
||||
Reference in New Issue
Block a user