L. Elaine Dazzio 91e34358eb Python: Feat: Add finish_reason support to AgentResponse and AgentResponseUpdate (#5211) ...

* feat: add finish_reason support to AgentResponse and AgentResponseUpdate

Add finish_reason field to AgentResponse and AgentResponseUpdate classes,
propagate it through _process_update() and map_chat_to_agent_update(),
and add comprehensive unit tests.

Fixes #4622

* feat: add finish_reason to AgentResponse and AgentResponseUpdate

* style: add copyright header to test_finish_reason.py

* docs: add finish_reason to AgentResponse and AgentResponseUpdate docstrings

* refactor: move finish_reason tests into test_types.py per review feedback

Move all finish_reason test cases from the separate test_finish_reason.py
file into test_types.py as requested by eavanvalkenburg. Tests are placed
in a new '# region finish_reason' section at the end of the file.

* fix: use model instead of model_id in _process_update

Address PR review feedback from @eavanvalkenburg — ChatResponse and
ChatResponseUpdate both use 'model', not 'model_id'.

* fix: resolve SIM102 lint error in _process_update

Combine nested if statements for AgentResponse finish_reason check
to satisfy ruff SIM102 rule, with line wrapping to stay under 120 chars.

* fix: resolve pyright reportArgumentType in map_chat_to_agent_update

Add type: ignore[arg-type] for FinishReason NewType widening when
passing ChatResponseUpdate.finish_reason to AgentResponseUpdate.
Matches existing patterns in the codebase (40+ similar ignores).

91e34358eb · 2026-04-16 19:39:09 +00:00

History

..

assets

Python: Unify tool results as Content items with rich content support (#4331)

2026-03-12 22:30:09 +00:00

core

Python: Feat: Add finish_reason support to AgentResponse and AgentResponseUpdate (#5211)

2026-04-16 19:39:09 +00:00

workflow

Add AgentExecutorResponse.with_text() to preserve conversation history through custom executors (#5255)

2026-04-16 08:39:19 +00:00

__init__.py

Python: [BREAKING] Main to core (#983)

2025-09-30 07:18:36 +00:00

conftest.py

Python: [BREAKING] Reduce core dependencies and simplify optional integrations (#4904)

2026-03-25 18:03:43 +00:00