2121 Commits

This Branch

This Branch

All Branches

• Escape JSON string values in CreateProgressLedgerResponse test helper

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/ec610c61-0a14-44e2-82fd-1cf35e85d6cc
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 03:22:40 +00:00
  3f5b4fdb4e
• Update error messages per review comments in MagenticOrchestrator and MagenticWorkflowBuilder

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/053e5ded-81e3-4e56-acf1-2a8a939a04b0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 02:23:01 +00:00
  6dc748e12e
• Fix IDE1006: add Async suffix to async test methods in MagenticOrchestrationTests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/629fcc07-865e-4832-9e59-ea13df561c5a
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 02:17:52 +00:00
  3d16456bbe
• Merge branch 'main' into copilot/add-e2e-tests-for-magentic-again
  Jacob Alber · 2026-05-13 21:57:05 -04:00
  6fcc0d6043
• Remove temporary markdown files

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/b3e67553-a3a3-4282-98f2-afd8ad7a6b5d
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:54:32 +00:00
  7d062bf4f9
• Add PR description markdown

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/df9b4579-10c3-4bfb-927e-da3a0e70009e
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:52:03 +00:00
  13e4e0f1cd
• Rewrite ImplementationReview.md with final 23-test status

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/e490fdf7-f107-4fde-ba1f-efdfd9a729c6
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:47:35 +00:00
  70abd53afd
• Add IsTerminated guard to TakeTurnAsync and post-termination rejection test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/e490fdf7-f107-4fde-ba1f-efdfd9a729c6
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:42:54 +00:00
  eb5dec4162
• Add empty-team validation to MagenticWorkflowBuilder.Build() and E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/e490fdf7-f107-4fde-ba1f-efdfd9a729c6
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:32:44 +00:00
  d5bbf4ec9c
• Rewrite Magentic implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/ed87670a-bf4d-4ba5-a2f3-395a2eead9de
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:21:56 +00:00
  9cd4f2dc49
• Update stall docs to use > semantics, skip checkpoint-state tests, simplify NextSpeaker fallback test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/cc9ea5a8-84d8-4b6d-bb60-ac9619824d81
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:17:44 +00:00
  4dbe3598db
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/3d15763b-3a68-488e-9412-3fa280e083c0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 00:57:10 +00:00
  964210730c
• [BREAKING] Python: DevUI: tighten default access controls and CORS posture (#5740)

  * Python: DevUI: tighten default access controls and CORS posture
  
  Adjusts the default configuration of the DevUI server so the out-of-the-box
  posture matches what most callers expect when running locally. Adds explicit
  opt-outs for callers who need the previous behavior.
  
  - DevServer gains auth_enabled and auth_token constructor params; auth is on by
    default. Auto-generates and logs a token when none provided.
  - CORS default is an empty allowlist on every host. Callers wanting cross-origin
    pass cors_origins explicitly.
  - Streaming /v1/responses no longer sets Access-Control-Allow-Origin directly;
    CORSMiddleware owns all CORS decisions.
  - Loopback binds enforce a Host-header allowlist.
  - /meta moved out of the auth bypass list (was alongside /health and /).
  - serve() default flipped to auth_enabled=True; passes auth args through to
    DevServer instead of using env-var indirection.
  - CLI: --auth opt-in replaced with --no-auth opt-out; --auth-token preserved.
  - Tests cover the eight behaviors above in test_server.py.
  
  * Python: DevUI: address PR review comments
  
  - /meta now derives auth_required from self.auth_enabled instead of
    reading DEVUI_AUTH_TOKEN, so the auto-generated and explicit
    auth_token paths report correctly.
  - Reorder middleware so the loopback Host-header allowlist is registered
    last; Starlette wraps later-added middleware around earlier-added ones,
    so the host check now runs outermost (before CORS/auth) as intended.
  - Rework comments to describe the behavior rather than threat scenarios.
  - Streaming-headers and CORS tests now construct the server with an
    explicit auth_token and send a Bearer header, so the assertions
    actually exercise the streaming/CORS path instead of short-circuiting
    in the auth middleware.

  Evan Mattson · 2026-05-14 00:37:46 +00:00
  fbccad091b
• Update implementation review doc for replan-fix and stall threshold alignment

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/43e46b0d-4263-4353-856a-c3730abb1734
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:42:16 +00:00
  5baa5a5f3f
• Fix replan-on-every-turn: skip plan on agent return; align StallCount to > (match Python)

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/43e46b0d-4263-4353-856a-c3730abb1734
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:40:24 +00:00
  07e68604f1
• Magentic E2E: preserve IsStalled on stall-triggered plan reviews, add routing/stall tests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:27:28 +00:00
  e4538c34d3
• Add Consecutive_Stalls_Trigger_Reset E2E test for multi-stall threshold reset

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:26:02 +00:00
  1e242c2f9f
• Add Progress_Made_Decrements_StallCount E2E test verifying stall count decrement avoids reset

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:23:29 +00:00
  e8cbd1cfec
• Add Task_Delegates_To_Correct_Agent E2E test with multi-participant routing assertion

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:20:43 +00:00
  72c79aeac5
• Rename isStalled parameter to replanAfterStall for clarity

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/1b9e74e8-69e1-43f2-8467-c5ba963c2622
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:12:52 +00:00
  b68cfc0c50
• Preserve IsStalled on stall-triggered plan review requests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/1b9e74e8-69e1-43f2-8467-c5ba963c2622
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:10:45 +00:00
  c46ce45fdb
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/21f3b1ae-183e-4fea-99ad-14efc19f084d
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:58:34 +00:00
  1c8e16b332
• Update ImplementationReview.md to reflect 18 tests and new coverage

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:51:28 +00:00
  f566d49cf7
• Add PlanReview_Multiple_Revisions E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:49:20 +00:00
  5063540e19
• Fix CA1873 in DevUI by using LoggerMessage source generator (#5831)

  Replaces two ILogger.LogWarning(string, params object?[]) calls in DevUIAuthFilter and DevUIExtensions with allocation-free [LoggerMessage] partial methods on a new internal DevUILog class. Preserves original message templates and structured property names ({RemoteIp}, {EnvVar}).
  
  Co-authored-by: alliscode <25218250+alliscode@users.noreply.github.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Ben Thomas · 2026-05-13 22:48:49 +00:00
  741259476f
• Add Stall_NoProgress_Increments_StallCount E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:47:34 +00:00
  34b270937b
• Add ProgressLedger_Max_Retries_Triggers_Reset E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:46:21 +00:00
  600bc91c84
• Add ProgressLedger_Retry_On_Parse_Failure E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:44:17 +00:00
  375356f765
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6fe88a80-2e05-40d5-9539-ca7c59b9022b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:36:18 +00:00
  584d9b1163
• Update ImplementationReview.md to reflect 14 tests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:30:33 +00:00
  9a955c33a6
• Add Instruction_Message_Sent_When_Present E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:28:42 +00:00
  1ff632d365
• Add PlanReview_On_Stall_Replan E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:26:31 +00:00
  2673054af2
• Add MaxResetLimit_Terminates_Workflow E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:25:12 +00:00
  4601c1ac7b
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/1f878ef4-61b0-410a-a8bc-ebf618b3e5de
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:18:08 +00:00
  eb3e0e476f
• Update MagenticE2E_ImplementationReview.md with full coverage status

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:10:59 +00:00
  4cb3010927
• Python: Strip server-issued response item IDs under storage (#3295) (#5690)

  Fixes microsoft/agent-framework#3295. When the OpenAI Responses chat
  client sends a request that carries previous_response_id / conversation_id
  / conversation, the server already has the prior turn's response items
  and rejects duplicates with "Duplicate item found with id fc_xxx". The
  chat client was re-sending them inline whenever the input messages still
  carried the items in additional_properties (workflow replay, history
  providers, etc.), which broke any tool-using agent with persistent
  history.
  
  Decisions:
  - Single chokepoint: _prepare_message_for_openai. When the resulting
    request uses service-side storage, drop function_call, reasoning,
    approval-request/response, and local-shell-call items from the wire
    input. Keep function_result with its call_id; the server pairs it to
    the prior function_call via that key.
  - function_result is preserved unconditionally except for the local-shell
    variant, which carries its own server-issued item id.
  - No public API change. Wire format change is subtractive and only on
    requests that would otherwise 400.
  - Re-pointed the strict-xfail in test_full_conversation.py from #4047 to
    #3295. Kept xfail because the test asserts executor-level session-id
    clearing, which is the defense-in-depth half tracked by 3295-03; this
    slice closes the wire-level half.
  
  Files:
  - python/packages/openai/agent_framework_openai/_chat_client.py: strip
    rule applied alongside the existing reasoning-item branch.
  - python/packages/openai/tests/openai/test_openai_chat_client.py: four
    new tests pin the contract (function_call, approval, local-shell-call
    stripped under storage; everything kept without storage). Updated
    pre-existing tests that exercised the storage-on path to either pass
    request_uses_service_side_storage=False explicitly or assert the new
    strip behavior.
  - python/packages/foundry/tests/foundry/test_foundry_chat_client.py:
    same explicit storage-off opt-in for the inherited test.
  - python/packages/core/tests/workflow/test_full_conversation.py:
    re-pointed xfail reason to #3295 and the executor-level follow-up.
  
  Notes for next iteration:
  - 3295-01 (HITL wire-format validation against live OpenAI/Foundry) was
    not run; it requires the user's API credentials. The PRD design is
    locked but the empirical confirmation is still pending. If script 3
    fails on either provider, this slice may need to be revisited.
  - 3295-03 (clear service_session_id in AgentExecutor on full-history
    replay) remains open. After it lands the xfail in
    test_full_conversation.py can be removed.
  - pytest was not run in this iteration because uv-based pytest commands
    required interactive approval. Validation rests on careful reading;
    next iteration should run the openai + core test suites.

  Evan Mattson · 2026-05-13 22:09:04 +00:00
  09a3d0d307
• Add MaxStallCount_Triggers_Reset E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:08:57 +00:00
  d52de26759
• Add MaxRoundLimit_Terminates_Workflow E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:07:32 +00:00
  b7fd35401b
• Add PlanReview_Revised_Triggers_Replan E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:06:14 +00:00
  bbd94f7b05
• Add Task_Completes_After_Multiple_Rounds E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:03:25 +00:00
  1b609b230b
• Add NextSpeaker_Empty_Falls_Back_To_First E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:02:11 +00:00
  d1a66a8f3d
• Add PlanSignoff_Disabled_Proceeds_Immediately E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:00:48 +00:00
  c0bd2a33eb
• Add Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/b2c60ce7-4d05-4a0d-b05d-d4284f5b7bb3
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 21:52:45 +00:00
  8a6a5948ed
• Add next speaker validation test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/322c9e2d-59bc-42ad-9a1e-f6fd4c866b26
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 21:28:35 +00:00
  00a132a095
• Add plan review test and event emission tests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/322c9e2d-59bc-42ad-9a1e-f6fd4c866b26
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 21:26:53 +00:00
  cd7e8c8822
• Fix MagenticOrchestrator output declaration and add first E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/322c9e2d-59bc-42ad-9a1e-f6fd4c866b26
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 21:23:17 +00:00
  b207921fcc
• Add MagenticOrchestrationTests.cs scaffold for Magentic E2E tests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/44a4fd8a-3828-40e5-9435-90381aeffdb8
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 20:52:51 +00:00
  68fbead632
• [Python] [Breaking] Extract skill spec metadata into SkillFrontmatter (#5775)

  * Fix Skill docstring consistency and spelling
  
  - Add ClassSkill to Skill class docstring concrete implementations list
  - Normalize 'defence' to 'defense' for American English consistency
  - Remove extra blank line in InlineSkill docstring example
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix E501 line-too-long lint error in test_skills.py
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix stale test section header to reflect SkillFrontmatter API
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Fix metadata children overriding top-level frontmatter fields
  
  Scope YAML_KV_RE to column-0 keys only so indented children
  under metadata: are not mistakenly parsed as top-level fields.
  Add regression test and spec fields to sample SKILL.md files.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  SergeyMenshykh · 2026-05-13 20:35:52 +00:00
  ab09246dc4
• Add E2E test plan for Magentic orchestrator

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/96d76349-1ffd-482b-a3ee-ed208778b1bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 20:22:46 +00:00
  90ec8e4555
• Python: fix: prevent MCP message_handler deadlock on notification reload (#4866)

  * fix(python): prevent MCP message_handler deadlock on notification reload
  
  When an MCP server sends a notifications/tools/list_changed or
  notifications/prompts/list_changed notification, the message_handler
  previously awaited load_tools()/load_prompts() directly. Since the
  handler runs on the MCP SDK's single-threaded receive loop, this
  caused a deadlock: load_tools() sends a list_tools request and waits
  for its response, but the receive loop cannot deliver that response
  while blocked in the handler.
  
  This manifested as a timeout in call_tool(), which then surfaced as
  "Error: Function failed." to the model instead of the real tool
  output. The MATLAB MCP server reliably triggers this because it sends
  a tools/list_changed notification during tool execution.
  
  Fix: schedule reloads as background asyncio.Tasks via a new
  _schedule_reload() helper, freeing the receive loop immediately.
  
  Fixes #4828
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Address PR review feedback: fix exc_info, coalesce reloads, shutdown cleanup, tests
  
  - Fix exc_info=exc -> exc_info=True in _schedule_reload and message_handler
  - Tighten _schedule_reload param type from Any to Coroutine[Any, Any, None]
  - Coalesce reloads: cancel-and-replace per reload kind to prevent unbounded growth
  - Cancel pending reload tasks in _close_on_owner before tearing down session
  - Re-raise CancelledError in _safe_reload to respect task cancellation
  - Replace flaky asyncio.sleep(0) with asyncio.wait_for/gather in tests
  - Add caplog assertions to verify reload failure is actually logged
  - Assert _pending_reload_tasks cleanup on error path
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: address review comments on MCP reload handling
  
  - Fix exc_info=True -> exc_info=message in message_handler error logging,
    since the handler is not called from an except block
  - Await cancelled reload tasks in _close_on_owner before tearing down
    the session to avoid 'Task was destroyed but pending' warnings
  - Add cancel-and-replace test verifying duplicate notifications cancel
    the first reload task and only keep one in flight
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * fix: remove Task.cancelling() call for Python 3.10 compat
  
  Task.cancelling() was added in Python 3.11. Replace with awaiting
  the task and checking cancelled() instead.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Add debug log when cancelling superseded reload task
  
  Log at DEBUG level when a new notification cancels an in-flight reload
  task, improving observability of the cancel-and-replace behavior.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <copilot@github.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Giles Odigwe · 2026-05-13 20:09:59 +00:00
  7d23582e2b