2135 Commits

This Branch

This Branch

All Branches

• Merge branch 'main' into copilot/add-e2e-tests-for-magentic-again
  Jacob Alber · 2026-05-14 14:07:15 -04:00
  18d9ccc216
• .NET: fix: allow naming handoff workflows (#5799)

  * fix: allow naming handoff workflows
  
  * Only set name/description if not NullOrWhitespace
  
  Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Jacob Alber <jalber@fernir.com>
  Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
  Co-authored-by: Jacob Alber <jaalber@microsoft.com>

  Yufeng He · 2026-05-14 17:10:27 +00:00
  3256550c55
• .NET: Add Workflow Builder Specialized Edge tests (#5826)

  * Add workflow builder edge tests
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/3c3d5324-cdcd-4a38-8c67-94e4e78e29c5
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Strengthen workflow edge helper tests
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Normalize edge helper bad input validation
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Clarify edge helper target validation
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Use explicit target parameter names
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Document workflow edge test helpers
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Clarify null element validation messages
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Add repeated chain executor coverage
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Preserve Throw helper validation style
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Cover empty switch case targets
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Relax builder null assertion parameter checks
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/af831ee2-0a99-4427-9ffd-a3b5022c1b3b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Inline ValidateTargets into call sites
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/cb9a6a6a-02c7-41a8-a4b4-da16ad62ef86
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Refactor ForwardExcept with TFM-specialized TryGetNonEnumeratedCount
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/b081f61f-93ce-45dc-abbd-82c465395470
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Use TFM-specialized count check: TryGetNonEnumeratedCount for NET6+, ICollection pattern for NETFX
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/8ec28a43-e7b7-456e-8d8e-921511b4accc
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Apply TFM-specialized count check to ForwardMessage as well
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9238ea32-a3e8-4b83-9683-484ad400071f
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Address review feedback: simplify Throw.IfNull in SwitchBuilder per westey-m suggestion
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/299950fd-4457-47f3-a373-f65d601b7ea5
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Use indexed parameter name in SwitchBuilder Throw.IfNull: executors[index]
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/c5655707-5b0b-44f3-98a9-5f3961e32cfe
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Revert #if NET6_0_OR_GREATER back to #if NET; inline executorIndex++
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/c5655707-5b0b-44f3-98a9-5f3961e32cfe
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Add comment explaining unusual Throw.IfNull use for null elements inside collection
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/c5655707-5b0b-44f3-98a9-5f3961e32cfe
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  Co-authored-by: Jacob Alber <jaalber@microsoft.com>

  Copilot · 2026-05-14 16:23:41 +00:00
  190ca75b6a
• .NET: Fix flaky InputWaiter_WaitForInputAsync_BlocksUntilSignaledAsync (#5835)

  * test: remove finite timeout in BlocksUntilSignaledAsync to fix race
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/962b7404-4266-4a16-906c-ba3e607c2764
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * address review: clarify comment, add timeout test, cross-reference test names
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/e406a5f2-ad31-4d37-b090-69e10713f885
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  Co-authored-by: Jacob Alber <jaalber@microsoft.com>

  Copilot · 2026-05-14 15:36:42 +00:00
  8058fb1c5b
• .NET: Add sample for invoking Foundry Toolbox tools from declarative workflows (#5829)

  * Add sample for invoking Foundry Toolbox tools from declarative workflows
  
  * Addressed initial PR comments.

  Peter Ibekwe · 2026-05-14 15:30:48 +00:00
  189e64bfdd
• .NET: Harness console refactoring (#5811)

  * Restructure harness console so that reactive app is the entry point
  
  * Further refactoring to split tool formatters, improve UX, make console configurable and fix bugs
  
  * Address PR comments.
  
  * UX tweak
  
  * Fix streaming text bug
  
  * Address PR comments.

  westey · 2026-05-14 15:22:11 +00:00
  3047ad3066
• Improvements for DevUI (#5840)
  Evan Mattson · 2026-05-14 15:05:27 +00:00
  0e12640c70
• Python: Bump agent-framework-ag-ui to release candidate stage (#5844)

  * Bump agent-framework-ag-ui to release candidate stage
  
  * Mark agent-framework-ag-ui as rc in PACKAGE_STATUS

  Evan Mattson · 2026-05-14 14:56:34 +00:00
  ae666a4887
• Merge branch 'main' into copilot/add-e2e-tests-for-magentic-again
  Jacob Alber · 2026-05-14 10:12:30 -04:00
  5be4d9f9f4
• .NET: Add Executor RouteBuilder Unit Tests (#5824)

  * Add RouteBuilder unit tests
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Address RouteBuilder test review feedback
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Fix RouteBuilder test nullability warning
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Refine RouteBuilder test helpers
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Refactor overload int constants to HandlerOverload enum
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/19397f58-a88a-41cf-bd85-588f520e0d0f
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Fix ValueTask compatibility with .NET Framework 4.7.2
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/a8437809-0898-43a6-a950-09eb3417f58a
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  * Fix IDE0001 format errors - simplify generic type names
  
  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/8573214e-ec42-4969-ba94-76bdc8ad3e59
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>
  Co-authored-by: Jacob Alber <jaalber@microsoft.com>

  Copilot · 2026-05-14 13:36:38 +00:00
  eb40535436
• Update version to 1.6.1 for release (#5843)
  westey · 2026-05-14 11:55:04 +00:00
  dotnet-1.6.1 2d83a9b10d
• .NET: DevUI: quarantine flaky discovery integration test (#5845) (#5846)

  TestServerWithDevUI_ResolvesMixedAgentsAndWorkflows_AllRegistrationsAsync fails intermittently in the merge_group with NRE on the discovery response, blocking PRs unrelated to DevUI from merging. Skip via Fact(Skip=...) referencing #5845 while the underlying race is investigated.

  Roger Barreto · 2026-05-14 11:51:34 +00:00
  198761d3ba
• .NET: Filestore improvements (#5842)

  * Filestore improvements
  
  * Address PR comments

  westey · 2026-05-14 11:09:01 +00:00
  4e65fabafc
• [BREAKING] Python: Align file skill folder discovery with agentskills.io spec (#5807)

  * Align Python FileSkillsSource with agentskills.io spec
  
  Update FileSkillsSource to scan spec-defined subdirectories instead of
  recursive rglob for resource and script discovery:
  
  - Resources: scan 'references/' and 'assets/' (was: entire skill tree)
  - Scripts: scan 'scripts/' (was: entire skill tree)
  - Add resource_directories and script_directories parameters for
    customization, with '.' root indicator for skill root files
  - Add directory validation: reject '..' traversal, absolute paths, empty
    names; normalize separators and deduplicate directories
  - Non-recursive scanning within each configured directory (top-level only)
  - Containment check validates files against target directory, not just
    skill root, for stronger path-traversal defense
  - Case-insensitive directory deduplication via os.path.normcase()
  - Cross-platform absolute path rejection in directory validation
  - Sort discovery results for stable ordering
  - Update SkillsProvider.from_paths() to pass new parameters through
  - Update all tests for new subdirectory-scoped discovery behavior
  
  Resolves #5711.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Address PR review: tighten path validation and add containment guard
  
  - Narrow Windows absolute path check to proper drive-root pattern
    (re.match r'^[A-Za-z]:[/\\]') to avoid rejecting valid POSIX names
  - Add _is_path_within_directory guard before _has_symlink_in_path in
    both discovery methods to prevent ValueError on escaped paths
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  * Log warning on OSError during directory listing in skill discovery
  
  Address review comment: _discover_resource_files and _discover_script_files
  previously swallowed OSError silently when iterdir() failed. Now log a
  warning so permission errors and transient FS failures are visible
  instead of making resource/script directories silently disappear.
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  SergeyMenshykh · 2026-05-14 10:28:22 +00:00
  d40670748d
• Escape JSON string values in CreateProgressLedgerResponse test helper

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/ec610c61-0a14-44e2-82fd-1cf35e85d6cc
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 03:22:40 +00:00
  3f5b4fdb4e
• Update error messages per review comments in MagenticOrchestrator and MagenticWorkflowBuilder

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/053e5ded-81e3-4e56-acf1-2a8a939a04b0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 02:23:01 +00:00
  6dc748e12e
• Fix IDE1006: add Async suffix to async test methods in MagenticOrchestrationTests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/629fcc07-865e-4832-9e59-ea13df561c5a
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 02:17:52 +00:00
  3d16456bbe
• Merge branch 'main' into copilot/add-e2e-tests-for-magentic-again
  Jacob Alber · 2026-05-13 21:57:05 -04:00
  6fcc0d6043
• Remove temporary markdown files

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/b3e67553-a3a3-4282-98f2-afd8ad7a6b5d
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:54:32 +00:00
  7d062bf4f9
• Add PR description markdown

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/df9b4579-10c3-4bfb-927e-da3a0e70009e
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:52:03 +00:00
  13e4e0f1cd
• Rewrite ImplementationReview.md with final 23-test status

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/e490fdf7-f107-4fde-ba1f-efdfd9a729c6
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:47:35 +00:00
  70abd53afd
• Add IsTerminated guard to TakeTurnAsync and post-termination rejection test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/e490fdf7-f107-4fde-ba1f-efdfd9a729c6
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:42:54 +00:00
  eb5dec4162
• Add empty-team validation to MagenticWorkflowBuilder.Build() and E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/e490fdf7-f107-4fde-ba1f-efdfd9a729c6
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:32:44 +00:00
  d5bbf4ec9c
• Rewrite Magentic implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/ed87670a-bf4d-4ba5-a2f3-395a2eead9de
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:21:56 +00:00
  9cd4f2dc49
• Update stall docs to use > semantics, skip checkpoint-state tests, simplify NextSpeaker fallback test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/cc9ea5a8-84d8-4b6d-bb60-ac9619824d81
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 01:17:44 +00:00
  4dbe3598db
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/3d15763b-3a68-488e-9412-3fa280e083c0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-14 00:57:10 +00:00
  964210730c
• [BREAKING] Python: DevUI: tighten default access controls and CORS posture (#5740)

  * Python: DevUI: tighten default access controls and CORS posture
  
  Adjusts the default configuration of the DevUI server so the out-of-the-box
  posture matches what most callers expect when running locally. Adds explicit
  opt-outs for callers who need the previous behavior.
  
  - DevServer gains auth_enabled and auth_token constructor params; auth is on by
    default. Auto-generates and logs a token when none provided.
  - CORS default is an empty allowlist on every host. Callers wanting cross-origin
    pass cors_origins explicitly.
  - Streaming /v1/responses no longer sets Access-Control-Allow-Origin directly;
    CORSMiddleware owns all CORS decisions.
  - Loopback binds enforce a Host-header allowlist.
  - /meta moved out of the auth bypass list (was alongside /health and /).
  - serve() default flipped to auth_enabled=True; passes auth args through to
    DevServer instead of using env-var indirection.
  - CLI: --auth opt-in replaced with --no-auth opt-out; --auth-token preserved.
  - Tests cover the eight behaviors above in test_server.py.
  
  * Python: DevUI: address PR review comments
  
  - /meta now derives auth_required from self.auth_enabled instead of
    reading DEVUI_AUTH_TOKEN, so the auto-generated and explicit
    auth_token paths report correctly.
  - Reorder middleware so the loopback Host-header allowlist is registered
    last; Starlette wraps later-added middleware around earlier-added ones,
    so the host check now runs outermost (before CORS/auth) as intended.
  - Rework comments to describe the behavior rather than threat scenarios.
  - Streaming-headers and CORS tests now construct the server with an
    explicit auth_token and send a Bearer header, so the assertions
    actually exercise the streaming/CORS path instead of short-circuiting
    in the auth middleware.

  Evan Mattson · 2026-05-14 00:37:46 +00:00
  fbccad091b
• Update implementation review doc for replan-fix and stall threshold alignment

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/43e46b0d-4263-4353-856a-c3730abb1734
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:42:16 +00:00
  5baa5a5f3f
• Fix replan-on-every-turn: skip plan on agent return; align StallCount to > (match Python)

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/43e46b0d-4263-4353-856a-c3730abb1734
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:40:24 +00:00
  07e68604f1
• Magentic E2E: preserve IsStalled on stall-triggered plan reviews, add routing/stall tests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:27:28 +00:00
  e4538c34d3
• Add Consecutive_Stalls_Trigger_Reset E2E test for multi-stall threshold reset

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:26:02 +00:00
  1e242c2f9f
• Add Progress_Made_Decrements_StallCount E2E test verifying stall count decrement avoids reset

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:23:29 +00:00
  e8cbd1cfec
• Add Task_Delegates_To_Correct_Agent E2E test with multi-participant routing assertion

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/9b34e409-61b8-4650-ae55-34efad034ed0
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:20:43 +00:00
  72c79aeac5
• Rename isStalled parameter to replanAfterStall for clarity

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/1b9e74e8-69e1-43f2-8467-c5ba963c2622
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:12:52 +00:00
  b68cfc0c50
• Preserve IsStalled on stall-triggered plan review requests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/1b9e74e8-69e1-43f2-8467-c5ba963c2622
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 23:10:45 +00:00
  c46ce45fdb
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/21f3b1ae-183e-4fea-99ad-14efc19f084d
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:58:34 +00:00
  1c8e16b332
• Update ImplementationReview.md to reflect 18 tests and new coverage

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:51:28 +00:00
  f566d49cf7
• Add PlanReview_Multiple_Revisions E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:49:20 +00:00
  5063540e19
• Fix CA1873 in DevUI by using LoggerMessage source generator (#5831)

  Replaces two ILogger.LogWarning(string, params object?[]) calls in DevUIAuthFilter and DevUIExtensions with allocation-free [LoggerMessage] partial methods on a new internal DevUILog class. Preserves original message templates and structured property names ({RemoteIp}, {EnvVar}).
  
  Co-authored-by: alliscode <25218250+alliscode@users.noreply.github.com>
  Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

  Ben Thomas · 2026-05-13 22:48:49 +00:00
  741259476f
• Add Stall_NoProgress_Increments_StallCount E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:47:34 +00:00
  34b270937b
• Add ProgressLedger_Max_Retries_Triggers_Reset E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:46:21 +00:00
  600bc91c84
• Add ProgressLedger_Retry_On_Parse_Failure E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/125f6628-6b3b-4c51-9a51-ae84baece6bb
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:44:17 +00:00
  375356f765
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6fe88a80-2e05-40d5-9539-ca7c59b9022b
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:36:18 +00:00
  584d9b1163
• Update ImplementationReview.md to reflect 14 tests

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:30:33 +00:00
  9a955c33a6
• Add Instruction_Message_Sent_When_Present E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:28:42 +00:00
  1ff632d365
• Add PlanReview_On_Stall_Replan E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:26:31 +00:00
  2673054af2
• Add MaxResetLimit_Terminates_Workflow E2E test

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/aba19507-7c7e-40dd-850d-d1fabb5dfa65
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:25:12 +00:00
  4601c1ac7b
• Rewrite Magentic E2E implementation review

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/1f878ef4-61b0-410a-a8bc-ebf618b3e5de
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:18:08 +00:00
  eb3e0e476f
• Update MagenticE2E_ImplementationReview.md with full coverage status

  Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/6e8bca46-448d-4f21-a7e9-240179571970
  
  Co-authored-by: lokitoth <6936551+lokitoth@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-05-13 22:10:59 +00:00
  4cb3010927
• Python: Strip server-issued response item IDs under storage (#3295) (#5690)

  Fixes microsoft/agent-framework#3295. When the OpenAI Responses chat
  client sends a request that carries previous_response_id / conversation_id
  / conversation, the server already has the prior turn's response items
  and rejects duplicates with "Duplicate item found with id fc_xxx". The
  chat client was re-sending them inline whenever the input messages still
  carried the items in additional_properties (workflow replay, history
  providers, etc.), which broke any tool-using agent with persistent
  history.
  
  Decisions:
  - Single chokepoint: _prepare_message_for_openai. When the resulting
    request uses service-side storage, drop function_call, reasoning,
    approval-request/response, and local-shell-call items from the wire
    input. Keep function_result with its call_id; the server pairs it to
    the prior function_call via that key.
  - function_result is preserved unconditionally except for the local-shell
    variant, which carries its own server-issued item id.
  - No public API change. Wire format change is subtractive and only on
    requests that would otherwise 400.
  - Re-pointed the strict-xfail in test_full_conversation.py from #4047 to
    #3295. Kept xfail because the test asserts executor-level session-id
    clearing, which is the defense-in-depth half tracked by 3295-03; this
    slice closes the wire-level half.
  
  Files:
  - python/packages/openai/agent_framework_openai/_chat_client.py: strip
    rule applied alongside the existing reasoning-item branch.
  - python/packages/openai/tests/openai/test_openai_chat_client.py: four
    new tests pin the contract (function_call, approval, local-shell-call
    stripped under storage; everything kept without storage). Updated
    pre-existing tests that exercised the storage-on path to either pass
    request_uses_service_side_storage=False explicitly or assert the new
    strip behavior.
  - python/packages/foundry/tests/foundry/test_foundry_chat_client.py:
    same explicit storage-off opt-in for the inherited test.
  - python/packages/core/tests/workflow/test_full_conversation.py:
    re-pointed xfail reason to #3295 and the executor-level follow-up.
  
  Notes for next iteration:
  - 3295-01 (HITL wire-format validation against live OpenAI/Foundry) was
    not run; it requires the user's API credentials. The PRD design is
    locked but the empirical confirmation is still pending. If script 3
    fails on either provider, this slice may need to be revisited.
  - 3295-03 (clear service_session_id in AgentExecutor on full-history
    replay) remains open. After it lands the xfail in
    test_full_conversation.py can be removed.
  - pytest was not run in this iteration because uv-based pytest commands
    required interactive approval. Validation rests on careful reading;
    next iteration should run the openai + core test suites.

  Evan Mattson · 2026-05-13 22:09:04 +00:00
  09a3d0d307