agent/agent-framework
1
0
Fork 0
mirror of https://github.com/microsoft/agent-framework.git synced 2026-06-16 21:04:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: treat null RemoteIpAddress as trusted in DevUIAuthFilter

Browse Source 
A null Connection.RemoteIpAddress indicates an in-process connection
(e.g., an ASP.NET Core TestServer created via UseTestServer()); treat
it as loopback so DevUI endpoints are accessible in that scenario.

The integration tests in DevUIIntegrationTests.cs call GetTestClient()
which, on .NET 10, results in RemoteIpAddress being set to 192.0.2.1
(a non-loopback documentation IP) by the TestServer. Those tests
already use AddDevUI(o => o.AllowRemoteAccess = true) to bypass the
loopback guard. The null-IP change is a defensive improvement that
handles other in-process test host configurations where RemoteIpAddress
may not be set at all.
This commit is contained in:
copilot-swe-agent[bot]
2026-05-12 20:01:20 +00:00
committed by GitHub
Unverified
parent 267382f7b4
commit 9d047e3a8c
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dotnet/src/Microsoft.Agents.AI.DevUI/DevUIAuthFilter.cs
+4 -1
View File
@@ -47,7 +47,10 @@ internal sealed class DevUIAuthFilter : IEndpointFilter
{
var httpContext = context.HttpContext;
var remoteIp = httpContext.Connection.RemoteIpAddress;
var isLoopback = remoteIp is not null && IPAddress.IsLoopback(remoteIp);
// A null RemoteIpAddress means the connection is in-process (e.g., an ASP.NET Core
// TestServer created via UseTestServer()), so treat it as loopback.
var isLoopback = remoteIp is null || IPAddress.IsLoopback(remoteIp);
if (!isLoopback && !this._options.AllowRemoteAccess)
{