mirror of
https://github.com/microsoft/agent-framework.git
synced 2026-06-16 21:04:09 +08:00
problem: cannot operate with message store without any context
This commit is contained in:
Korolev Dmitry
@@ -6,6 +6,7 @@ using AgentWebChat.AgentHost.Custom;
|
||||
using AgentWebChat.AgentHost.Utilities;
|
||||
using Microsoft.Agents.AI;
|
||||
using Microsoft.Agents.AI.Hosting;
|
||||
using Microsoft.Agents.AI.Hosting.OpenAI.Conversations;
|
||||
using Microsoft.Agents.AI.Workflows;
|
||||
using Microsoft.Extensions.AI;
|
||||
|
||||
@@ -21,6 +22,17 @@ builder.Services.AddProblemDetails();
|
||||
// Configure the chat model and our agent.
|
||||
builder.AddKeyedChatClient("chat-model");
|
||||
|
||||
var testAgent = builder.AddAIAgent("problemCheck", (sp, name) =>
|
||||
{
|
||||
var chatClient = sp.GetRequiredKeyedService<IChatClient>("chat-model");
|
||||
return new ChatClientAgent(chatClient, options: new()
|
||||
{
|
||||
ChatMessageStoreFactory = ctx => new ConversationAgentThreadStore(ctx),
|
||||
Name = "problemCheck",
|
||||
Instructions = "You need to state a problem and fix it!"
|
||||
});
|
||||
});
|
||||
|
||||
var pirateAgentBuilder = builder.AddAIAgent(
|
||||
"pirate",
|
||||
instructions: "You are a pirate. Speak like a pirate",
|
||||
|
||||
+80
@@ -0,0 +1,80 @@
|
||||
// Copyright (c) Microsoft. All rights reserved.
|
||||
|
||||
using System.Collections.Generic;
|
||||
using System.Linq;
|
||||
using System.Text.Json;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
using Microsoft.Agents.AI.Hosting.OpenAI.Models;
|
||||
using Microsoft.Agents.AI.Hosting.OpenAI.Responses;
|
||||
using Microsoft.Agents.AI.Hosting.OpenAI.Responses.Converters;
|
||||
using Microsoft.Agents.AI.Hosting.OpenAI.Responses.Models;
|
||||
using Microsoft.Extensions.AI;
|
||||
using static Microsoft.Agents.AI.ChatClientAgentOptions;
|
||||
|
||||
namespace Microsoft.Agents.AI.Hosting.OpenAI.Conversations;
|
||||
|
||||
/// <summary>
|
||||
/// Implements ChatMessageStore for managing messages within a conversation thread using IConversationStorage.
|
||||
/// </summary>
|
||||
public class ConversationAgentThreadStore : ChatMessageStore
|
||||
{
|
||||
private readonly IConversationStorage _conversationStorage;
|
||||
|
||||
#pragma warning disable IDE0052 // Remove unread private members
|
||||
private readonly ChatMessageStoreFactoryContext _ctx;
|
||||
#pragma warning restore IDE0052 // Remove unread private members
|
||||
|
||||
/// <summary>
|
||||
/// constructs
|
||||
/// </summary>
|
||||
public ConversationAgentThreadStore(ChatMessageStoreFactoryContext ctx)
|
||||
: this(ctx, new InMemoryConversationStorage())
|
||||
{
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Constructs
|
||||
/// </summary>
|
||||
internal ConversationAgentThreadStore(ChatMessageStoreFactoryContext ctx, IConversationStorage conversationStorage)
|
||||
{
|
||||
this._conversationStorage = conversationStorage;
|
||||
this._ctx = ctx;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// add
|
||||
/// </summary>
|
||||
public override Task AddMessagesAsync(IEnumerable<ChatMessage> messages, CancellationToken cancellationToken = default)
|
||||
{
|
||||
// missing responseId, conversationId
|
||||
|
||||
//var idGenerator = new IdGenerator(responseId: ..., conversationId: ...);
|
||||
var idGenerator = new IdGenerator(responseId: "1", conversationId: "2");
|
||||
|
||||
var items = messages.SelectMany(x => x.ToItemResource(idGenerator, OpenAIHostingJsonUtilities.DefaultOptions));
|
||||
|
||||
return this._conversationStorage.AddItemsAsync(conversationId: "2", items, cancellationToken);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// get
|
||||
/// </summary>
|
||||
public override async Task<IEnumerable<ChatMessage>> GetMessagesAsync(CancellationToken cancellationToken = default)
|
||||
{
|
||||
// missing conversationId
|
||||
|
||||
ListResponse<ItemResource> items = await this._conversationStorage.ListItemsAsync(conversationId: "2", cancellationToken: cancellationToken).ConfigureAwait(false);
|
||||
return items.Data.Select(x => x.ToChatMessage());
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// serialize
|
||||
/// </summary>
|
||||
public override JsonElement Serialize(JsonSerializerOptions? jsonSerializerOptions = null)
|
||||
{
|
||||
// no conversationId. What can be even done here?
|
||||
|
||||
return JsonDocument.Parse("{}").RootElement;
|
||||
}
|
||||
}
|
||||
+344
@@ -0,0 +1,344 @@
|
||||
// Copyright (c) Microsoft. All rights reserved.
|
||||
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Linq;
|
||||
using System.Text.Json;
|
||||
using Microsoft.Agents.AI.Hosting.OpenAI.Responses.Models;
|
||||
using Microsoft.Extensions.AI;
|
||||
|
||||
namespace Microsoft.Agents.AI.Hosting.OpenAI.Responses.Converters;
|
||||
|
||||
/// <summary>
|
||||
/// Extension methods for converting between ItemResource and ChatMessage.
|
||||
/// </summary>
|
||||
internal static class ItemResourceExtensions
|
||||
{
|
||||
/// <summary>
|
||||
/// Converts an ItemResource to a ChatMessage.
|
||||
/// </summary>
|
||||
/// <param name="itemResource">The ItemResource to convert.</param>
|
||||
/// <returns>A ChatMessage.</returns>
|
||||
/// <exception cref="NotSupportedException">Thrown when the ItemResource type is not supported for conversion to ChatMessage.</exception>
|
||||
public static ChatMessage ToChatMessage(this ItemResource itemResource)
|
||||
{
|
||||
if (itemResource is ResponsesMessageItemResource messageItem)
|
||||
{
|
||||
var content = messageItem switch
|
||||
{
|
||||
ResponsesAssistantMessageItemResource assistant => assistant.Content,
|
||||
ResponsesUserMessageItemResource user => user.Content,
|
||||
ResponsesSystemMessageItemResource system => system.Content,
|
||||
ResponsesDeveloperMessageItemResource developer => developer.Content,
|
||||
_ => throw new NotSupportedException($"Message item type {messageItem.GetType().Name} not supported")
|
||||
};
|
||||
|
||||
// Convert ItemContent to AIContent using the existing converter
|
||||
var aiContents = content
|
||||
.Select(ItemContentConverter.ToAIContent)
|
||||
.Where(c => c is not null)
|
||||
.ToList();
|
||||
return new ChatMessage(messageItem.Role, aiContents!);
|
||||
}
|
||||
|
||||
if (itemResource is FunctionToolCallItemResource functionCall)
|
||||
{
|
||||
return new ChatMessage(ChatRole.Assistant, [
|
||||
functionCall.ToFunctionCallContent()
|
||||
]);
|
||||
}
|
||||
|
||||
if (itemResource is FunctionToolCallOutputItemResource functionOutput)
|
||||
{
|
||||
return new ChatMessage(ChatRole.Tool, [
|
||||
functionOutput.ToFunctionResultContent()
|
||||
]);
|
||||
}
|
||||
|
||||
throw new NotSupportedException($"ItemResource type {itemResource.GetType().Name} not supported for conversion to ChatMessage");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Converts a ChatMessage to ItemResource objects.
|
||||
/// This method requires an IdGenerator to create unique IDs for the generated resources.
|
||||
/// </summary>
|
||||
/// <param name="message">The chat message to convert.</param>
|
||||
/// <param name="idGenerator">The ID generator to use for creating IDs.</param>
|
||||
/// <param name="jsonSerializerOptions">The JSON serializer options to use.</param>
|
||||
/// <returns>An enumerable of ItemResource objects.</returns>
|
||||
public static IEnumerable<ItemResource> ToItemResources(this ChatMessage message, IdGenerator idGenerator, JsonSerializerOptions jsonSerializerOptions)
|
||||
{
|
||||
return message.ToItemResource(idGenerator, jsonSerializerOptions);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Converts a ChatMessage to a single ItemResource (message type) when it contains only message content.
|
||||
/// For messages with function calls, use ToItemResources instead.
|
||||
/// </summary>
|
||||
/// <param name="message">The chat message to convert.</param>
|
||||
/// <param name="id">The ID to assign to the message resource.</param>
|
||||
/// <returns>A ResponsesMessageItemResource.</returns>
|
||||
/// <exception cref="InvalidOperationException">Thrown when the message contains function calls or function results.</exception>
|
||||
public static ResponsesMessageItemResource ToMessageItemResource(this ChatMessage message, string id)
|
||||
{
|
||||
// Check if the message contains function calls or function results
|
||||
if (message.Contents.Any(c => c is FunctionCallContent or FunctionResultContent))
|
||||
{
|
||||
throw new InvalidOperationException("Cannot convert a ChatMessage with function calls or function results to a single MessageItemResource. Use ToItemResources instead.");
|
||||
}
|
||||
|
||||
// Convert all contents to ItemContent
|
||||
var contents = message.Contents
|
||||
.Select(ItemContentConverter.ToItemContent)
|
||||
.Where(c => c is not null)
|
||||
.ToList();
|
||||
|
||||
// Create the appropriate message item resource based on role
|
||||
return message.Role.Value switch
|
||||
{
|
||||
"assistant" => new ResponsesAssistantMessageItemResource
|
||||
{
|
||||
Id = id,
|
||||
Status = ResponsesMessageItemResourceStatus.Completed,
|
||||
Content = contents!
|
||||
},
|
||||
"user" => new ResponsesUserMessageItemResource
|
||||
{
|
||||
Id = id,
|
||||
Status = ResponsesMessageItemResourceStatus.Completed,
|
||||
Content = contents!
|
||||
},
|
||||
"system" => new ResponsesSystemMessageItemResource
|
||||
{
|
||||
Id = id,
|
||||
Status = ResponsesMessageItemResourceStatus.Completed,
|
||||
Content = contents!
|
||||
},
|
||||
"developer" => new ResponsesDeveloperMessageItemResource
|
||||
{
|
||||
Id = id,
|
||||
Status = ResponsesMessageItemResourceStatus.Completed,
|
||||
Content = contents!
|
||||
},
|
||||
_ => new ResponsesAssistantMessageItemResource
|
||||
{
|
||||
Id = id,
|
||||
Status = ResponsesMessageItemResourceStatus.Completed,
|
||||
Content = contents!
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Converts multiple ItemResources to ChatMessages.
|
||||
/// Adjacent message items with the same role will be combined into a single ChatMessage.
|
||||
/// </summary>
|
||||
/// <param name="itemResources">The ItemResources to convert.</param>
|
||||
/// <returns>An enumerable of ChatMessages.</returns>
|
||||
public static IEnumerable<ChatMessage> ToChatMessages(this IEnumerable<ItemResource> itemResources)
|
||||
{
|
||||
ChatMessage? currentMessage = null;
|
||||
var currentContents = new List<AIContent>();
|
||||
|
||||
foreach (var item in itemResources)
|
||||
{
|
||||
if (item is ResponsesMessageItemResource messageItem)
|
||||
{
|
||||
// Check if we should start a new message or continue the current one
|
||||
if (currentMessage is not null && currentMessage.Role != messageItem.Role)
|
||||
{
|
||||
// Yield the current message and start a new one
|
||||
yield return new ChatMessage(currentMessage.Role, [.. currentContents]);
|
||||
currentContents = [];
|
||||
}
|
||||
|
||||
// Add contents from this message item
|
||||
var aiContents = messageItem switch
|
||||
{
|
||||
ResponsesAssistantMessageItemResource assistant => assistant.Content,
|
||||
ResponsesUserMessageItemResource user => user.Content,
|
||||
ResponsesSystemMessageItemResource system => system.Content,
|
||||
ResponsesDeveloperMessageItemResource developer => developer.Content,
|
||||
_ => []
|
||||
};
|
||||
|
||||
foreach (var content in aiContents)
|
||||
{
|
||||
if (ItemContentConverter.ToAIContent(content) is { } aiContent)
|
||||
{
|
||||
currentContents.Add(aiContent);
|
||||
}
|
||||
}
|
||||
|
||||
// Initialize or update current message
|
||||
currentMessage = new ChatMessage(messageItem.Role, [.. currentContents]);
|
||||
}
|
||||
else if (item is FunctionToolCallItemResource functionCall)
|
||||
{
|
||||
// Function calls are always from assistant
|
||||
if (currentMessage is not null && currentMessage.Role != ChatRole.Assistant)
|
||||
{
|
||||
yield return new ChatMessage(currentMessage.Role, [.. currentContents]);
|
||||
currentContents = [];
|
||||
currentMessage = null;
|
||||
}
|
||||
|
||||
currentContents.Add(functionCall.ToFunctionCallContent());
|
||||
currentMessage = new ChatMessage(ChatRole.Assistant, [.. currentContents]);
|
||||
}
|
||||
else if (item is FunctionToolCallOutputItemResource functionOutput)
|
||||
{
|
||||
// Function outputs are always from tool role
|
||||
if (currentMessage is not null && currentMessage.Role != ChatRole.Tool)
|
||||
{
|
||||
yield return new ChatMessage(currentMessage.Role, [.. currentContents]);
|
||||
currentContents = [];
|
||||
currentMessage = null;
|
||||
}
|
||||
|
||||
currentContents.Add(functionOutput.ToFunctionResultContent());
|
||||
currentMessage = new ChatMessage(ChatRole.Tool, [.. currentContents]);
|
||||
}
|
||||
}
|
||||
|
||||
// Yield the last message if any
|
||||
if (currentMessage is not null && currentContents.Count > 0)
|
||||
{
|
||||
yield return new ChatMessage(currentMessage.Role, [.. currentContents]);
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Converts a FunctionToolCallItemResource to FunctionCallContent.
|
||||
/// Uses the official Microsoft.Extensions.AI pattern via CreateFromParsedArguments to properly handle parsing errors.
|
||||
/// </summary>
|
||||
/// <param name="functionCall">The function call item resource to convert.</param>
|
||||
/// <returns>A FunctionCallContent with properly parsed arguments. If parsing fails, the Exception property will be set.</returns>
|
||||
public static FunctionCallContent ToFunctionCallContent(this FunctionToolCallItemResource functionCall)
|
||||
{
|
||||
// Use the same pattern as Microsoft.Extensions.AI.OpenAI's ParseCallContent method
|
||||
// This properly handles parsing errors by setting the Exception property on FunctionCallContent
|
||||
return FunctionCallContent.CreateFromParsedArguments(
|
||||
functionCall.Arguments ?? "{}",
|
||||
functionCall.CallId,
|
||||
functionCall.Name,
|
||||
static json => (IDictionary<string, object?>)JsonSerializer.Deserialize(json, OpenAIHostingJsonUtilities.DefaultOptions.GetTypeInfo(typeof(IDictionary<string, object?>)))!);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Converts a FunctionToolCallOutputItemResource to FunctionResultContent.
|
||||
/// </summary>
|
||||
/// <param name="functionOutput">The function output item resource to convert.</param>
|
||||
/// <returns>A FunctionResultContent.</returns>
|
||||
public static FunctionResultContent ToFunctionResultContent(this FunctionToolCallOutputItemResource functionOutput)
|
||||
{
|
||||
return new FunctionResultContent(functionOutput.CallId, functionOutput.Output);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Converts a ChatMessage to ItemParam objects (input models without IDs).
|
||||
/// This is useful for creating items in the Conversations API.
|
||||
/// Filters out events that don't map well to ItemParams (e.g., messages with no convertible content).
|
||||
/// </summary>
|
||||
/// <param name="message">The chat message to convert.</param>
|
||||
/// <returns>An enumerable of ItemParam objects.</returns>
|
||||
public static IEnumerable<ItemParam> ToItemParams(this ChatMessage message)
|
||||
{
|
||||
// Separate function call/result contents from regular message contents
|
||||
foreach (AIContent content in message.Contents)
|
||||
{
|
||||
switch (content)
|
||||
{
|
||||
case FunctionCallContent functionCallContent:
|
||||
yield return new FunctionToolCallItemParam
|
||||
{
|
||||
CallId = functionCallContent.CallId,
|
||||
Name = functionCallContent.Name,
|
||||
Arguments = JsonSerializer.Serialize(
|
||||
functionCallContent.Arguments,
|
||||
OpenAIHostingJsonUtilities.DefaultOptions.GetTypeInfo(typeof(IDictionary<string, object?>)))
|
||||
};
|
||||
break;
|
||||
|
||||
case FunctionResultContent functionResultContent:
|
||||
string output = functionResultContent.Exception is not null
|
||||
? $"{functionResultContent.Exception.GetType().Name}(\"{functionResultContent.Exception.Message}\")"
|
||||
: $"{functionResultContent.Result?.ToString() ?? "(null)"}";
|
||||
yield return new FunctionToolCallOutputItemParam
|
||||
{
|
||||
CallId = functionResultContent.CallId,
|
||||
Output = output
|
||||
};
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
// Convert regular message contents
|
||||
List<ItemContent> regularContents = [];
|
||||
foreach (AIContent content in message.Contents)
|
||||
{
|
||||
if (content is not FunctionCallContent and not FunctionResultContent &&
|
||||
ItemContentConverter.ToItemContent(content) is { } itemContent)
|
||||
{
|
||||
regularContents.Add(itemContent);
|
||||
}
|
||||
}
|
||||
|
||||
// Only create a message item if we have convertible contents
|
||||
// This filters out messages that contain only non-convertible content (e.g., UsageContent)
|
||||
if (regularContents.Count > 0)
|
||||
{
|
||||
InputMessageContent messageContent = InputMessageContent.FromContents(regularContents);
|
||||
|
||||
yield return message.Role.Value.ToUpperInvariant() switch
|
||||
{
|
||||
"USER" => new ResponsesUserMessageItemParam { Content = messageContent },
|
||||
"ASSISTANT" => new ResponsesAssistantMessageItemParam { Content = messageContent },
|
||||
"SYSTEM" => new ResponsesSystemMessageItemParam { Content = messageContent },
|
||||
"DEVELOPER" => new ResponsesDeveloperMessageItemParam { Content = messageContent },
|
||||
_ => new ResponsesUserMessageItemParam { Content = messageContent }
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Converts a ChatMessage to a single ItemParam (message type) when it contains only message content.
|
||||
/// For messages with function calls, use ToItemParams instead.
|
||||
/// </summary>
|
||||
/// <param name="message">The chat message to convert.</param>
|
||||
/// <returns>A ResponsesMessageItemParam.</returns>
|
||||
/// <exception cref="InvalidOperationException">Thrown when the message contains function calls or function results.</exception>
|
||||
public static ResponsesMessageItemParam ToMessageItemParam(this ChatMessage message)
|
||||
{
|
||||
// Check if the message contains function calls or function results
|
||||
if (message.Contents.Any(c => c is FunctionCallContent or FunctionResultContent))
|
||||
{
|
||||
throw new InvalidOperationException("Cannot convert a ChatMessage with function calls or function results to a single MessageItemParam. Use ToItemParams instead.");
|
||||
}
|
||||
|
||||
// Convert all contents to ItemContent
|
||||
List<ItemContent> contents = [];
|
||||
foreach (AIContent content in message.Contents)
|
||||
{
|
||||
if (ItemContentConverter.ToItemContent(content) is { } itemContent)
|
||||
{
|
||||
contents.Add(itemContent);
|
||||
}
|
||||
}
|
||||
|
||||
// Create InputMessageContent
|
||||
InputMessageContent messageContent = contents.Count > 0
|
||||
? InputMessageContent.FromContents(contents)
|
||||
: InputMessageContent.FromText(message.Text ?? string.Empty);
|
||||
|
||||
// Create the appropriate message item param based on role
|
||||
return message.Role.Value.ToUpperInvariant() switch
|
||||
{
|
||||
"USER" => new ResponsesUserMessageItemParam { Content = messageContent },
|
||||
"ASSISTANT" => new ResponsesAssistantMessageItemParam { Content = messageContent },
|
||||
"SYSTEM" => new ResponsesSystemMessageItemParam { Content = messageContent },
|
||||
"DEVELOPER" => new ResponsesDeveloperMessageItemParam { Content = messageContent },
|
||||
_ => new ResponsesUserMessageItemParam { Content = messageContent }
|
||||
};
|
||||
}
|
||||
}
|
||||
@@ -22,7 +22,6 @@ internal sealed class InMemoryResponsesService : IResponsesService, IDisposable
|
||||
private readonly IResponseExecutor _executor;
|
||||
private readonly MemoryCache _cache;
|
||||
private readonly InMemoryStorageOptions _options;
|
||||
private readonly Conversations.IConversationStorage? _conversationStorage;
|
||||
|
||||
private sealed class ResponseState
|
||||
{
|
||||
@@ -144,7 +143,6 @@ internal sealed class InMemoryResponsesService : IResponsesService, IDisposable
|
||||
this._executor = executor;
|
||||
this._options = options;
|
||||
this._cache = new MemoryCache(options.ToMemoryCacheOptions());
|
||||
this._conversationStorage = conversationStorage;
|
||||
}
|
||||
|
||||
public async ValueTask<ResponseError?> ValidateRequestAsync(
|
||||
@@ -440,21 +438,6 @@ internal sealed class InMemoryResponsesService : IResponsesService, IDisposable
|
||||
}
|
||||
}
|
||||
|
||||
// Add both input and output items to conversation storage if available
|
||||
// This happens AFTER successful execution, in line with OpenAI's behavior
|
||||
if (this._conversationStorage is not null && request.Conversation?.Id is not null)
|
||||
{
|
||||
var inputItems = GetInputItems(responseId, state);
|
||||
var allItems = new List<ItemResource>(inputItems.Count + outputItems.Count);
|
||||
allItems.AddRange(inputItems);
|
||||
allItems.AddRange(outputItems);
|
||||
|
||||
if (allItems.Count > 0)
|
||||
{
|
||||
await this._conversationStorage.AddItemsAsync(request.Conversation.Id, allItems, linkedCts.Token).ConfigureAwait(false);
|
||||
}
|
||||
}
|
||||
|
||||
// Update response status to completed if not already in a terminal state
|
||||
if (!state.IsTerminal)
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user