From fb0816b2c5c0bb19d0b7a7631b130cd09d9de76c Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Sat, 27 Jul 2024 18:20:40 +0800
Subject: [PATCH 1/3] feat: focus dialog after showing modal

---
 src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs | 1 +
 src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs | 2 ++
 src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs   | 1 +
 3 files changed, 4 insertions(+)

diff --git a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs
index 5fc4741..7614624 100644
--- a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs
+++ b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs
@@ -173,6 +173,7 @@ public partial class OverlayDialogHost
         _modalCount++;
         IsInModalStatus = _modalCount > 0;
         control.IsClosed = false;
+        control.Focus();
     }
 
     // Handle dialog layer change event
diff --git a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs
index 15e0cd6..074c1ca 100644
--- a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs
+++ b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs
@@ -67,6 +67,8 @@ public partial class OverlayDialogHost
         {
             await Task.WhenAll(animation.RunAsync(control), _maskAppearAnimation.RunAsync(mask));
         }
+
+        control.Focus();
     }
 
     private void SetDrawerPosition(DrawerControlBase control)
diff --git a/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs b/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs
index 3daa31e..e8103cb 100644
--- a/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs
+++ b/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs
@@ -20,6 +20,7 @@ public abstract class OverlayFeedbackElement: ContentControl
     
     static OverlayFeedbackElement()
     {
+        FocusableProperty.OverrideDefaultValue<OverlayFeedbackElement>(true);
         DataContextProperty.Changed.AddClassHandler<OverlayFeedbackElement, object?>((o, e) => o.OnDataContextChange(e));
         ClosedEvent.AddClassHandler<OverlayFeedbackElement>((o,e)=>o.OnClosed(e));
     }

From 36aa3b9dec8bea49e2a938abe62969fdf66018f4 Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Sun, 1 Sep 2024 16:26:43 +0800
Subject: [PATCH 2/3] feat: try to focus on dialog and make tab navigation
 cycled.

---
 src/Ursa.Themes.Semi/Controls/Dialog.axaml                 | 2 ++
 src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml             | 4 +++-
 src/Ursa/Controls/Dialog/OverlayDialog.cs                  | 7 +++++++
 .../Controls/OverlayShared/OverlayDialogHost.Dialog.cs     | 4 ++++
 src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs  | 2 +-
 5 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/Ursa.Themes.Semi/Controls/Dialog.axaml b/src/Ursa.Themes.Semi/Controls/Dialog.axaml
index 33ae22e..9f13f46 100644
--- a/src/Ursa.Themes.Semi/Controls/Dialog.axaml
+++ b/src/Ursa.Themes.Semi/Controls/Dialog.axaml
@@ -19,6 +19,7 @@
             <ControlTemplate TargetType="u:CustomDialogControl">
                 <Border
                     Name="PART_Border"
+                    Focusable="True"
                     Padding="0"
                     HorizontalAlignment="Center"
                     VerticalAlignment="Center"
@@ -152,6 +153,7 @@
                 <Border
                     Name="PART_Border"
                     Padding="0"
+                    Focusable="True"
                     HorizontalAlignment="{TemplateBinding HorizontalAlignment}"
                     VerticalAlignment="{TemplateBinding VerticalAlignment}"
                     BoxShadow="0 0 8 0 #1A000000"
diff --git a/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml b/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml
index 3487f47..216f7a8 100644
--- a/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml
+++ b/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml
@@ -65,7 +65,9 @@
                                 Margin="{Binding $parent[u:UrsaWindow].TitleBarMargin}"
                                 LeftContent="{Binding $parent[u:UrsaWindow].LeftContent}"
                                 RightContent="{Binding $parent[u:UrsaWindow].RightContent}" />
-                            <u:OverlayDialogHost IsModalStatusReporter="True" />
+                            <VisualLayerManager>
+                                <u:OverlayDialogHost IsModalStatusReporter="True" />
+                            </VisualLayerManager>
                         </VisualLayerManager.ChromeOverlayLayer>
                         <Panel>
                             <ContentPresenter
diff --git a/src/Ursa/Controls/Dialog/OverlayDialog.cs b/src/Ursa/Controls/Dialog/OverlayDialog.cs
index 28ed9e3..cdbeed2 100644
--- a/src/Ursa/Controls/Dialog/OverlayDialog.cs
+++ b/src/Ursa/Controls/Dialog/OverlayDialog.cs
@@ -1,5 +1,6 @@
 using Avalonia;
 using Avalonia.Controls;
+using Avalonia.Input;
 using Avalonia.Layout;
 
 namespace Ursa.Controls;
@@ -93,6 +94,7 @@ public static class OverlayDialog
         {
             Content = view,
             DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureCustomDialogControl(t, options);
         host.AddDialog(t);
@@ -108,6 +110,7 @@ public static class OverlayDialog
         {
             Content = new TView(),
             DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureDefaultDialogControl(t, options);
         host.AddModalDialog(t);
@@ -123,6 +126,7 @@ public static class OverlayDialog
         {
             Content = control,
             DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureDefaultDialogControl(t, options);
         host.AddModalDialog(t);
@@ -139,6 +143,7 @@ public static class OverlayDialog
         {
             Content = new TView(),
             DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureCustomDialogControl(t, options);
         host.AddModalDialog(t);
@@ -154,6 +159,7 @@ public static class OverlayDialog
         {
             Content = control,
             DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureCustomDialogControl(t, options);
         host.AddModalDialog(t);
@@ -172,6 +178,7 @@ public static class OverlayDialog
         {
             Content = view,
             DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureCustomDialogControl(t, options);
         host.AddModalDialog(t);
diff --git a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs
index 7614624..0368aec 100644
--- a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs
+++ b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Dialog.cs
@@ -1,5 +1,6 @@
 using Avalonia;
 using Avalonia.Input;
+using Avalonia.VisualTree;
 using Irihi.Avalonia.Shared.Helpers;
 using Irihi.Avalonia.Shared.Shapes;
 using Ursa.Controls.OverlayShared;
@@ -170,6 +171,9 @@ public partial class OverlayDialogHost
         {
             _maskAppearAnimation.RunAsync(mask);
         }
+
+        var element = control.GetVisualDescendants().OfType<InputElement>().FirstOrDefault(a => a.Focusable);
+        element?.Focus();
         _modalCount++;
         IsInModalStatus = _modalCount > 0;
         control.IsClosed = false;
diff --git a/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs b/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs
index e8103cb..50cc65a 100644
--- a/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs
+++ b/src/Ursa/Controls/OverlayShared/OverlayFeedbackElement.cs
@@ -20,7 +20,7 @@ public abstract class OverlayFeedbackElement: ContentControl
     
     static OverlayFeedbackElement()
     {
-        FocusableProperty.OverrideDefaultValue<OverlayFeedbackElement>(true);
+        FocusableProperty.OverrideDefaultValue<OverlayFeedbackElement>(false);
         DataContextProperty.Changed.AddClassHandler<OverlayFeedbackElement, object?>((o, e) => o.OnDataContextChange(e));
         ClosedEvent.AddClassHandler<OverlayFeedbackElement>((o,e)=>o.OnClosed(e));
     }

From abe42fc189154d1a06326bc0e86b74ca16a72fe3 Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Tue, 3 Sep 2024 17:05:33 +0800
Subject: [PATCH 3/3] fix: fix navigation issue for messagebox and drawer.

---
 src/Ursa.Themes.Semi/Controls/Drawer.axaml    |  2 ++
 .../Controls/MessageBox.axaml                 | 12 +++++++-----
 src/Ursa/Controls/Drawer/Drawer.cs            | 19 +++++++++++++------
 src/Ursa/Controls/MessageBox/MessageBox.cs    |  4 +++-
 .../OverlayShared/OverlayDialogHost.Drawer.cs |  6 ++++--
 5 files changed, 29 insertions(+), 14 deletions(-)

diff --git a/src/Ursa.Themes.Semi/Controls/Drawer.axaml b/src/Ursa.Themes.Semi/Controls/Drawer.axaml
index b013000..66bb9d9 100644
--- a/src/Ursa.Themes.Semi/Controls/Drawer.axaml
+++ b/src/Ursa.Themes.Semi/Controls/Drawer.axaml
@@ -11,6 +11,7 @@
         <Setter Property="Template">
             <ControlTemplate TargetType="u:CustomDrawerControl">
                 <Border Name="PART_Root" 
+                        Focusable="True"
                         Margin="{TemplateBinding Padding, Converter={x:Static c:ThicknessTakeConverter.Left}}"
                         Padding="0"
                         HorizontalAlignment="Stretch"
@@ -77,6 +78,7 @@
         <Setter Property="Template">
             <ControlTemplate TargetType="u:DefaultDrawerControl">
                 <Border Name="PART_Root" 
+                        Focusable="True"
                         Margin="{TemplateBinding Padding, Converter={x:Static c:ThicknessTakeConverter.Left}}"
                         Padding="0"
                         HorizontalAlignment="Stretch"
diff --git a/src/Ursa.Themes.Semi/Controls/MessageBox.axaml b/src/Ursa.Themes.Semi/Controls/MessageBox.axaml
index 396f3bc..710737a 100644
--- a/src/Ursa.Themes.Semi/Controls/MessageBox.axaml
+++ b/src/Ursa.Themes.Semi/Controls/MessageBox.axaml
@@ -33,9 +33,9 @@
                     <Border Name="PART_TransparencyFallback" IsHitTestVisible="False" />
                     <Border Background="{TemplateBinding Background}" IsHitTestVisible="False" />
                     <Panel Margin="{TemplateBinding WindowDecorationMargin}" Background="Transparent" />
-                    <ChromeOverlayLayer />
-                    <Grid RowDefinitions="Auto, *, Auto">
-                        <Grid
+                    <VisualLayerManager>
+                        <Grid RowDefinitions="Auto, *, Auto">
+                            <Grid
                             Grid.Row="0"
                             Margin="24,24,24,0"
                             ColumnDefinitions="Auto, *, Auto">
@@ -61,7 +61,7 @@
                                 Grid.Column="2"
                                 Theme="{DynamicResource CloseButton}" />
                         </Grid>
-                        <Grid
+                            <Grid
                             Grid.Row="1"
                             MaxWidth="{DynamicResource MessageBoxWindowContentMaxWidth}"
                             Margin="{TemplateBinding Padding}"
@@ -79,7 +79,7 @@
                                     TextWrapping="Wrap" />
                             </ScrollViewer>
                         </Grid>
-                        <StackPanel
+                            <StackPanel
                             Grid.Row="2"
                             Margin="24,0,24,24"
                             HorizontalAlignment="Right"
@@ -109,6 +109,7 @@
                                 Theme="{DynamicResource SolidButton}" />
                         </StackPanel>
                     </Grid>
+                    </VisualLayerManager>
                 </Panel>
             </ControlTemplate>
         </Setter>
@@ -155,6 +156,7 @@
             <ControlTemplate TargetType="u:MessageBoxControl">
                 <Border
                     Padding="0"
+                    Focusable="True"
                     HorizontalAlignment="Center"
                     VerticalAlignment="Center"
                     Classes="Shadow"
diff --git a/src/Ursa/Controls/Drawer/Drawer.cs b/src/Ursa/Controls/Drawer/Drawer.cs
index 942601a..b8044c4 100644
--- a/src/Ursa/Controls/Drawer/Drawer.cs
+++ b/src/Ursa/Controls/Drawer/Drawer.cs
@@ -1,5 +1,6 @@
 using Avalonia;
 using Avalonia.Controls;
+using Avalonia.Input;
 using Ursa.Common;
 using Ursa.Controls.Options;
 
@@ -60,7 +61,8 @@ public static class Drawer
         var drawer = new DefaultDrawerControl
         {
             Content = new TView(),
-            DataContext = vm
+            DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureDefaultDrawer(drawer, options);
         host.AddModalDrawer(drawer);
@@ -75,7 +77,8 @@ public static class Drawer
         var drawer = new DefaultDrawerControl
         {
             Content = control,
-            DataContext = vm
+            DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureDefaultDrawer(drawer, options);
         host.AddModalDrawer(drawer);
@@ -92,7 +95,8 @@ public static class Drawer
         var drawer = new DefaultDrawerControl
         {
             Content = view,
-            DataContext = vm
+            DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureDefaultDrawer(drawer, options);
         host.AddModalDrawer(drawer);
@@ -152,7 +156,8 @@ public static class Drawer
         var dialog = new CustomDrawerControl
         {
             Content = new TView(),
-            DataContext = vm
+            DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureCustomDrawer(dialog, options);
         host.AddModalDrawer(dialog);
@@ -167,7 +172,8 @@ public static class Drawer
         var dialog = new CustomDrawerControl
         {
             Content = control,
-            DataContext = vm
+            DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureCustomDrawer(dialog, options);
         host.AddModalDrawer(dialog);
@@ -185,7 +191,8 @@ public static class Drawer
         var dialog = new CustomDrawerControl
         {
             Content = view,
-            DataContext = vm
+            DataContext = vm,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         ConfigureCustomDrawer(dialog, options);
         host.AddModalDrawer(dialog);
diff --git a/src/Ursa/Controls/MessageBox/MessageBox.cs b/src/Ursa/Controls/MessageBox/MessageBox.cs
index a9961bf..0e97665 100644
--- a/src/Ursa/Controls/MessageBox/MessageBox.cs
+++ b/src/Ursa/Controls/MessageBox/MessageBox.cs
@@ -1,6 +1,7 @@
 using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Controls.ApplicationLifetimes;
+using Avalonia.Input;
 
 namespace Ursa.Controls;
 
@@ -63,7 +64,8 @@ public static class MessageBox
             Content = message,
             Title = title,
             Buttons = button,
-            MessageIcon = icon
+            MessageIcon = icon,
+            [KeyboardNavigation.TabNavigationProperty] = KeyboardNavigationMode.Cycle
         };
         host.AddModalDialog(messageControl);
         var result = await messageControl.ShowAsync<MessageBoxResult>();
diff --git a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs
index 074c1ca..e6bec9d 100644
--- a/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs
+++ b/src/Ursa/Controls/OverlayShared/OverlayDialogHost.Drawer.cs
@@ -2,7 +2,9 @@ using Avalonia;
 using Avalonia.Animation;
 using Avalonia.Animation.Easings;
 using Avalonia.Controls;
+using Avalonia.Input;
 using Avalonia.Styling;
+using Avalonia.VisualTree;
 using Irihi.Avalonia.Shared.Shapes;
 using Ursa.Common;
 using Ursa.Controls.OverlayShared;
@@ -67,8 +69,8 @@ public partial class OverlayDialogHost
         {
             await Task.WhenAll(animation.RunAsync(control), _maskAppearAnimation.RunAsync(mask));
         }
-
-        control.Focus();
+        var element = control.GetVisualDescendants().OfType<InputElement>().FirstOrDefault(a => a.Focusable);
+        element?.Focus();
     }
 
     private void SetDrawerPosition(DrawerControlBase control)