From 74994e77f73ff9f70a47f89a848842cda34cf134 Mon Sep 17 00:00:00 2001
From: rabbitism <dongbin@irihi.tech>
Date: Wed, 14 Aug 2024 18:23:56 +0800
Subject: [PATCH] feat: make titlebar visible property actually useful.

---
 src/Ursa.Themes.Semi/Controls/UrsaView.axaml  | 32 +++++++++++++------
 .../Controls/UrsaWindow.axaml                 |  4 +++
 src/Ursa/Controls/TitleBar/TitleBar.cs        |  9 ++++++
 src/Ursa/Windows/UrsaWindow.cs                |  2 +-
 4 files changed, 37 insertions(+), 10 deletions(-)

diff --git a/src/Ursa.Themes.Semi/Controls/UrsaView.axaml b/src/Ursa.Themes.Semi/Controls/UrsaView.axaml
index 92c0989..fb7bb62 100644
--- a/src/Ursa.Themes.Semi/Controls/UrsaView.axaml
+++ b/src/Ursa.Themes.Semi/Controls/UrsaView.axaml
@@ -1,7 +1,8 @@
-<ResourceDictionary xmlns="https://github.com/avaloniaui"
-                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-                    xmlns:u="https://irihi.tech/ursa">
-    <!-- Add Resources Here -->
+<ResourceDictionary
+    xmlns="https://github.com/avaloniaui"
+    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+    xmlns:u="https://irihi.tech/ursa">
+    <!--  Add Resources Here  -->
     <ControlTheme x:Key="{x:Type u:UrsaView}" TargetType="{x:Type u:UrsaView}">
         <Setter Property="Background" Value="{DynamicResource WindowDefaultBackground}" />
         <Setter Property="Foreground" Value="{DynamicResource WindowDefaultForeground}" />
@@ -20,12 +21,25 @@
                             VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
                             Content="{TemplateBinding Content}"
                             ContentTemplate="{TemplateBinding ContentTemplate}" />
-                        <Grid ColumnDefinitions="Auto, *, Auto"
+                        <Grid
+                            Margin="{Binding $parent[u:UrsaWindow].TitleBarMargin}"
                             VerticalAlignment="Top"
-                            Margin="{Binding $parent[u:UrsaWindow].TitleBarMargin}">
-                            <ContentPresenter Grid.Column="0" Content="{TemplateBinding LeftContent}" VerticalAlignment="Center"/>
-                            <ContentPresenter Grid.Column="1" Content="{TemplateBinding TitleBarContent}" VerticalAlignment="Center"/>
-                            <ContentPresenter Grid.Column="2" Content="{TemplateBinding RightContent}" VerticalAlignment="Center"/>
+                            ColumnDefinitions="Auto, *, Auto">
+                            <ContentPresenter
+                                Grid.Column="0"
+                                VerticalAlignment="Center"
+                                IsVisible="{TemplateBinding IsTitleBarVisible}"
+                                Content="{TemplateBinding LeftContent}" />
+                            <ContentPresenter
+                                Grid.Column="1"
+                                VerticalAlignment="Center"
+                                IsVisible="{TemplateBinding IsTitleBarVisible}"
+                                Content="{TemplateBinding TitleBarContent}" />
+                            <ContentPresenter
+                                Grid.Column="2"
+                                VerticalAlignment="Center"
+                                IsVisible="{TemplateBinding IsTitleBarVisible}"
+                                Content="{TemplateBinding RightContent}" />
                         </Grid>
                         <u:OverlayDialogHost IsModalStatusReporter="True" />
                     </Panel>
diff --git a/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml b/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml
index ebe33e1..b651a88 100644
--- a/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml
+++ b/src/Ursa.Themes.Semi/Controls/UrsaWindow.axaml
@@ -60,6 +60,7 @@
                     <VisualLayerManager Padding="{TemplateBinding OffScreenMargin, Mode=OneWay}">
                         <VisualLayerManager.ChromeOverlayLayer>
                             <u:TitleBar
+                                IsTitleVisible="{TemplateBinding IsTitleBarVisible}"
                                 Content="{Binding $parent[u:UrsaWindow].TitleBarContent}"
                                 Margin="{Binding $parent[u:UrsaWindow].TitleBarMargin}"
                                 LeftContent="{Binding $parent[u:UrsaWindow].LeftContent}"
@@ -97,14 +98,17 @@
                             <ContentPresenter
                                 Grid.Column="0"
                                 VerticalAlignment="Center"
+                                IsVisible="{TemplateBinding IsTitleVisible}"
                                 Content="{TemplateBinding LeftContent}" />
                             <ContentPresenter
                                 Grid.Column="1"
                                 VerticalAlignment="Center"
+                                IsVisible="{TemplateBinding IsTitleVisible}"
                                 Content="{TemplateBinding Content}" />
                             <ContentPresenter
                                 Grid.Column="2"
                                 VerticalAlignment="Center"
+                                IsVisible="{TemplateBinding IsTitleVisible}"
                                 Content="{TemplateBinding RightContent}" />
                             <u:CaptionButtons
                                 x:Name="PART_CaptionButtons"
diff --git a/src/Ursa/Controls/TitleBar/TitleBar.cs b/src/Ursa/Controls/TitleBar/TitleBar.cs
index d06e921..278fc4b 100644
--- a/src/Ursa/Controls/TitleBar/TitleBar.cs
+++ b/src/Ursa/Controls/TitleBar/TitleBar.cs
@@ -29,6 +29,15 @@ public class TitleBar: ContentControl
         get => GetValue(RightContentProperty);
         set => SetValue(RightContentProperty, value);
     }
+
+    public static readonly StyledProperty<bool> IsTitleVisibleProperty = AvaloniaProperty.Register<TitleBar, bool>(
+        nameof(IsTitleVisible));
+
+    public bool IsTitleVisible
+    {
+        get => GetValue(IsTitleVisibleProperty);
+        set => SetValue(IsTitleVisibleProperty, value);
+    }
     
     protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
     {
diff --git a/src/Ursa/Windows/UrsaWindow.cs b/src/Ursa/Windows/UrsaWindow.cs
index a23ea2b..73ebd67 100644
--- a/src/Ursa/Windows/UrsaWindow.cs
+++ b/src/Ursa/Windows/UrsaWindow.cs
@@ -47,7 +47,7 @@ public class UrsaWindow: Window
     }
     
     public static readonly StyledProperty<bool> IsTitleBarVisibleProperty = AvaloniaProperty.Register<UrsaWindow, bool>(
-        nameof(IsTitleBarVisible));
+        nameof(IsTitleBarVisible), true);
     
     public bool IsTitleBarVisible
     {