From 9ffb8cc73627757234dca84ddfc6956d4c69261b Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Mon, 17 Jun 2024 16:21:34 +0800
Subject: [PATCH 1/2] fix: fix container selection state issue.

---
 src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs b/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs
index b56ae98..6850dfc 100644
--- a/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs
+++ b/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs
@@ -13,6 +13,7 @@ public class MultiComboBoxItem: ContentControl
     private MultiComboBox? _parent;
     private static readonly Point s_invalidPoint = new (double.NaN, double.NaN);
     private Point _pointerDownPoint = s_invalidPoint;
+    private bool _updateInternal;
     
     public static readonly StyledProperty<bool> IsSelectedProperty = AvaloniaProperty.Register<MultiComboBoxItem, bool>(
         nameof(IsSelected));
@@ -34,6 +35,7 @@ public class MultiComboBoxItem: ContentControl
 
     private void OnSelectionChanged(AvaloniaPropertyChangedEventArgs<bool> args)
     {
+        if (_updateInternal) return;
         var parent = this.FindLogicalAncestorOfType<MultiComboBox>();
         if (args.NewValue.Value)
         {
@@ -94,4 +96,15 @@ public class MultiComboBoxItem: ContentControl
             }
         }
     }
+
+    protected override void OnAttachedToVisualTree(VisualTreeAttachmentEventArgs e)
+    {
+        base.OnAttachedToVisualTree(e);
+        _updateInternal = true;
+        if (_parent?.ItemsPanelRoot is VirtualizingPanel)
+        {
+            IsSelected =  _parent?.SelectedItems?.Contains(DataContext) ?? false;
+        }
+        _updateInternal = false;
+    }
 }
\ No newline at end of file

From fd5db085bf4d8e1dbc793f93a3765147591ff7e3 Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Sun, 23 Jun 2024 17:47:13 +0800
Subject: [PATCH 2/2] feat: move close button position, fix selection items
 static reference.

---
 demo/Ursa.Demo/Pages/MultiComboBoxDemo.axaml      |  1 +
 src/Ursa.Themes.Semi/Controls/MultiComboBox.axaml | 15 ++++++++-------
 src/Ursa/Controls/ComboBox/MultiComboBox.cs       |  9 ++++++---
 src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs   |  3 ++-
 4 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/demo/Ursa.Demo/Pages/MultiComboBoxDemo.axaml b/demo/Ursa.Demo/Pages/MultiComboBoxDemo.axaml
index 9d94a94..7fe0008 100644
--- a/demo/Ursa.Demo/Pages/MultiComboBoxDemo.axaml
+++ b/demo/Ursa.Demo/Pages/MultiComboBoxDemo.axaml
@@ -17,6 +17,7 @@
             InnerLeftContent="Left"
             InnerRightContent="Right"
             Classes="ClearButton"
+            MaxHeight="200"
             ItemsSource="{Binding Items}" >
         </u:MultiComboBox>
         <ListBox ItemsSource="{Binding #combo.SelectedItems}" />
diff --git a/src/Ursa.Themes.Semi/Controls/MultiComboBox.axaml b/src/Ursa.Themes.Semi/Controls/MultiComboBox.axaml
index ff38168..df334e6 100644
--- a/src/Ursa.Themes.Semi/Controls/MultiComboBox.axaml
+++ b/src/Ursa.Themes.Semi/Controls/MultiComboBox.axaml
@@ -60,13 +60,6 @@
                                         </ItemsControl.ItemsPanel>
                                     </u:MultiComboBoxSelectedItemList>
                                 </ScrollViewer>
-                                <Button
-                                    Name="ClearButton"
-                                    Grid.Column="2"
-                                    Command="{Binding $parent[u:MultiComboBox].Clear}"
-                                    Content="{DynamicResource IconButtonClearData}"
-                                    IsVisible="False"
-                                    Theme="{DynamicResource InnerIconButton}" />
                                 <ContentPresenter
                                     Grid.Column="3"
                                     Margin="8,0"
@@ -84,10 +77,18 @@
                                     Margin="0,0,10,0"
                                     HorizontalAlignment="Right"
                                     VerticalAlignment="Center"
+                                    IsVisible="{Binding #ClearButton.IsVisible, Converter={x:Static BoolConverters.Not}}"
                                     Data="{DynamicResource ComboBoxIcon}"
                                     Foreground="{DynamicResource ComboBoxIconDefaultForeground}"
                                     IsHitTestVisible="False"
                                     UseLayoutRounding="False" />
+                                <Button
+                                    Name="ClearButton"
+                                    Grid.Column="4"
+                                    Command="{Binding $parent[u:MultiComboBox].Clear}"
+                                    Content="{DynamicResource IconButtonClearData}"
+                                    IsVisible="False"
+                                    Theme="{DynamicResource InnerIconButton}" />
                             </Grid>
                         </Border>
                         <Popup
diff --git a/src/Ursa/Controls/ComboBox/MultiComboBox.cs b/src/Ursa/Controls/ComboBox/MultiComboBox.cs
index 85620bf..83381a9 100644
--- a/src/Ursa/Controls/ComboBox/MultiComboBox.cs
+++ b/src/Ursa/Controls/ComboBox/MultiComboBox.cs
@@ -6,6 +6,7 @@ using Avalonia.Controls;
 using Avalonia.Controls.Metadata;
 using Avalonia.Controls.Primitives;
 using Avalonia.Controls.Templates;
+using Avalonia.Data.Converters;
 using Avalonia.Input;
 using Avalonia.Interactivity;
 using Avalonia.LogicalTree;
@@ -54,7 +55,7 @@ public class MultiComboBox: SelectingItemsControl, IInnerContentControl
     }
 
     public new static readonly StyledProperty<IList?> SelectedItemsProperty = AvaloniaProperty.Register<MultiComboBox, IList?>(
-        nameof(SelectedItems), new AvaloniaList<object>());
+        nameof(SelectedItems));
 
     public new IList? SelectedItems
     {
@@ -99,10 +100,12 @@ public class MultiComboBox: SelectingItemsControl, IInnerContentControl
 
     public MultiComboBox()
     {
+        SelectedItems = new AvaloniaList<object>();
         if (SelectedItems is INotifyCollectionChanged c)
         {
-            c.CollectionChanged+=OnSelectedItemsCollectionChanged;
+            c.CollectionChanged+= OnSelectedItemsCollectionChanged;
         }
+        
     }
 
     private void OnSelectedItemsChanged(AvaloniaPropertyChangedEventArgs<IList?> args)
@@ -117,7 +120,7 @@ public class MultiComboBox: SelectingItemsControl, IInnerContentControl
         }
     }
 
-    private void OnSelectedItemsCollectionChanged(object sender, NotifyCollectionChangedEventArgs e)
+    private void OnSelectedItemsCollectionChanged(object? sender, NotifyCollectionChangedEventArgs e)
     {
         PseudoClasses.Set(PC_Empty, SelectedItems?.Count == 0);
     }
diff --git a/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs b/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs
index 6850dfc..17b145c 100644
--- a/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs
+++ b/src/Ursa/Controls/ComboBox/MultiComboBoxItem.cs
@@ -4,6 +4,7 @@ using Avalonia.Controls;
 using Avalonia.Controls.Mixins;
 using Avalonia.Input;
 using Avalonia.LogicalTree;
+using Irihi.Avalonia.Shared.Common;
 using Irihi.Avalonia.Shared.Helpers;
 
 namespace Ursa.Controls;
@@ -26,7 +27,7 @@ public class MultiComboBoxItem: ContentControl
     
     static MultiComboBoxItem()
     {
-        IsSelectedProperty.AffectsPseudoClass<MultiComboBoxItem>(":selected");
+        IsSelectedProperty.AffectsPseudoClass<MultiComboBoxItem>(PseudoClassName.PC_Selected);
         PressedMixin.Attach<MultiComboBoxItem>();
         FocusableProperty.OverrideDefaultValue<MultiComboBoxItem>(true);
         IsSelectedProperty.Changed.AddClassHandler<MultiComboBoxItem, bool>((item, args) =>