mirror of
https://github.com/router-for-me/CLIProxyAPI.git
synced 2026-02-17 20:00:52 +08:00
918b6955e4
The ResponseRewriter's modelFieldPaths was missing 'response.model', causing the mapped model name to leak through SSE streaming events (response.created, response.in_progress, response.completed) in the OpenAI Responses API (/v1/responses). This caused Amp CLI to report 'Unknown OpenAI model' errors when model mapping was active (e.g., gpt-5.2-codex -> gpt-5.3-codex), because the mapped name reached Amp's backend via telemetry. Also sorted modelFieldPaths alphabetically per review feedback and added regression tests for all rewrite paths. Fixes #1463
111 lines
3.8 KiB
Go
111 lines
3.8 KiB
Go
package amp
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestRewriteModelInResponse_TopLevel(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: "gpt-5.2-codex"}
|
|
|
|
input := []byte(`{"id":"resp_1","model":"gpt-5.3-codex","output":[]}`)
|
|
result := rw.rewriteModelInResponse(input)
|
|
|
|
expected := `{"id":"resp_1","model":"gpt-5.2-codex","output":[]}`
|
|
if string(result) != expected {
|
|
t.Errorf("expected %s, got %s", expected, string(result))
|
|
}
|
|
}
|
|
|
|
func TestRewriteModelInResponse_ResponseModel(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: "gpt-5.2-codex"}
|
|
|
|
input := []byte(`{"type":"response.completed","response":{"id":"resp_1","model":"gpt-5.3-codex","status":"completed"}}`)
|
|
result := rw.rewriteModelInResponse(input)
|
|
|
|
expected := `{"type":"response.completed","response":{"id":"resp_1","model":"gpt-5.2-codex","status":"completed"}}`
|
|
if string(result) != expected {
|
|
t.Errorf("expected %s, got %s", expected, string(result))
|
|
}
|
|
}
|
|
|
|
func TestRewriteModelInResponse_ResponseCreated(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: "gpt-5.2-codex"}
|
|
|
|
input := []byte(`{"type":"response.created","response":{"id":"resp_1","model":"gpt-5.3-codex","status":"in_progress"}}`)
|
|
result := rw.rewriteModelInResponse(input)
|
|
|
|
expected := `{"type":"response.created","response":{"id":"resp_1","model":"gpt-5.2-codex","status":"in_progress"}}`
|
|
if string(result) != expected {
|
|
t.Errorf("expected %s, got %s", expected, string(result))
|
|
}
|
|
}
|
|
|
|
func TestRewriteModelInResponse_NoModelField(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: "gpt-5.2-codex"}
|
|
|
|
input := []byte(`{"type":"response.output_item.added","item":{"id":"item_1","type":"message"}}`)
|
|
result := rw.rewriteModelInResponse(input)
|
|
|
|
if string(result) != string(input) {
|
|
t.Errorf("expected no modification, got %s", string(result))
|
|
}
|
|
}
|
|
|
|
func TestRewriteModelInResponse_EmptyOriginalModel(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: ""}
|
|
|
|
input := []byte(`{"model":"gpt-5.3-codex"}`)
|
|
result := rw.rewriteModelInResponse(input)
|
|
|
|
if string(result) != string(input) {
|
|
t.Errorf("expected no modification when originalModel is empty, got %s", string(result))
|
|
}
|
|
}
|
|
|
|
func TestRewriteStreamChunk_SSEWithResponseModel(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: "gpt-5.2-codex"}
|
|
|
|
chunk := []byte("data: {\"type\":\"response.completed\",\"response\":{\"id\":\"resp_1\",\"model\":\"gpt-5.3-codex\",\"status\":\"completed\"}}\n\n")
|
|
result := rw.rewriteStreamChunk(chunk)
|
|
|
|
expected := "data: {\"type\":\"response.completed\",\"response\":{\"id\":\"resp_1\",\"model\":\"gpt-5.2-codex\",\"status\":\"completed\"}}\n\n"
|
|
if string(result) != expected {
|
|
t.Errorf("expected %s, got %s", expected, string(result))
|
|
}
|
|
}
|
|
|
|
func TestRewriteStreamChunk_MultipleEvents(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: "gpt-5.2-codex"}
|
|
|
|
chunk := []byte("data: {\"type\":\"response.created\",\"response\":{\"model\":\"gpt-5.3-codex\"}}\n\ndata: {\"type\":\"response.output_item.added\",\"item\":{\"id\":\"item_1\"}}\n\n")
|
|
result := rw.rewriteStreamChunk(chunk)
|
|
|
|
if string(result) == string(chunk) {
|
|
t.Error("expected response.model to be rewritten in SSE stream")
|
|
}
|
|
if !contains(result, []byte(`"model":"gpt-5.2-codex"`)) {
|
|
t.Errorf("expected rewritten model in output, got %s", string(result))
|
|
}
|
|
}
|
|
|
|
func TestRewriteStreamChunk_MessageModel(t *testing.T) {
|
|
rw := &ResponseRewriter{originalModel: "claude-opus-4.5"}
|
|
|
|
chunk := []byte("data: {\"message\":{\"model\":\"claude-sonnet-4\",\"role\":\"assistant\"}}\n\n")
|
|
result := rw.rewriteStreamChunk(chunk)
|
|
|
|
expected := "data: {\"message\":{\"model\":\"claude-opus-4.5\",\"role\":\"assistant\"}}\n\n"
|
|
if string(result) != expected {
|
|
t.Errorf("expected %s, got %s", expected, string(result))
|
|
}
|
|
}
|
|
|
|
func contains(data, substr []byte) bool {
|
|
for i := 0; i <= len(data)-len(substr); i++ {
|
|
if string(data[i:i+len(substr)]) == string(substr) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|