chuan/CLIProxyAPI
1
0
Fork 0
mirror of https://github.com/router-for-me/CLIProxyAPI.git synced 2026-02-03 21:10:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(api): Lazily register management routes

Browse Source
This commit is contained in:
hkfires
2025-10-04 13:41:49 +08:00
parent 608d745159
commit edd4b4d97f
1 changed files with 27 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
internal/api/server.go
View File

@@ -127,6 +127,8 @@ type Server struct {
// management handler // management handler
mgmt *managementHandlers.Handler mgmt *managementHandlers.Handler
// managementRoutesRegistered tracks whether the management routes have been attached to the engine.
managementRoutesRegistered atomic.Bool
// managementRoutesEnabled controls whether management endpoints serve real handlers. // managementRoutesEnabled controls whether management endpoints serve real handlers.
managementRoutesEnabled atomic.Bool managementRoutesEnabled atomic.Bool
@@ -207,7 +209,6 @@ func NewServer(cfg *config.Config, authManager *auth.Manager, accessManager *sdk
s.mgmt.SetLocalPassword(optionState.localPassword) s.mgmt.SetLocalPassword(optionState.localPassword)
} }
s.localPassword = optionState.localPassword s.localPassword = optionState.localPassword
s.managementRoutesEnabled.Store(cfg.RemoteManagement.SecretKey != "")
// Setup routes // Setup routes
s.setupRoutes() s.setupRoutes()
@@ -215,6 +216,12 @@ func NewServer(cfg *config.Config, authManager *auth.Manager, accessManager *sdk
optionState.routerConfigurator(engine, s.handlers, cfg) optionState.routerConfigurator(engine, s.handlers, cfg)
} }
// Register management routes only when a secret is present at startup.
s.managementRoutesEnabled.Store(cfg.RemoteManagement.SecretKey != "")
if cfg.RemoteManagement.SecretKey != "" {
s.registerManagementRoutes()
}
if optionState.keepAliveEnabled { if optionState.keepAliveEnabled {
s.enableKeepAlive(optionState.keepAliveTimeout, optionState.keepAliveOnTimeout) s.enableKeepAlive(optionState.keepAliveTimeout, optionState.keepAliveOnTimeout)
} }
@@ -313,7 +320,17 @@ func (s *Server) setupRoutes() {
c.String(http.StatusOK, "<html><body><h1>Authentication successful!</h1><p>You can close this window.</p></body></html>") c.String(http.StatusOK, "<html><body><h1>Authentication successful!</h1><p>You can close this window.</p></body></html>")
}) })
// Management API routes (delegated to management handlers) // Management routes are registered lazily by registerManagementRoutes when a secret is configured.
}
func (s *Server) registerManagementRoutes() {
if s == nil || s.engine == nil || s.mgmt == nil {
return
}
if !s.managementRoutesRegistered.CompareAndSwap(false, true) {
return
}
mgmt := s.engine.Group("/v0/management") mgmt := s.engine.Group("/v0/management")
mgmt.Use(s.managementAvailabilityMiddleware(), s.mgmt.Middleware()) mgmt.Use(s.managementAvailabilityMiddleware(), s.mgmt.Middleware())
{ {
@@ -394,14 +411,10 @@ func (s *Server) setupRoutes() {
func (s *Server) managementAvailabilityMiddleware() gin.HandlerFunc { func (s *Server) managementAvailabilityMiddleware() gin.HandlerFunc {
return func(c *gin.Context) { return func(c *gin.Context) {
cfg := s.cfg if !s.managementRoutesEnabled.Load() {
if cfg == nil || cfg.RemoteManagement.SecretKey == "" {
s.managementRoutesEnabled.Store(false)
c.AbortWithStatus(http.StatusNotFound) c.AbortWithStatus(http.StatusNotFound)
return return
} }
s.managementRoutesEnabled.Store(true)
c.Next() c.Next()
} }
} }
@@ -664,13 +677,20 @@ func (s *Server) UpdateClients(cfg *config.Config) {
newSecretEmpty := cfg.RemoteManagement.SecretKey == "" newSecretEmpty := cfg.RemoteManagement.SecretKey == ""
switch { switch {
case prevSecretEmpty && !newSecretEmpty: case prevSecretEmpty && !newSecretEmpty:
s.registerManagementRoutes()
if s.managementRoutesEnabled.CompareAndSwap(false, true) { if s.managementRoutesEnabled.CompareAndSwap(false, true) {
log.Info("management routes enabled after secret key update") log.Info("management routes enabled after secret key update")
} else {
s.managementRoutesEnabled.Store(true)
} }
case !prevSecretEmpty && newSecretEmpty: case !prevSecretEmpty && newSecretEmpty:
if s.managementRoutesEnabled.CompareAndSwap(true, false) { if s.managementRoutesEnabled.CompareAndSwap(true, false) {
log.Info("management routes disabled after secret key removal") log.Info("management routes disabled after secret key removal")
} else {
s.managementRoutesEnabled.Store(false)
} }
default:
s.managementRoutesEnabled.Store(!newSecretEmpty)
} }
s.applyAccessConfig(oldCfg, cfg) s.applyAccessConfig(oldCfg, cfg)