From 2717ba3e508170d17cd724774f977c40a22d5332 Mon Sep 17 00:00:00 2001 From: hkfires <10558748+hkfires@users.noreply.github.com> Date: Fri, 26 Sep 2025 17:48:12 +0800 Subject: [PATCH] fix(registry): Avoid provider update when new provider is empty When a client re-registered and changed its provider from a non-empty value to an empty string, the logic would still trigger a provider update for the client's models. An empty provider string should not cause an update. This commit fixes this behavior by adding a check to ensure the new provider is a non-empty string before updating the model's provider information. Additionally, the logic for detecting a provider change has been simplified by removing an unnecessary variable. --- internal/registry/model_registry.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/registry/model_registry.go b/internal/registry/model_registry.go index a2de4831..cc679941 100644 --- a/internal/registry/model_registry.go +++ b/internal/registry/model_registry.go @@ -129,8 +129,8 @@ func (r *ModelRegistry) RegisterClient(clientID, clientProvider string, models [ now := time.Now() oldModels, hadExisting := r.clientModels[clientID] - oldProvider, hadProvider := r.clientProviders[clientID] - providerChanged := hadProvider && oldProvider != provider + oldProvider, _ := r.clientProviders[clientID] + providerChanged := oldProvider != provider if !hadExisting { // Pure addition path. for _, modelID := range modelIDs { @@ -205,7 +205,7 @@ func (r *ModelRegistry) RegisterClient(clientID, clientProvider string, models [ if reg, ok := r.models[id]; ok { reg.Info = cloneModelInfo(model) reg.LastUpdated = now - if providerChanged { + if providerChanged && provider != "" { if _, newlyAdded := addedSet[id]; newlyAdded { continue }