From 1ba057112a0f3546e224b34c7efac7a88794e9d5 Mon Sep 17 00:00:00 2001 From: hkfires <10558748+hkfires@users.noreply.github.com> Date: Tue, 18 Nov 2025 16:57:28 +0800 Subject: [PATCH] fix: use underscore suffix in short name mapping Replace the "~" suffix with "_" when generating unique short names in codex translators (Claude, Gemini, OpenAI chat). This avoids using a special character in identifiers, improving compatibility with downstream APIs while preserving length constraints. --- internal/translator/codex/claude/codex_claude_request.go | 2 +- internal/translator/codex/gemini/codex_gemini_request.go | 2 +- .../codex/openai/chat-completions/codex_openai_request.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/translator/codex/claude/codex_claude_request.go b/internal/translator/codex/claude/codex_claude_request.go index 3949fc3d..2980568c 100644 --- a/internal/translator/codex/claude/codex_claude_request.go +++ b/internal/translator/codex/claude/codex_claude_request.go @@ -289,7 +289,7 @@ func buildShortNameMap(names []string) map[string]string { } base := cand for i := 1; ; i++ { - suffix := "~" + strconv.Itoa(i) + suffix := "_" + strconv.Itoa(i) allowed := limit - len(suffix) if allowed < 0 { allowed = 0 diff --git a/internal/translator/codex/gemini/codex_gemini_request.go b/internal/translator/codex/gemini/codex_gemini_request.go index 7f51937d..5b5263f3 100644 --- a/internal/translator/codex/gemini/codex_gemini_request.go +++ b/internal/translator/codex/gemini/codex_gemini_request.go @@ -310,7 +310,7 @@ func buildShortNameMap(names []string) map[string]string { } base := cand for i := 1; ; i++ { - suffix := "~" + strconv.Itoa(i) + suffix := "_" + strconv.Itoa(i) allowed := limit - len(suffix) if allowed < 0 { allowed = 0 diff --git a/internal/translator/codex/openai/chat-completions/codex_openai_request.go b/internal/translator/codex/openai/chat-completions/codex_openai_request.go index c9dfdb9f..bd5a17c2 100644 --- a/internal/translator/codex/openai/chat-completions/codex_openai_request.go +++ b/internal/translator/codex/openai/chat-completions/codex_openai_request.go @@ -361,7 +361,7 @@ func buildShortNameMap(names []string) map[string]string { } base := cand for i := 1; ; i++ { - suffix := "~" + strconv.Itoa(i) + suffix := "_" + strconv.Itoa(i) allowed := limit - len(suffix) if allowed < 0 { allowed = 0