agent/pi
2
0
Fork 0
mirror of https://github.com/earendil-works/pi.git synced 2026-06-18 15:54:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(coding-agent): add experimental feature flag

Browse Source
This commit is contained in:
Vegard Stikbakke
2026-06-08 15:36:26 +02:00
Unverified
parent d8aef0feff
commit 54c49ddeb0
7 changed files with 86 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/coding-agent/test/settings-manager.test.ts
+53
View File
@@ -9,8 +9,10 @@ describe("SettingsManager", () => {
const testDir = join(process.cwd(), "test-settings-tmp");
const agentDir = join(testDir, "agent");
const projectDir = join(testDir, "project");
const originalPiExperimental = process.env.PI_EXPERIMENTAL;
beforeEach(() => {
delete process.env.PI_EXPERIMENTAL;
// Clean up and create fresh directories
if (existsSync(testDir)) {
rmSync(testDir, { recursive: true });
@@ -20,6 +22,11 @@ describe("SettingsManager", () => {
});
afterEach(() => {
if (originalPiExperimental === undefined) {
delete process.env.PI_EXPERIMENTAL;
} else {
process.env.PI_EXPERIMENTAL = originalPiExperimental;
}
if (existsSync(testDir)) {
rmSync(testDir, { recursive: true });
}
@@ -252,6 +259,52 @@ describe("SettingsManager", () => {
});
});
describe("experimentalFeatures", () => {
it("should default to false", () => {
const manager = SettingsManager.create(projectDir, agentDir);
expect(manager.getExperimentalFeaturesEnabled()).toBe(false);
});
it("should load the global setting", () => {
writeFileSync(join(agentDir, "settings.json"), JSON.stringify({ experimentalFeatures: true }));
const manager = SettingsManager.create(projectDir, agentDir);
expect(manager.getExperimentalFeaturesEnabled()).toBe(true);
});
it("should ignore project settings", () => {
writeFileSync(join(projectDir, ".pi", "settings.json"), JSON.stringify({ experimentalFeatures: true }));
const manager = SettingsManager.create(projectDir, agentDir);
expect(manager.getExperimentalFeaturesEnabled()).toBe(false);
});
it("should let PI_EXPERIMENTAL enable experimental features", () => {
process.env.PI_EXPERIMENTAL = "1";
const manager = SettingsManager.create(projectDir, agentDir);
expect(manager.getExperimentalFeaturesEnabled()).toBe(true);
});
it("should let PI_EXPERIMENTAL override the global setting", () => {
process.env.PI_EXPERIMENTAL = "0";
writeFileSync(join(agentDir, "settings.json"), JSON.stringify({ experimentalFeatures: true }));
const manager = SettingsManager.create(projectDir, agentDir);
expect(manager.getExperimentalFeaturesEnabled()).toBe(false);
});
it("should save to global settings", async () => {
const settingsPath = join(agentDir, "settings.json");
const manager = SettingsManager.create(projectDir, agentDir);
manager.setExperimentalFeaturesEnabled(true);
await manager.flush();
expect(JSON.parse(readFileSync(settingsPath, "utf-8")).experimentalFeatures).toBe(true);
});
});
describe("project settings directory creation", () => {
it("should not create .pi folder when only reading project settings", () => {
// Create agent dir with global settings, but NO .pi folder in project