15 Commits

  • fix: refresh stale technical content in agents, rules, and skills (#2168)
    Several published examples contained APIs that no longer exist, code that
    does not run, or model versions that drifted from reality:
    
    - agents/performance-optimizer.md used the web-vitals v3 API
      (getCLS/getFID/getLCP/getFCP/getTTFB) and reported FID. web-vitals v4
      renamed the imports to onCLS/onINP/onLCP/onFCP/onTTFB and FID was
      replaced by INP (target < 200ms)
    - rules/common/performance.md pinned stale model versions in the
      model-selection guidance; refresh to the versions the repo itself uses
      (agent.yaml pins claude-opus-4-6) and add the PowerShell variant for
      MAX_THINKING_TOKENS next to the bash export
    - skills/python-patterns/SKILL.md: both get_value examples referenced
      default_value without declaring the parameter (NameError); add
      default_value: Any = None to the EAFP and LBYL signatures
    - skills/frontend-patterns/SKILL.md: the custom useQuery example rebuilt
      refetch whenever callers passed inline fetchers/options, re-triggering
      the effect after every state update (infinite fetch loop). Keep the
      latest fetcher/options in refs so refetch stays referentially stable.
      The PASS-labelled useMemo example mutated its input with in-place sort;
      copy before sorting
    - skills/coding-standards/SKILL.md repeated the same PASS-labelled
      in-place-sort-in-useMemo example; same fix
    - rules/typescript/security.md used a vendor-specific OPENAI_API_KEY in
      generic guidance; switch to a neutral API_KEY
    
    Every hand-maintained copy of the affected content is synced in the same
    change: locale mirrors (ja-JP, ko-KR, pt-BR, tr, zh-CN, zh-TW - each only
    where it carries the affected file) and the .agents/.kiro/.cursor harness
    mirrors. Two structural divergences are left alone and noted here:
    .kiro/steering/performance.md has no extended-thinking control list to
    carry the PowerShell variant, and docs/zh-TW/rules/performance.md keeps an
    older condensed thinking section without the budget-cap line.
    rules/zh/performance.md is intentionally untouched - the rules/zh tree is
    being retired in a separate change
  • fix: address review feedback from PR #929
    - Add missing code-review.md and development-workflow.md to zh/README.md directory listing
    - Add mkdir -p command before copy in manual install instructions
    - Fix TypeScript test command path in SKILL-DEVELOPMENT-GUIDE.md
    - Add Anti-Patterns section to SKILL.md template
    - Add Template category to Skill Categories table in CONTRIBUTING.md
    - Add Pre-Review Requirements section to code-review.md (both en and zh)
    - Add Pre-Review Checks step to development-workflow.md (both en and zh)
    - Add trailing newlines to all files that were missing them
  • feat(rules): add code-review.md rule to common rules
    - Add comprehensive code review standards for all languages
    - Define when to review (after code changes, before commits)
    - Include security review triggers and severity levels
    - Reference relevant agents (code-reviewer, security-reviewer, etc.)
    - Add review checklist covering security, quality, and performance
    - Define approval criteria (Approve/Warning/Block)
    
    This rule complements the existing code-reviewer agent by providing
    clear guidelines on when and how to conduct code reviews.
  • feat: separate core vs niche skills and enforce research-first default
    * Initial plan
    
    * docs: document core skill scope
    
    ---------
    
    Co-authored-by: openai-code-agent[bot] <242516109+Codex@users.noreply.github.com>
  • feat(rules): add development-workflow.md with Feature Implementation Workflow (refs #235)
    This document outlines the full feature development process, including planning, TDD, code review, and committing to git.
  • refactor(rules): split Feature Implementation Workflow from git-workflow.md (refs #235)
    Removed the Feature Implementation Workflow section from the Git Workflow document.
  • chore: update Sonnet model references from 4.5 to 4.6
    Update MODEL_SONNET constant and all documentation references
    to reflect the new claude-sonnet-4-6 model version.
  • refactor(rules): restructure into common + language-specific directories
    * refactor(rules): restructure rules into common + language-specific directories
    
    - Split 8 flat rule files into common/, typescript/, python/, golang/
    - common/ contains language-agnostic principles (no code examples)
    - typescript/ extracts TS/JS specifics (Zod, Playwright, Prettier hooks, etc.)
    - python/ adds Python rules (PEP 8, pytest, black/ruff, bandit)
    - golang/ adds Go rules (gofmt, table-driven tests, gosec, functional options)
    - Replace deprecated ultrathink with extended thinking documentation
    - Add README.md with installation guide and new-language template
    
    Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
    
    * Fix installation commands for rules
    
    Updated installation instructions to copy all rules to a single directory.
    
    * docs: update README.md to reflect new rules directory structure
    
    Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
    
    ---------
    
    Co-authored-by: Hor1zonZzz <Hor1zonZzz@users.noreply.github.com>
    Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>