Commit Graph

4 Commits

  • fix: null-safe package.json access in getRepoChecks
    Review follow-up (CodeRabbit + cubic): switching to safeParseJson at line
    389 means packageJson can be null on a missing/malformed package.json, but
    the quality-ci-validations check dereferenced packageJson.scripts before the
    optional chaining could help — throwing TypeError instead of degrading.
    Guard the base object with packageJson?.scripts?.test at the access site,
    matching the file's existing convention (e.g. line 220 uses packageJson?.name).
    
    Generated with [Claude Code](https://claude.ai/code)
    via [Happy](https://happy.engineering)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    Co-Authored-By: Happy <yesreply@happy.engineering>
  • fix: guard two script edge cases
    - scripts/harness-audit.js: getRepoChecks() parsed package.json with raw
      JSON.parse(readText(...)), while the rest of the file (lines 218, 822)
      uses the tolerant safeParseJson(safeRead(...)). In repo target mode a
      project lacking package.json — or with malformed JSON — threw an uncaught
      exception and crashed the audit instead of degrading. Match the existing
      convention so the audit tolerates a missing/invalid package.json.
    
    - skills/frontend-slides/scripts/export-pdf.sh: `set -- "${POSITIONAL[@]}"`
      expands an empty array under `set -u` on bash 3.2 (the macOS system bash),
      aborting with "POSITIONAL[@]: unbound variable" instead of printing the
      usage message when invoked with no positional args. Guard the expansion
      with ${POSITIONAL[@]+"${POSITIONAL[@]}"} (no-op safe under bash 3.2 set -u).
    
    Generated with [Claude Code](https://claude.ai/code)
    via [Happy](https://happy.engineering)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    Co-Authored-By: Happy <yesreply@happy.engineering>
  • fix: audit consumer projects from cwd (#1014)
    * fix: audit consumer projects from cwd
    
    * fix: unblock unicode safety CI lint
    
    * fix: unblock shared CI regressions
    
    * test: isolate package-manager dependent hooks and formatter tests