8 Commits

• fix: clamp getAllSessions pagination params, add cleanupAliases success field, add 10 tests

  - session-manager: clamp offset/limit to safe non-negative integers to
    prevent negative offset counting from end and NaN returning empty results
  - session-aliases: add success field to cleanupAliases return value for
    API contract consistency with setAlias/deleteAlias/renameAlias

  Affaan Mustafa · 2026-02-13 02:16:22 -08:00
  f33ed4c49e
• fix: calendar-accurate date validation in parseSessionFilename, add 22 tests

  - Fix parseSessionFilename to reject impossible dates (Feb 31, Apr 31,
    Feb 29 non-leap) using Date constructor month/day roundtrip check
  - Add 6 session-manager tests for calendar date validation edge cases
  - Add 3 session-manager tests for code blocks/special chars in getSessionStats
  - Add 10 package-manager tests for PM-specific command formats (getRunCommand
    and getExecCommand for pnpm, yarn, bun, npm)
  - Add 3 integration tests for session-end transcript parsing (mixed JSONL
    formats, malformed lines, nested user messages)

  Affaan Mustafa · 2026-02-13 01:42:56 -08:00
  e96b522af0
• fix: typecheck hook false positives, add 11 session-manager tests

  - Fix post-edit-typecheck.js error filtering: use relative/absolute path
    matching instead of basename, preventing false positives when multiple
    files share the same name (e.g., src/utils.ts vs tests/utils.ts)
  - Add writeSessionContent tests (create, overwrite, invalid path)
  - Add appendSessionContent test (append to existing file)
  - Add deleteSession tests (delete existing, non-existent)
  - Add sessionExists tests (file, non-existent, directory)
  - Add getSessionStats empty content edge case
  - Add post-edit-typecheck stdout passthrough test
  - Total: 391 → 402 tests, all passing

  Affaan Mustafa · 2026-02-13 01:28:59 -08:00
  3f651b7c3c
• fix: add input validation, date range checks, and security hardening

  - validate-agents.js: reject invalid model names in agent frontmatter
  - package-manager.js: validate script/binary names against shell injection
  - session-manager.js: reject impossible month/day values in filenames
  - utils.js: support options.all for replaceInFile string patterns
  - strategic-compact/SKILL.md: fix hook matcher syntax and script reference
  - install.sh: warn when overwriting existing rule customizations
  - Add 24 new tests covering all validation and edge cases

  Affaan Mustafa · 2026-02-12 17:32:04 -08:00
  926eba97c5
• fix: set USERPROFILE in tests for Windows os.homedir() compatibility

  On Windows, os.homedir() uses USERPROFILE env var instead of HOME.
  Tests that override HOME to a temp dir must also set USERPROFILE for
  the session-manager, session-aliases, and session-start hook tests
  to find files in the correct directory.

  Affaan Mustafa · 2026-02-12 16:41:58 -08:00
  dc9aefbee1
• test: add 33 edge case tests for session-manager, session-aliases, and hooks

  - session-manager: CRLF handling, empty sections, multi-heading title, context
    extraction, notes/context detection, MB file size, uppercase ID rejection
  - session-aliases: missing timestamps sort, title search, createdAt preservation,
    whitespace-only path rejection, empty string title behavior
  - hooks: session-start isolated HOME, template vs real session injection,
    learned skills count, check-console-log passthrough
  
  Total test count: 261 → 294

  Affaan Mustafa · 2026-02-12 16:26:57 -08:00
  e9f0f1334f
• fix: broken cross-references, version sync, and enhanced command validator

  - Fix /build-and-fix → /build-fix in tdd.md, plan.md (+ cursor, zh-CN)
  - Fix non-existent explorer agent → planner in orchestrate.md (+ cursor, zh-CN, zh-TW)
  - Fix /python-test → /tdd in python-review.md (+ cursor, zh-CN)
  - Sync package.json version from 1.0.0 to 1.4.1 to match plugin.json
  - Enhance validate-commands.js with cross-reference checking:
    command refs, agent path refs, skill dir refs, workflow diagrams
  - Strip fenced code blocks before scanning to avoid false positives
  - Skip hypothetical "Creates:" lines in evolve.md examples
  - Add 46 new tests (suggest-compact, session-manager, utils, hooks)

  Affaan Mustafa · 2026-02-12 16:19:04 -08:00
  bc0520c6c1
• fix: 6 bugs fixed, 67 tests added for session-manager and session-aliases

  Bug fixes:
  - utils.js: prevent duplicate 'g' flag in countInFile regex construction
  - validate-agents.js: handle CRLF line endings in frontmatter parsing
  - validate-hooks.js: handle \t and \\ escape sequences in inline JS validation
  - session-aliases.js: prevent NaN in date sort when timestamps are missing
  - session-aliases.js: persist rollback on rename failure instead of silent loss
  - session-manager.js: require absolute paths in getSessionStats to prevent
    content strings ending with .tmp from being treated as file paths
  
  New tests (164 total, up from 97):
  - session-manager.test.js: 27 tests covering parseSessionFilename,
    parseSessionMetadata, getSessionStats, CRUD operations, getSessionSize,
    getSessionTitle, edge cases (null input, non-existent files, directories)
  - session-aliases.test.js: 40 tests covering loadAliases (corrupted JSON,
    invalid structure), setAlias (validation, reserved names), resolveAlias,
    listAliases (sort, search, limit), deleteAlias, renameAlias, updateAliasTitle,
    resolveSessionAlias, getAliasesForSession, cleanupAliases, atomic write
  
  Also includes hook-generated improvements:
  - utils.d.ts: document that readStdinJson never rejects
  - session-aliases.d.ts: fix updateAliasTitle type to accept null
  - package-manager.js: add try-catch to setProjectPackageManager writeFile

  Affaan Mustafa · 2026-02-12 15:50:04 -08:00
  76b271ab6b