10 Commits

• Merge branch 'affaan-m:main' into main
  Pangerkumzuk Longkumer · 2026-02-18 18:33:04 +05:30
  e1fca6e84d
• Fix stdin overflow bug in hook scripts - truncate chunks to stay within MAX_STDIN limit

  Co-authored-by: pangerlkr <73515951+pangerlkr@users.noreply.github.com>

  copilot-swe-agent[bot] · 2026-02-18 07:40:12 +00:00
  1eca3c9130
• fix: add missing process.exit(0) to early return in post-edit-console-warn hook
  Affaan Mustafa · 2026-02-16 20:03:12 -08:00
  2c26d2d67c
• fix: add cwd to prettier hook, consistent process.exit(0), and stdout pass-through

  - post-edit-format.js: add cwd based on file directory so npx resolves
    correct local prettier binary
  - post-edit-typecheck.js, post-edit-format.js: replace console.log(data)
    with process.stdout.write(data) to avoid trailing newline corruption
  - Add process.exit(0) to 4 hooks for consistent termination
    (check-console-log, post-edit-console-warn, post-edit-format,
    post-edit-typecheck)
  - run-all.js: switch from execSync to spawnSync so stderr is visible
    on the success path (hook warnings were silently discarded)
  - Add 21 tests: cwd verification, process.exit(0) checks, exact
    stdout pass-through, extension edge cases, exclusion pattern
    matching, threshold boundary values (630 → 651)

  Affaan Mustafa · 2026-02-13 03:20:41 -08:00
  992688a674
• fix: exact byte pass-through in post-edit-console-warn, add 7 tests

  Replace console.log(data) with process.stdout.write(data) in both
  pass-through paths to prevent appending a trailing newline that
  corrupts the hook output. Add 7 tests covering exact byte fidelity,
  malformed JSON, missing file_path, non-existent files, exclusion
  patterns in check-console-log, non-git repo handling, and empty stdin.

  Affaan Mustafa · 2026-02-13 02:49:33 -08:00
  6bbcbec23d
• fix: 3 bugs fixed, stdin encoding hardened, 37 CI validator tests added

  Bug fixes:
  - utils.js: glob-to-regex conversion now escapes all regex special chars
    (+, ^, $, |, (), {}, [], \) before converting * and ? wildcards
  - validate-hooks.js: escape sequence processing order corrected —
    \\\\ now processed before \\n and \\t to prevent double-processing
  - 6 hooks: added process.stdin.setEncoding('utf8') to prevent
    multi-byte UTF-8 character corruption at chunk boundaries
    (check-console-log, post-edit-format, post-edit-typecheck,
    post-edit-console-warn, session-end, evaluate-session)
  
  New tests (37):
  - CI validator test suite (tests/ci/validators.test.js):
    - validate-agents: 9 tests (real project, frontmatter parsing,
      BOM/CRLF, colons in values, missing fields, non-md skip)
    - validate-hooks: 13 tests (real project, invalid JSON, invalid
      event types, missing fields, async/timeout validation, inline JS
      syntax, array commands, legacy format)
    - validate-skills: 6 tests (real project, missing SKILL.md, empty
      files, non-directory entries)
    - validate-commands: 5 tests (real project, empty files, non-md skip)
    - validate-rules: 4 tests (real project, empty files)
  
  Total test count: 228 (up from 191)

  Affaan Mustafa · 2026-02-12 16:08:49 -08:00
  492c99ac24
• fix: remove unused fs imports in 3 hook scripts

  readFile utility replaced direct fs usage but the imports weren't
  removed, causing ESLint no-unused-vars failures in CI.

  Affaan Mustafa · 2026-02-12 15:33:51 -08:00
  3546abc6ea
• fix: use readFile utility in hooks and add pattern type safety

  - Replace raw fs.readFileSync with readFile() from utils in
    check-console-log.js and post-edit-console-warn.js to eliminate
    TOCTOU race conditions (file deleted between existsSync and read)
  - Remove redundant existsSync in post-edit-format.js (exec already
    handles missing files via its catch block)
  - Resolve path upfront in post-edit-typecheck.js before tsconfig walk
  - Add type guard in getGitModifiedFiles() to skip non-string and
    empty patterns before regex compilation

  Affaan Mustafa · 2026-02-12 15:28:30 -08:00
  e7b5c62eb7
• fix: harden error handling, fix TOCTOU races, and improve test accuracy

  Core library fixes:
  - session-manager.js: wrap all statSync calls in try-catch to prevent
    TOCTOU crashes when files are deleted between readdir and stat
  - session-manager.js: use birthtime||ctime fallback for Linux compat
  - session-manager.js: remove redundant existsSync before readFile
  - utils.js: fix findFiles TOCTOU race on statSync inside readdir loop
  
  Hook improvements:
  - Add 1MB stdin buffer limits to all PostToolUse hooks to prevent
    unbounded memory growth from large payloads
  - suggest-compact.js: use fd-based atomic read+write for counter file
    to reduce race window between concurrent invocations
  - session-end.js: log when transcript file is missing, check
    replaceInFile return value for failed timestamp updates
  - start-observer.sh: log claude CLI failures instead of silently
    swallowing them, check observations file exists before analysis
  
  Test fixes:
  - Fix blocking hook tests to send matching input (dev server command)
    and expect correct exit code 2 instead of 1

  Affaan Mustafa · 2026-02-12 13:40:14 -08:00
  36864ea11a
• refactor: extract inline PostToolUse hooks into external scripts

  Move three complex inline hooks from hooks.json into proper external
  scripts in scripts/hooks/:
  
  - post-edit-format.js: Prettier auto-formatting (was 1 minified line)
  - post-edit-typecheck.js: TypeScript check (was 1 minified line with
    unbounded directory traversal, now capped at 20 levels)
  - post-edit-console-warn.js: console.log warnings (was 1 minified line)
  
  Benefits:
  - Readable, documented, and properly error-handled
  - Testable independently via stdin
  - Consistent with other hooks (all use external scripts now)
  - Adds timeouts to Prettier (15s) and tsc (30s) to prevent hangs

  Affaan Mustafa · 2026-02-12 10:21:59 -08:00
  7356fd996f