9 Commits

• fix: narrow unicode cleanup scope
  Affaan Mustafa · 2026-03-29 21:21:18 -04:00
  7483d646e4
• fix: harden unicode safety checks
  Affaan Mustafa · 2026-03-29 21:21:18 -04:00
  866d9ebb53
• fix: use nullish coalescing for confidence default + add 3 tests (round 85)

  Fix confidence=0 showing 80% instead of 0% in patterns() (|| → ??).
  Test evaluate-session.js config parse error catch, getSessionIdShort
  fallback at root CWD, and precise confidence=0 assertion.

  Affaan Mustafa · 2026-02-13 12:11:26 -08:00
  8cacf0f6a6
• fix: correct box() off-by-one width calculation in skill-create-output

  The box() helper produced lines that were width+1 characters instead of
  the requested width. Adjusted all three formulas (top border, middle
  content, bottom border) by -1 each. Added 4 tests verifying box width
  accuracy across instincts(), analysisResults(), and nextSteps() output.

  Affaan Mustafa · 2026-02-13 04:05:12 -08:00
  b497135b95
• fix: header subtitle width mismatch in skill-create-output; add 9 tests (Round 34)

  - Fix subtitle padding 55→59 so line 94 matches 64-char border width
  - Add 4 header width alignment tests (skill-create-output)
  - Add 3 getExecCommand non-string args tests (package-manager)
  - Add 2 detectFromPackageJson non-string type tests (package-manager)

  Affaan Mustafa · 2026-02-13 03:58:16 -08:00
  554b5d6704
• fix: clamp progressBar to prevent RangeError on overflow, add 10 tests

  progressBar() in skill-create-output.js could crash with RangeError when
  percent > 100 because repeat() received a negative count. Fixed by
  clamping filled to [0, width].
  
  New tests:
  - progressBar edge cases: 0%, 100%, and >100% confidence
  - Empty patterns/instincts arrays
  - post-edit-format: null tool_input, missing file_path, prettier failure
  - setup-package-manager: --detect output completeness, current marker

  Affaan Mustafa · 2026-02-13 02:01:57 -08:00
  5398ac793d
• fix: box() off-by-one alignment, add 5 tests for readStdinJson and box alignment

  - skill-create-output.js: fix top border being 1 char narrower than
    middle/bottom lines (width - title - 5 → width - title - 4)
  - Add box alignment regression test verifying all lines have equal width
  - Add 4 readStdinJson tests via subprocess (valid JSON, invalid JSON,
    empty stdin, nested objects) — last untested exported utility function
  - All 338 tests passing

  Affaan Mustafa · 2026-02-12 16:53:06 -08:00
  5107b3669f
• fix: add word boundary to dev server hook regex, fix box() crash, add 27 tests

  - hooks.json: add \b word boundary anchors to dev server blocking regex
    to prevent false positives matching "npm run develop", "npm run devtools" etc.
  - skill-create-output.js: guard box() horizontal repeat with Math.max(0, ...)
    to prevent RangeError when title exceeds container width
  - Add 13 tests for setup-package-manager.js CLI argument parsing
  - Add 14 tests for skill-create-output.js SkillCreateOutput class
  - All 333 tests passing

  Affaan Mustafa · 2026-02-12 16:46:06 -08:00
  924bac4ddf
• fix: resolve ESLint errors and update tests for project-name fallback

  - Fix 16 ESLint no-unused-vars errors across hook scripts and tests
  - Add eslint-disable comment for intentional control-regex in ANSI stripper
  - Update session file test to use getSessionIdShort() instead of hardcoded 'default'
    (reflects PR #110's project-name fallback behavior)
  - Add marketing/ to .gitignore (local drafts)
  - Add skill-create-output.js (terminal output formatter)
  
  All 69 tests now pass. CI should be green.

  Affaan Mustafa · 2026-01-29 02:58:51 -08:00
  a44a0553bb