mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
Adam Perry @ OpenAI
0b08bbb9d9
## Why Windows ARM64 uses 64-bit `long double`, but the LLVM MinGW Bazel configuration omits the upstream `powl` compatibility source and does not link the `mingwex` archive that owns it. Cross-linking the release binary therefore fails with an unresolved `powl` symbol. ## What changed Patch the LLVM module to compile `math/arm-common/powl.c` into the ARM64 MinGW extension sources and add `-lmingwex` to the Windows toolchain defaults. ## Validation - `just bazel-lock-check` Stack: 3 of 6. Depends on #27322.
25 lines
963 B
Diff
25 lines
963 B
Diff
# What: provide and link MinGW's ARM64 long-double `powl` compatibility shim.
|
|
# Why: Windows ARM64 uses 64-bit long doubles, but LLVM's Bazel source list
|
|
# omits the upstream `powl -> pow` implementation and its default link flags
|
|
# omit the MinGW extension archive that owns the shim.
|
|
|
|
diff --git a/runtimes/mingw/crt_sources.bzl b/runtimes/mingw/crt_sources.bzl
|
|
--- a/runtimes/mingw/crt_sources.bzl
|
|
+++ b/runtimes/mingw/crt_sources.bzl
|
|
@@ -420,4 +420,5 @@
|
|
MINGWEX_ARM64_SRCS = [
|
|
+ "math/arm-common/powl.c",
|
|
"math/sincos.c",
|
|
"math/sincosf.c",
|
|
"math/arm-common/sincosl.c",
|
|
diff --git a/toolchain/args/windows/BUILD.bazel b/toolchain/args/windows/BUILD.bazel
|
|
--- a/toolchain/args/windows/BUILD.bazel
|
|
+++ b/toolchain/args/windows/BUILD.bazel
|
|
@@ -49,5 +49,6 @@ cc_args(
|
|
+ "-lmingwex",
|
|
# For now, we force on ucrt.
|
|
# TODO(cerisier): make this either a constraint or a build setting
|
|
"-lucrt",
|
|
],
|
|
data = [
|