danwang-oai 11806faf71 Fix hang on turn/interrupt (#18392) ...

Fix a bug where the `turn/interrupt` RPC hangs when interrupting a turn
that has already completed.

Before this change, `turn/interrupt` requests were queued in app-server
and only answered when a later TurnAborted event arrived. If the target
turn was already complete, core treated Op::Interrupt as a no-op, so no
abort event was emitted and the RPC could hang indefinitely.

This change fixes that in two places:

* Reject turn/interrupt immediately with `INVALID_REQUEST` when the
requested turn is no longer the active turn.
* Resolve any already-accepted pending interrupt requests when the turn
reaches TurnComplete, covering the case where a turn finishes naturally
after the interrupt request is accepted but before it aborts.

I tested this by adding a failing test in
707487c0634834f6741986b64f61886c2dc10108. You may view the results here:
https://github.com/openai/codex/actions/runs/24585182419/

<img width="1512" height="310" alt="CleanShot 2026-04-17 at 16 33 30@2x"
src="https://github.com/user-attachments/assets/f4a88228-b2a4-41f4-9aaa-ec82814096af"
/>

11806faf71 · 2026-04-24 10:47:50 -04:00

History

..

common

Update models.json and related fixtures (#19323)

2026-04-24 11:14:13 +02:00

suite

Fix hang on turn/interrupt (#18392)

2026-04-24 10:47:50 -04:00

all.rs

fix: separate codex mcp into codex mcp-server and codex app-server (#4471)

2025-09-30 07:06:18 +00:00