Michael Bolin f7ef9599ed exec: make review-policy tests hermetic (#16137) ...

## Why

`thread_start_params_from_config()` is supposed to forward the effective
`approvals_reviewer` into the app-server request, but these tests were
constructing that config through `ConfigBuilder::build()`, which also
loads ambient system and managed config layers. On machines with an
admin or host-level reviewer override, the manual-only case could
inherit `guardian_subagent` and fail even though the exec-side mapping
was correct.

## What changed

- Set `approvals_reviewer` explicitly via `harness_overrides` in the two
`thread_start_params_*review_policy*` tests in
`codex-rs/exec/src/lib.rs`.
- Removed the dependence on default config resolution and temp
`config.toml` writes so the tests exercise only the reviewer-to-request
mapping in `codex-exec`.

## Testing

- `cargo test -p codex-exec`

f7ef9599ed · 2026-03-28 23:01:04 +00:00

History

..

src

exec: make review-policy tests hermetic (#16137)

2026-03-28 23:01:04 +00:00

tests

fix: fix comment linter lint violations in Linux-only code (#16118)

2026-03-28 11:09:41 -07:00

BUILD.bazel

feat: add support for building with Bazel (#8875)

2026-01-09 11:09:43 -08:00

Cargo.toml

Move git utilities into a dedicated crate (#15564)

2026-03-24 13:26:23 -07:00