codex

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Ahmed Ibrahim f59978ed3d Handle cancelling/aborting while processing a turn (#5543 )

Currently we collect all all turn items in a vector, then we add it to
the history on success. This result in losing those items on errors
including aborting `ctrl+c`.

This PR:
- Adds the ability for the tool call to handle cancellation
- bubble the turn items up to where we are recording this info

Admittedly, this logic is an ad-hoc logic that doesn't handle a lot of
error edge cases. The right thing to do is recording to the history on
the spot as `items`/`tool calls output` come. However, this isn't
possible because of having different `task_kind` that has different
`conversation_histories`. The `try_run_turn` has no idea what thread are
we using. We cannot also pass an `arc` to the `conversation_histories`
because it's a private element of `state`.

That's said, `abort` is the most common case and we should cover it
until we remove `task kind`

f59978ed3d · 2025-10-23 08:47:10 -07:00

History

common

Handle cancelling/aborting while processing a turn (#5543 )

2025-10-23 08:47:10 -07:00

fixtures

Improve SSE tests (#1546 )

2025-07-12 16:53:55 -07:00

suite

Handle cancelling/aborting while processing a turn (#5543 )

2025-10-23 08:47:10 -07:00

all.rs