Huaiwu Li 9a638dbf4e fix(tui): propagate errors in insert_history_lines_to_writer (#4266) ...

## What?
Fixed error handling in `insert_history_lines_to_writer` where all
terminal operations were silently ignoring errors via `.ok()`.

  ## Why?
Silent I/O failures could leave the terminal in an inconsistent state
(e.g., scroll region not reset) with no way to debug. This violates Rust
error handling best practices.

  ## How?
  - Changed function signature to return `io::Result<()>`
  - Replaced all `.ok()` calls with `?` operator to propagate errors
- Added `tracing::warn!` in wrapper function for backward compatibility
  - Updated 15 test call sites to handle Result  with `.expect()`

  ## Testing
  - ✅ Pass all tests

  ## Type of Change
  - [x] Bug fix (non-breaking change)

---------

Signed-off-by: Huaiwu Li <lhwzds@gmail.com>
Co-authored-by: Eric Traut <etraut@openai.com>

9a638dbf4e · 2025-10-30 18:07:51 -07:00

History

..

fixtures

feat: add Vec<ParsedCommand> to ExecApprovalRequestEvent (#5222)

2025-10-15 13:58:40 -07:00

suite

fix(tui): propagate errors in insert_history_lines_to_writer (#4266)

2025-10-30 18:07:51 -07:00

all.rs

update composer + user message styling (#4240)

2025-09-26 16:35:56 -07:00

test_backend.rs

update composer + user message styling (#4240)

2025-09-26 16:35:56 -07:00