codex

agent/codex

Fork 0

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

History

viyatb-oaiandGitHub aea82c63ea fix(network-proxy): fail closed on network-proxy DNS lookup errors (#15909 )

## Summary

Fail closed when the network proxy's local/private IP pre-check hits a
DNS lookup error or timeout, instead of treating the hostname as public
and allowing the request.

## Root cause

`host_resolves_to_non_public_ip()` returned `false` on resolver failure,
which created a fail-open path in the `allow_local_binding = false`
boundary. The eventual connect path performs its own DNS resolution
later, so a transient pre-check failure is not evidence that the
destination is public.

## Changes

- Treat DNS lookup errors/timeouts as local/private for blocking
purposes
- Add a regression test for an allowlisted hostname that fails DNS
resolution

## Validation

- `cargo test -p codex-network-proxy`
- `cargo clippy -p codex-network-proxy --all-targets -- -D warnings`
- `just fmt`
- `just argument-comment-lint`

2026-03-26 23:18:04 +00:00

certs.rs

Apply argument comment lint across codex-rs (#14652 )

2026-03-16 16:48:15 -07:00

config.rs

Apply argument comment lint across codex-rs (#14652 )

2026-03-16 16:48:15 -07:00

http_proxy.rs

Apply argument comment lint across codex-rs (#14652 )

2026-03-16 16:48:15 -07:00

lib.rs

refactor: remove proxy admin endpoint (#13687 )