jif e67bc683f3
avoid cloning sampling request input ( #28306 ) ...
## Why
Every model request cloned the full prepared input just to keep it for
the legacy after-agent hook. That copy gets more expensive as the
conversation grows.
## What
Move the prepared input into the sampling loop and return it with the
result. If the request retries, keep the first input so the hook still
sees the same data as before.
This removes one `O(n)` clone per sampling request, where `n` is the
size of the prepared input. It saves `O(n)` copy work and `O(n)`
temporary memory.
No behavior change is intended.
## Performance
Local rollout traces show turns reaching roughly 260k input tokens. On
turns of that size, this removes the only unconditional full
prepared-input clone on the happy path. That avoids one request-sized
allocation/copy per sampling attempt for large conversations, and the
savings scale linearly with request size.
## Testing
- `just test -p codex-core continue_after_stream_error`
- `just fix -p codex-core`
2026-06-08 11:39:08 +02:00
2026-06-09 12:48:04 -07:00
2026-05-26 20:59:47 -07:00
2026-06-11 18:16:39 -07:00
2026-06-12 15:50:30 -07:00
2026-05-07 15:44:17 -07:00
2026-06-15 15:35:57 +00:00
2026-06-11 22:30:41 -07:00
2026-06-11 21:28:52 -07:00
2026-06-15 15:35:57 +00:00
2026-06-15 15:35:57 +00:00
2026-06-12 20:10:12 -07:00
2026-06-12 16:58:42 -07:00
2026-06-03 19:08:19 -07:00
2026-06-11 18:16:39 -07:00
2026-05-08 04:07:59 +00:00
2026-06-13 21:43:39 -07:00
2026-06-13 21:43:39 -07:00
2026-06-15 13:50:08 +01:00
2026-06-12 22:03:51 +00:00
2026-06-12 21:23:50 +00:00
2026-06-12 21:23:50 +00:00
2026-06-11 18:16:39 -07:00
2026-06-11 18:16:39 -07:00
2026-06-12 02:49:17 -07:00
2026-06-11 22:37:26 -07:00
2026-06-12 02:49:17 -07:00
2026-06-13 01:27:58 -07:00
2026-06-01 21:25:42 -07:00
2026-06-13 21:43:39 -07:00
2026-05-07 15:44:17 -07:00
2026-06-11 19:28:47 +00:00
2026-06-15 11:10:51 +02:00
2026-06-13 21:43:39 -07:00
2026-06-12 20:10:12 -07:00
2026-05-28 22:08:05 -07:00
2026-06-03 13:32:55 +02:00
2026-06-15 18:26:44 +02:00
2026-06-15 08:06:14 -07:00
2026-06-15 14:04:01 +01:00
2026-06-13 21:43:39 -07:00
2026-06-05 15:41:13 -07:00
2026-06-14 00:14:26 -07:00
2026-06-15 17:24:36 +02:00
2026-06-07 17:35:33 -07:00
2026-06-13 21:43:39 -07:00
2026-06-15 17:15:45 +02:00
2026-06-04 14:16:03 -04:00
2026-06-08 14:16:32 -04:00
2026-06-15 08:23:02 -07:00
2026-05-26 15:59:25 -07:00
2026-05-07 15:44:17 -07:00
2026-06-12 12:12:08 -07:00
2026-05-28 23:09:55 -07:00
2026-06-12 16:58:42 -07:00
2026-06-13 21:43:39 -07:00
2026-06-03 19:08:19 -07:00
2026-06-12 19:52:49 +00:00
2026-06-05 09:34:36 -07:00
2026-05-07 15:44:17 -07:00
2026-06-13 21:43:39 -07:00
2026-06-11 19:28:47 +00:00
2026-06-15 08:28:02 -07:00
2026-06-04 09:53:08 -04:00
2026-06-11 18:16:39 -07:00
2026-06-05 17:36:18 -07:00
2026-06-13 21:43:39 -07:00
2026-06-11 18:16:39 -07:00
2026-06-04 09:53:08 -04:00
2026-06-10 20:42:38 -07:00
2026-06-15 11:52:05 +02:00
2026-05-25 17:26:10 -03:00
2026-06-13 21:43:39 -07:00
2026-06-15 15:35:57 +00:00
2026-05-07 15:44:17 -07:00
2026-05-07 15:44:17 -07:00
2026-06-13 20:56:42 +00:00
2026-06-14 00:14:26 -07:00
2026-06-12 13:50:04 -07:00
2026-06-13 21:43:39 -07:00
2026-05-26 20:59:47 -07:00
2026-06-12 19:52:49 +00:00
2026-06-15 08:28:02 -07:00
2026-06-11 18:16:39 -07:00
2026-06-13 21:43:39 -07:00
2026-06-14 00:14:26 -07:00
2026-05-07 15:44:17 -07:00
2026-05-13 21:23:19 +00:00
2026-05-07 15:44:17 -07:00
2026-06-12 18:11:13 +00:00
2026-06-14 00:14:26 -07:00
2026-06-15 08:06:14 -07:00
2026-06-15 08:23:02 -07:00
2026-05-07 15:44:17 -07:00
2026-06-14 05:26:49 +00:00
2026-06-13 21:43:39 -07:00
2026-06-13 21:43:39 -07:00
2026-06-13 21:43:39 -07:00
2026-06-15 13:50:08 +01:00
2026-06-13 21:28:31 -07:00
2026-06-11 18:16:39 -07:00
2026-06-04 09:16:03 -07:00
2026-05-26 20:59:47 -07:00
jif
e67bc683f3