Eric Traut fa0e2ba87c Avoid false shell snapshot cleanup warnings (#18441) ...

## Why
Fresh app-server thread startup can create a shell snapshot through a
temp file and then promote it to the final snapshot path. The previous
implementation briefly wrapped the temp path in `ShellSnapshot`, so
after a successful rename its `Drop` attempted to delete the old temp
path and could log a false `ENOENT` warning.

Fixes #17549.

## What changed
- Validate the temp snapshot path directly before promotion.
- Rename the temp path directly to the final snapshot path.
- Keep explicit cleanup of the temp path on validation or finalization
failures.

fa0e2ba87c · 2026-04-20 15:15:05 +01:00

History

..

agent

chore: morpheus to path (#18353)

2026-04-20 10:32:20 +01:00

agent_identity

[codex] Use AgentAssertion downstream behind use_agent_identity (#17980)

2026-04-19 23:16:43 -07:00

apps

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

config

[codex] Use background agent task auth for backend calls (#18094)

2026-04-20 06:50:28 -07:00

config_loader

feat: add --ignore-user-config and --ignore-rules (#18646)

2026-04-20 11:27:47 +01:00

context_manager

Update image outputs to default to high detail (#18386)

2026-04-18 11:01:12 -07:00

guardian

fix(guardian) disable skills message in guardian thread (#18599)

2026-04-20 04:42:55 +00:00

instructions

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

memories

feat: add metric to track the number of turns with memory usage (#18662)

2026-04-20 14:31:22 +01:00

plugins

[codex] Add marketplace remove command and shared logic (#17752)

2026-04-17 21:44:47 -07:00

sandboxing

Build remote exec env from exec-server policy (#17216)

2026-04-13 09:59:08 +01:00

session

[codex] Use background agent task auth for backend calls (#18094)

2026-04-20 06:50:28 -07:00

state

feat: add metric to track the number of turns with memory usage (#18662)

2026-04-20 14:31:22 +01:00

tasks

feat: add metric to track the number of turns with memory usage (#18662)

2026-04-20 14:31:22 +01:00

tools

Update image outputs to default to high detail (#18386)

2026-04-18 11:01:12 -07:00

unified_exec

[3/6] Add pushed exec process events (#18020)

2026-04-17 19:07:43 +00:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

agent_identity.rs

[codex] Use background agent task auth for backend calls (#18094)

2026-04-20 06:50:28 -07:00

agents_md_tests.rs

Refactor AGENTS.md discovery into AgentsMdManager (#18035)

2026-04-16 10:51:33 -07:00

agents_md.rs

Refactor AGENTS.md discovery into AgentsMdManager (#18035)

2026-04-16 10:51:33 -07:00

apply_patch_tests.rs

[codex] Migrate apply_patch to executor filesystem (#17027)

2026-04-07 21:20:22 +00:00

apply_patch.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

arc_monitor_tests.rs

[codex] Use AgentAssertion downstream behind use_agent_identity (#17980)

2026-04-19 23:16:43 -07:00

arc_monitor.rs

[codex] Use AgentAssertion downstream behind use_agent_identity (#17980)

2026-04-19 23:16:43 -07:00

client_common_tests.rs

fix(app-server) revert null instructions changes (#17047)

2026-04-07 15:18:34 -07:00

client_common.rs

fix(app-server) revert null instructions changes (#17047)

2026-04-07 15:18:34 -07:00

client_tests.rs

[codex] Use AgentAssertion downstream behind use_agent_identity (#17980)

2026-04-19 23:16:43 -07:00

client.rs

feat: add mem 2 agent header (#18644)

2026-04-20 09:58:32 +01:00

codex_delegate_tests.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

codex_delegate.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

codex_thread.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

commit_attribution_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

commit_attribution.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

compact_remote.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

compact_tests.rs

Update image outputs to default to high detail (#18386)

2026-04-18 11:01:12 -07:00

compact.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

connectors_tests.rs

Make app tool hint defaults pessimistic for app policies (#17232)

2026-04-17 13:27:49 -04:00

connectors.rs

[codex] Use background agent task auth for backend calls (#18094)

2026-04-20 06:50:28 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

contextual_user_message_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

contextual_user_message.rs

Extract codex-instructions crate (#15744)

2026-03-25 10:43:49 -07:00

environment_context_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

environment_context.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

event_mapping_tests.rs

Update image outputs to default to high detail (#18386)

2026-04-18 11:01:12 -07:00

event_mapping.rs

Update image outputs to default to high detail (#18386)

2026-04-18 11:01:12 -07:00

exec_env_tests.rs

fix: preserve platform-specific core shell env vars (#16707)

2026-04-03 12:07:07 -07:00

exec_env.rs

Build remote exec env from exec-server policy (#17216)

2026-04-13 09:59:08 +01:00

exec_policy_tests.rs

fix: exec policy loading for sub-agents (#18654)

2026-04-20 11:51:58 +01:00

exec_policy.rs

fix: exec policy loading for sub-agents (#18654)

2026-04-20 11:51:58 +01:00

exec_tests.rs

feat(permissions): add glob deny-read policy support (#15979)

2026-04-16 10:31:51 -07:00

exec.rs

feat(permissions): add glob deny-read policy support (#15979)

2026-04-16 10:31:51 -07:00

external_agent_config_tests.rs

Add fallback source for external official marketplace (#18524)

2026-04-19 11:04:13 -07:00

external_agent_config.rs

Add fallback source for external official marketplace (#18524)

2026-04-19 11:04:13 -07:00

file_watcher_tests.rs

fix: FS watcher when file does not exist yet (#18492)

2026-04-20 11:23:00 +01:00

file_watcher.rs

fix: FS watcher when file does not exist yet (#18492)

2026-04-20 11:23:00 +01:00

flags.rs

chore: drop unused values from env_flags (#4188)

2025-09-24 14:29:51 -07:00

function_tool.rs

nit: drop unused function call error (#8903)

2026-01-08 15:07:30 +00:00

git_info_tests.rs

Refactor config loading to use filesystem abstraction (#18209)

2026-04-17 00:51:21 +00:00

hook_runtime.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

installation_id.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

landlock.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

lib.rs

Add codex debug models to show model catalog (#18625)

2026-04-20 05:42:22 +00:00

mcp_openai_file.rs

[codex] Use AgentAssertion downstream behind use_agent_identity (#17980)

2026-04-19 23:16:43 -07:00

mcp_skill_dependencies.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

mcp_tool_approval_templates.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

mcp_tool_call_tests.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

mcp_tool_call.rs

feat: config aliases (#18140)

2026-04-17 18:26:09 +01:00

mcp_tool_exposure_test.rs

add token-based tool deferral behind feature flag (#18097)

2026-04-17 18:34:06 +08:00

mcp_tool_exposure.rs

add token-based tool deferral behind feature flag (#18097)

2026-04-17 18:34:06 +08:00

mcp.rs

[codex] Use background agent task auth for backend calls (#18094)

2026-04-20 06:50:28 -07:00

memory_trace_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

memory_trace.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

message_history_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

message_history.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

network_policy_decision_tests.rs

extract models manager and related ownership from core (#16508)

2026-04-02 23:00:02 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

network_proxy_loader_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

network_proxy_loader.rs

Refactor config loading to use filesystem abstraction (#18209)

2026-04-17 00:51:21 +00:00

original_image_detail.rs

Support original-detail metadata on MCP image outputs (#17714)

2026-04-15 14:43:33 -07:00

otel_init.rs

Use AbsolutePathBuf in skill loading and codex_home (#17407)

2026-04-13 10:26:51 -07:00

personality_migration_tests.rs

[codex] Add local thread store listing (#17824)

2026-04-15 11:34:27 -07:00

personality_migration.rs

Add sorting/backwardsCursor to thread/list and new thread/turns/list api (#17305)

2026-04-17 11:49:02 -07:00

prompt_debug.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

realtime_context_tests.rs

Refactor config loading to use filesystem abstraction (#18209)

2026-04-17 00:51:21 +00:00

realtime_context.rs

Add sorting/backwardsCursor to thread/list and new thread/turns/list api (#17305)

2026-04-17 11:49:02 -07:00

realtime_conversation_tests.rs

Wrap delegated input text (#17868)

2026-04-14 19:58:58 -07:00

realtime_conversation.rs

Log realtime session id (#18571)

2026-04-19 11:23:25 -07:00

realtime_prompt.rs

[codex] Update realtime V2 VAD silence delay and 1.5 prompt (#18092)

2026-04-16 14:30:57 -07:00

review_format.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

review_prompts.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

rollout.rs

Add sorting/backwardsCursor to thread/list and new thread/turns/list api (#17305)

2026-04-17 11:49:02 -07:00

safety_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

safety.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

sandbox_tags_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

sandbox_tags.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

session_prefix.rs

feat: change multi-agent to use path-like system instead of uuids (#15313)

2026-03-20 18:23:48 +00:00

session_rollout_init_error.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

session_startup_prewarm.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

shell_detect.rs

chore: rename codex-command to codex-shell-command (#11378)

2026-02-10 17:03:46 -08:00

shell_snapshot_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

shell_snapshot.rs

Avoid false shell snapshot cleanup warnings (#18441)

2026-04-20 15:15:05 +01:00

shell_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

shell.rs

fix: add shell fallback paths for pwsh/powershell that work on GitHub Actions Windows runners (#16617)

2026-04-02 13:47:10 -07:00

skills_watcher.rs

Make skill loading filesystem-aware (#17720)

2026-04-14 15:40:40 -07:00

skills.rs

feat: Budget skill metadata and surface trimming as a warning (#18298)

2026-04-17 18:11:47 -07:00

spawn.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

state_db_bridge.rs

[codex] reduce module visibility (#16978)

2026-04-07 08:03:35 -07:00

stream_events_utils_tests.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

stream_events_utils.rs

feat: add metric to track the number of turns with memory usage (#18662)

2026-04-20 14:31:22 +01:00

test_support.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

thread_manager_tests.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

thread_manager.rs

Add codex debug models to show model catalog (#18625)

2026-04-20 05:42:22 +00:00

thread_rollout_truncation_tests.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

thread_rollout_truncation.rs

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

turn_diff_tracker_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_diff_tracker.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

turn_metadata_tests.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

turn_metadata.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

turn_timing_tests.rs

feat: add memory citation to agent message (#14821)

2026-03-18 10:03:38 +00:00

turn_timing.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

unavailable_tool.rs

[mcp] Add dummy tools for previously called but currently missing tools. (#17853)

2026-04-15 21:48:05 +00:00

user_shell_command_tests.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

user_shell_command.rs

Move codex module under session (#18249)

2026-04-17 16:18:53 +00:00

util_tests.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

util.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

web_search.rs

add missing fields to WebSearchAction and update app-server types (#10276)

2026-01-30 16:37:56 -08:00

windows_sandbox_read_grants_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_read_grants.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_tests.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00

windows_sandbox.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00