mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
Adam Perry @ OpenAI
efbd00f21f
## Why Next slice needed to make progress on the `remote_env_windows` test is to support passing a Windows cwd for the remote environment and using that environment's native shell. This lets the test run a real Windows process instead of only recording an early path or shell mismatch. ## What - change `TurnEnvironmentSelection.cwd` from `AbsolutePathBuf` to `PathUri` - convert local cwd values to URIs when constructing selections - preserve a remote primary cwd instead of replacing it with the local legacy fallback - prefer the selected environment's discovered shell for unified exec, falling back to the session shell when unavailable - convert back to a host-native absolute path at current native-only consumer boundaries - reject or deny unsupported foreign cwd values at the existing request-permissions boundary, with TODOs for its future migration - extend the hermetic Wine test to execute Windows PowerShell in `C:\windows` and verify successful process completion - record the current app-server rejection against the same Wine-backed remote Windows fixture when its cwd is supplied as a native Windows path
33 lines
994 B
Python
33 lines
994 B
Python
load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_library")
|
|
|
|
rust_library(
|
|
name = "wine-exec-server-test-support",
|
|
testonly = True,
|
|
srcs = ["wine_exec_server.rs"],
|
|
crate_name = "wine_exec_server_test_support",
|
|
crate_root = "wine_exec_server.rs",
|
|
target_compatible_with = ["@platforms//os:linux"],
|
|
visibility = ["//codex-rs/core/tests/remote_env_windows:__pkg__"],
|
|
deps = [
|
|
"//bazel/rules/testing/wine:wine_test_support",
|
|
"//codex-rs/utils/cargo-bin",
|
|
"@crates//:anyhow",
|
|
"@crates//:tokio",
|
|
],
|
|
)
|
|
|
|
rust_binary(
|
|
name = "windows-exec-server",
|
|
testonly = True,
|
|
srcs = ["windows_exec_server.rs"],
|
|
crate_name = "windows_exec_server",
|
|
crate_root = "windows_exec_server.rs",
|
|
tags = ["manual"],
|
|
target_compatible_with = ["@platforms//os:windows"],
|
|
visibility = ["//codex-rs/core/tests/remote_env_windows:__pkg__"],
|
|
deps = [
|
|
"//codex-rs/exec-server",
|
|
"@crates//:tokio",
|
|
],
|
|
)
|