mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Adam Perry @ OpenAIandGitHub df1ee09ec5 mcp: keep elicitation requests below app wire types (#29724 )

## Why

Core and tools need to request MCP elicitation without constructing
app-server wire payloads. The request should remain a neutral protocol
concept until app-server serializes it for a client.

## What changed

- Switched core and tools to
`codex_protocol::approvals::ElicitationRequest`.
- Derived turn and server context inside core instead of carrying
app-server request types through lower layers.
- Kept the app-server payload unchanged through an explicit boundary
conversion.
- Removed the remaining production app-server-protocol dependency from
tools.

## Stack

This is PR 5 of 6, stacked on [PR
#29723](https://github.com/openai/codex/pull/29723). Review only the
delta from `codex/split-connector-metadata-types`. Next: [PR
#29725](https://github.com/openai/codex/pull/29725).

## Validation

- `codex-core` MCP coverage passed: 87 tests.
- Tools elicitation and app-server round-trip coverage passed.

2026-06-24 20:53:27 +00:00

.cargo

Ignore proc-macro-error2 advisory (#26974 )

2026-06-08 11:39:08 +02:00

.config

[codex] Speed up local nextest runs (#26479 )

2026-06-09 12:48:04 -07:00

.github/workflows

Uprev Rust toolchain pins to 1.95.0 (#24684 )

2026-05-26 20:59:47 -07:00

agent-graph-store

[codex] Inject agent graph store into ThreadManager (#29736 )

2026-06-24 13:24:10 -07:00

agent-identity

Allow ChatGPT accounts without email (#28991 )

2026-06-22 13:19:40 -07:00

analytics

Support thread-level originator overrides (#29477 )

2026-06-23 17:23:38 -07:00

ansi-escape

…

app-server

[apps] Thread structured icon assets through app list (#29889 )

2026-06-24 13:25:44 -07:00

app-server-client

Support openai/form extended form elicitations (#27500 )

2026-06-18 11:54:49 -07:00

app-server-daemon

feat(app-server): persist remote-control desired state (#27445 )

2026-06-11 21:28:52 -07:00

app-server-protocol

[apps] Thread structured icon assets through app list (#29889 )

2026-06-24 13:25:44 -07:00

app-server-test-client

feat(app-server): list descendant threads by ancestor (#29591 )

2026-06-24 13:08:14 -07:00

app-server-transport

auth: move domain mode below app wire types (#29721 )

2026-06-24 03:10:20 +00:00

apply-patch

path-uri: clarify host-native path conversion (#29501 )

2026-06-23 00:02:33 +00:00

arg0

apply-patch: carry paths as PathUri (#28854 )

2026-06-18 19:31:19 +00:00

async-utils

[codex] Remove async_trait from first-party code (#27475 )

2026-06-11 18:16:39 -07:00

aws-auth

…

backend-client

Add workspace messages app-server API (#29001 )

2026-06-22 04:25:07 -07:00

bwrap

build: run buildifier from just fmt (#28125 )

2026-06-13 21:43:39 -07:00

chatgpt

[apps] Thread structured icon assets through app list (#29889 )

2026-06-24 13:25:44 -07:00

cli

Keep executor plugin MCP paths URI-native (#29628 )

2026-06-24 09:46:07 +01:00

cloud-config

Allow ChatGPT accounts without email (#28991 )

2026-06-22 13:19:40 -07:00

cloud-tasks

PAC 2 - Add shared auth system proxy contract (#26707 )

2026-06-22 13:03:11 -07:00

cloud-tasks-client

[codex] Remove async_trait from first-party code (#27475 )

2026-06-11 18:16:39 -07:00

cloud-tasks-mock-client

[codex] Remove async_trait from first-party code (#27475 )

2026-06-11 18:16:39 -07:00

code-mode

code-mode: Remove Session::is_alive() (#29732 )

2026-06-23 15:14:13 -07:00

code-mode-host

code-mode standalone: extract protocol and add host crate (#27724 )

2026-06-11 22:37:26 -07:00

code-mode-protocol

code-mode: Remove Session::is_alive() (#29732 )

2026-06-23 15:14:13 -07:00

codex-api

[codex] Use input items for Responses Lite tools (#27946 )

2026-06-22 23:56:16 -07:00

codex-backend-openapi-models

feat: show enterprise monthly credit limits in status (#24812 )

2026-06-01 21:25:42 -07:00

codex-client

PAC 4 - Add macOS system proxy resolver (#26709 )

2026-06-22 17:56:04 -07:00

codex-experimental-api-macros

…

codex-home

[codex] Bind shell snapshots to retained thread environments (#28421 )

2026-06-15 20:10:53 -07:00

codex-mcp

Keep executor plugin MCP paths URI-native (#29628 )

2026-06-24 09:46:07 +01:00

collaboration-mode-templates

[prompting] updated plan mode prompt (#29301 )

2026-06-21 13:35:25 -07:00

config

config: own layer provenance types (#29722 )

2026-06-24 04:03:04 +00:00

connectors

[apps] Thread structured icon assets through app list (#29889 )

2026-06-24 13:25:44 -07:00

context-fragments

core: rename metadata -> internal_chat_message_metadata_passthrough (#28968 )

2026-06-22 11:11:25 -07:00

core

mcp: keep elicitation requests below app wire types (#29724 )

2026-06-24 20:53:27 +00:00

core-api

[codex] Inject agent graph store into ThreadManager (#29736 )

2026-06-24 13:24:10 -07:00

core-plugins

Keep executor plugin MCP paths URI-native (#29628 )

2026-06-24 09:46:07 +01:00

core-skills

Follow directory symlinks in filesystem walks (#29844 )

2026-06-24 20:52:36 +01:00

docs

protocol: remove submission-side serde from Op (#26674 )

2026-06-05 15:41:13 -07:00

exec

feat(app-server): list descendant threads by ancestor (#29591 )

2026-06-24 13:08:14 -07:00

exec-server

Follow directory symlinks in filesystem walks (#29844 )

2026-06-24 20:52:36 +01:00

exec-server-protocol

[codex] Trace exec-server JSON-RPC requests (#27466 )

2026-06-24 12:50:18 -07:00

execpolicy

[codex] Use expect in integration tests (#28441 )

2026-06-15 21:53:47 -07:00

execpolicy-legacy

build: run buildifier from just fmt (#28125 )

2026-06-13 21:43:39 -07:00

ext

Keep executor plugin MCP paths URI-native (#29628 )

2026-06-24 09:46:07 +01:00

external-agent-migration

[codex] Preserve skill descriptions outside model context (#29006 )

2026-06-19 12:47:53 -07:00

external-agent-sessions

core: rename metadata -> internal_chat_message_metadata_passthrough (#28968 )

2026-06-22 11:11:25 -07:00

features

[codex] Remove auto-compaction opt-out (#29815 )

2026-06-24 00:15:04 -07:00

feedback

Attach Windows sandbox log to feedback reports (#24623 )

2026-05-26 15:59:25 -07:00

file-search

…

file-system

Follow directory symlinks in filesystem walks (#29844 )

2026-06-24 20:52:36 +01:00

file-watcher

Fix fs/watch debounce batching (#24716 )

2026-05-28 23:09:55 -07:00

git-utils

[codex] make PathUri::from_abs_path infallible (#27976 )

2026-06-12 16:58:42 -07:00

hooks

Respect blocking PostToolUse hooks in code mode (#28365 )

2026-06-15 15:12:26 -07:00

install-context

cli: add package path from install context (#26189 )

2026-06-03 19:08:19 -07:00

keyring-store

feat: add auth-specific encrypted secret namespaces (#27535 )

2026-06-12 19:52:49 +00:00

linux-sandbox

Add network environment ID plumbing (#28766 )

2026-06-18 14:09:38 +02:00

lmstudio

…

auth: move domain mode below app wire types (#29721 )

2026-06-24 03:10:20 +00:00

mcp-server

[codex] Inject agent graph store into ThreadManager (#29736 )

2026-06-24 13:24:10 -07:00

memories

Persist agent messages as response items (#29829 )

2026-06-24 15:43:10 +01:00

message-history

Optimize unbounded byte scans with memchr (#26265 )

2026-06-04 09:53:08 -04:00

model-provider

chore: improve expired Bedrock credential errors (#28992 )

2026-06-23 00:53:09 +00:00

model-provider-info

auth: move domain mode below app wire types (#29721 )

2026-06-24 03:10:20 +00:00

models-manager

auth: move domain mode below app wire types (#29721 )

2026-06-24 03:10:20 +00:00

network-proxy

feat(network-proxy): experimental local credential broker (#28034 )

2026-06-24 13:21:16 -07:00

ollama

Optimize unbounded byte scans with memchr (#26265 )

2026-06-04 09:53:08 -04:00

otel

auth: move domain mode below app wire types (#29721 )

2026-06-24 03:10:20 +00:00

plugin

Make selected plugin roots URI-native (#28918 )

2026-06-23 22:51:19 +01:00

process-hardening

fix(process-hardening): preserve macos malloc diagnostics (#24479 )

2026-05-25 17:26:10 -03:00

prompts

chore(core) rm AskForApproval::OnFailure (#28418 )

2026-06-23 12:13:54 -07:00

protocol

Persist agent messages as response items (#29829 )

2026-06-24 15:43:10 +01:00

realtime-webrtc

…

response-debug-context

Add safety check notification and error handling (#19055 )

2026-04-22 22:24:12 -07:00

responses-api-proxy

…

rmcp-client

[codex] trace MCP startup latency (#28630 )

2026-06-23 17:46:54 -07:00

rollout

feat(app-server): list descendant threads by ancestor (#29591 )

2026-06-24 13:08:14 -07:00

rollout-trace

[codex] Use input items for Responses Lite tools (#27946 )

2026-06-22 23:56:16 -07:00

sandboxing

[codex] Preserve proxy state for filesystem sandbox helpers (#29671 )

2026-06-23 12:29:46 -07:00

scripts

Uprev Rust toolchain pins to 1.95.0 (#24684 )

2026-05-26 20:59:47 -07:00

secrets

feat: add auth-specific encrypted secret namespaces (#27535 )

2026-06-12 19:52:49 +00:00

shell-command

[codex] Reject unlowered PowerShell AST regions (#24092 )

2026-06-23 03:09:20 +00:00

shell-escalation

[codex] Remove async_trait from first-party code (#27475 )

2026-06-11 18:16:39 -07:00

skills

[codex] Update bundled skill installer guidance (#29768 )

2026-06-23 19:36:17 -07:00

state

feat(app-server): list descendant threads by ancestor (#29591 )

2026-06-24 13:08:14 -07:00

stdio-to-uds

…

terminal-detection

feat(cli): add codex doctor diagnostics (#22336 )

2026-05-13 21:23:19 +00:00

test-binary-support

Disable empty Cargo test targets (#21584 )

2026-05-07 15:44:17 -07:00

thread-manager-sample

[codex] Inject agent graph store into ThreadManager (#29736 )

2026-06-24 13:24:10 -07:00

thread-store

feat(app-server): list descendant threads by ancestor (#29591 )

2026-06-24 13:08:14 -07:00

tools

mcp: keep elicitation requests below app wire types (#29724 )

2026-06-24 20:53:27 +00:00

tui

[apps] Thread structured icon assets through app list (#29889 )

2026-06-24 13:25:44 -07:00

uds

…

utils

[codex] fix Windows ConPTY input handling (#29734 )

2026-06-24 11:27:44 -07:00

v8-poc

build: run buildifier from just fmt (#28125 )

2026-06-13 21:43:39 -07:00

vendor

build: run buildifier from just fmt (#28125 )

2026-06-13 21:43:39 -07:00

windows-sandbox-rs

Skip credential refresh for WindowsApps launch failures (#29637 )

2026-06-24 20:59:53 +01:00

.gitignore

…

BUILD.bazel

…

Cargo.lock

mcp: keep elicitation requests below app wire types (#29724 )

2026-06-24 20:53:27 +00:00

Cargo.toml

[codex] Inject agent graph store into ThreadManager (#29736 )

2026-06-24 13:24:10 -07:00

clippy.toml

chore: document intentional await-holding cases (#18423 )

2026-04-20 22:41:54 -07:00

config.md

…

default.nix

…

deny.toml

[codex] Remove async_trait from first-party code (#27475 )

2026-06-11 18:16:39 -07:00

README.md

Simplify Codex CLI README (#26313 )

2026-06-04 09:16:03 -07:00

rust-toolchain.toml

Uprev Rust toolchain pins to 1.95.0 (#24684 )

2026-05-26 20:59:47 -07:00

rustfmt.toml

Update cargo to 2024 edition (#842 )

2025-05-07 08:37:48 -07:00

README.md

Codex CLI

Codex CLI Documentation