mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Adam Perry @ OpenAI 5867b529ae unified-exec: preserve PathUri through exec-server (#28681 )

## Why

It should be possible for app-server to handle "foreign" OS paths in
unified_exec working directories, allowing e.g. a Linux app-server to
run processes on e.g. a Windows exec-server.

## What

Convert the core unified_exec cwd values to use `PathUri`.

Adds fallible path conversion in several places to try to minimize the
scope of this change. The only time this change suppresses errors from
converting `PathUri` to an `AbsolutePathBuf` is when the turn is
configured with no sandboxing at all to allow us to make progress
testing without sandboxing.

Future changes to apply_patch and sandboxing will clean up these error
paths.

A tool's cwd is resolved from joining a model-provided workdir to the
environment's cwd. When using `AbsolutePathBuf::join()`, an
absolute-path workdir would overwrite the environment's cwd and we would
resolve permissions/sandboxing against the model-provided path. This
change extends `PathUri::join()` to also treat an absolute rhs as an
override of the base/lhs.

This also removes some coverage from the remove_env_windows tests until
a follow-up converts foreign paths in command exec events correctly.

## Breaking Changes

When using `AbsolutePathBuf::join()` for workdir resolution, we ended up
resolving tilde-prefixed paths against the app-server's `$HOME`, e.g.
`~/foo/bar` becomes `/home/anp/foo/bar`. It's difficult to do this with
`PathUri` joining, so after offline discussion this PR no longer
implements it.

A quick check of some power users' rollouts suggests that models don't
actually generate home-prefixed absolute working directories for their
spawns, so this shouldn't have any real blast radius.

5867b529ae · 2026-06-17 19:36:16 +00:00

History

BUILD.bazel

app-server: preserve target-native environment cwd (#28146 )

2026-06-16 21:42:28 +00:00

README.md

Run core integration tests against a Wine-backed Windows executor (#28401 )

2026-06-16 00:38:41 +00:00

remote_env_windows_test.rs

unified-exec: preserve PathUri through exec-server (#28681 )

2026-06-17 19:36:16 +00:00

README.md

Windows remote-environment test

This Bazel-only test_codex integration test runs a Windows exec-server fixture under pinned Wine and exercises the normal model tool-call and remote-execution path.

Running the test

bazel test \
  //codex-rs/core/tests/remote_env_windows:smoke-test \
  --test_output=errors

No system Wine is required. Every process gets a fresh WINEPREFIX and isolated wineserver.

Current limitations

ConPTY/TTY behavior is not yet covered.
Wine loads shared objects and PE DLLs at runtime, so the host must still provide the declared compatible glibc version.
The target is intentionally limited to x86-64 for simplicity. It can expand if we find aarch64-specific behavior worth testing.