Michael Bolin d58df28286 fix: change shutdown_flag from Arc<AtomicBool> to tokio::sync::Notify (#2394) ...

Prior to this PR, we had:

https://github.com/openai/codex/blob/71cae06e6643b4adf644d9769208c3c5fcd1f2be/codex-rs/login/src/server.rs#L141-L142

which means that we could be blocked waiting for a new request in
`server_for_thread.recv()` and not notice that the state of
`shutdown_flag` had changed.

With this PR, we use `shutdown_flag: Notify` so that we can
`tokio::select!` on `shutdown_notify.notified()` and `rx.recv()` (which
is the "async stream" of requests read from `server_for_thread.recv()`)
and handle whichever one happens first.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/2394).
* #2399
* #2398
* #2396
* #2395
* __->__ #2394
* #2393
* #2389

d58df28286 · 2025-08-19 00:32:03 +00:00

History

..

src

fix: change shutdown_flag from Arc<AtomicBool> to tokio::sync::Notify (#2394)

2025-08-19 00:32:03 +00:00

tests

tui: standardize tree prefix glyphs to └ (#2274)

2025-08-13 19:14:03 -04:00

Cargo.toml

replace /prompts with a rotating placeholder (#2314)

2025-08-15 19:37:10 -07:00

prompt_for_init_command.md

chore: rename INIT.md to prompt_for_init_command.md and move closer to usage (#1886)

2025-08-06 11:58:57 -07:00

styles.md

fix: stop using ANSI blue (#2421)

2025-08-18 16:02:25 +00:00