codex

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Adam Perry @ OpenAI db531b4a6c [codex] Outline ToolExecutor handler bodies (#27299 )

## Why

We're now [discouraging use of
`async_trait`](https://github.com/openai/codex/pull/20242).

Removing use of `async_trait` from `ToolExecutor` yields a `codex_core`
debug test build speedup of ~78% (from 227.5s to 50.3s) on my machine.

For ease of reviewing, this is a prefactor to extract trait method
implementations to inherent methods. This will prevent changing
indentation from creating a huge diff.

## What

Outlined existing `ToolExecutor::handle` bodies into inherent async
`handle_call` methods across core and extension tool handlers.

The trait methods still use `async_trait` and now delegate to
`self.handle_call(...).await`; handler behavior is unchanged.

db531b4a6c · 2026-06-10 09:40:41 -07:00

History

extension-api

Remove async-trait from extension contributors (#27383 )

2026-06-10 14:31:09 +02:00

goal

Remove async-trait from extension contributors (#27383 )

2026-06-10 14:31:09 +02:00

guardian

Remove async-trait from extension contributors (#27383 )

2026-06-10 14:31:09 +02:00

image-generation