codex

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

hxreborn 0e8d937a3f Strip zsh -lc wrapper from TUI command headers (#5374 )

Extends shell wrapper stripping in TUI to handle `zsh -lc` in addition
to `bash -lc`.

Currently, Linux users (and macOS users with zsh profiles) see cluttered
command headers like `• Ran zsh -lc "echo hello"` instead of `• Ran echo
hello`. This happens because `codex-rs/tui/src/exec_command.rs` only
checks for literal `"bash"`, ignoring `zsh` and absolute paths like
`/usr/bin/zsh`.

**Changes:**
- Added `is_login_shell_with_lc` helper that extracts shell basename and
matches against `bash` or `zsh`
- Updated pattern matching to use the helper instead of hardcoded check
- Added test coverage for zsh and absolute paths (`/usr/bin/zsh`,
`/bin/bash`)

**Testing:**
```bash
cd codex-rs
cargo test strip_bash_lc_and_escape -p codex-tui
```

All 4 test cases pass (bash, zsh, and absolute paths for both).

Closes #4201

0e8d937a3f · 2025-10-20 10:24:39 -07:00

History

frames

2025-09-15 00:42:53 -07:00

src

Strip zsh -lc wrapper from TUI command headers (#5374 )

2025-10-20 10:24:39 -07:00

tests

feat: add Vec<ParsedCommand> to ExecApprovalRequestEvent (#5222 )

2025-10-15 13:58:40 -07:00

Cargo.toml

Add log upload support (#5257 )