mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Michael Bolin 313fb95989 ci: keep rust-ci-full Windows argument-comment-lint on packaged wrapper (#16130 )

## Why

PR #16106 switched `rust-ci-full` over to the native Bazel-backed
`argument-comment-lint` path on all three platforms.

That works on Linux and macOS, but the Windows leg in `rust-ci-full` now
fails before linting starts: Bazel dies while building `rules_rust`'s
`process_wrapper` tool, so `main` reports an `argument-comment-lint`
failure even though no Rust lint finding was produced.

Until native Windows Bazel linting is repaired, `rust-ci-full` should
keep the same Windows split that `rust-ci.yml` already uses.

## What changed

- restored the Windows-only nightly `argument-comment-lint` toolchain
setup in `rust-ci-full`
- limited the Bazel-backed lint step in `rust-ci-full` to non-Windows
runners
- routed the Windows runner back through
`tools/argument-comment-lint/run-prebuilt-linter.py`
- left the Linux and macOS `rust-ci-full` behavior unchanged

## Test plan

- loaded `.github/workflows/rust-ci-full.yml` and
`.github/workflows/rust-ci.yml` with `python3` + `yaml.safe_load(...)`
- inspected failing Actions run `23692864849`, especially job
`69023229311`, to confirm the Windows failure occurs in Bazel
`process_wrapper` setup before lint output is emitted

## References

- #16106

313fb95989 · 2026-03-28 14:50:19 -07:00

History

bazel.yml

build: migrate argument-comment-lint to a native Bazel aspect (#16106 )

2026-03-28 12:41:56 -07:00

blob-size-policy.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

cargo-deny.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

ci.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

cla.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

close-stale-contributor-prs.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

codespell.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

Dockerfile.bazel

ci(bazel): install Node from node-version.txt in remote image (#12205 )

2026-02-20 11:51:17 -08:00

issue-deduplicator.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

issue-labeler.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

README.md

ci: split fast PR Rust CI from full post-merge Cargo CI (#16072 )

2026-03-27 21:08:08 -07:00

rust-ci-full.yml

ci: keep rust-ci-full Windows argument-comment-lint on packaged wrapper (#16130 )

2026-03-28 14:50:19 -07:00

rust-ci.yml

build: migrate argument-comment-lint to a native Bazel aspect (#16106 )

2026-03-28 12:41:56 -07:00

rust-release-argument-comment-lint.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release-prepare.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release-windows.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release-zsh.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rust-release.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

rusty-v8-release.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

sdk.yml

ci: run SDK tests with a Bazel-built codex (#16046 )

2026-03-27 17:17:22 -07:00

v8-canary.yml

[codex] Pin GitHub Actions workflow references (#15828 )

2026-03-27 23:00:05 +00:00

zstd

ci(windows): use DotSlash for zstd in rust-release-windows (#11542 )

2026-02-11 20:57:11 -08:00

README.md

Workflow Strategy

The workflows in this directory are split so that pull requests get fast, review-friendly signal while main still gets the full cross-platform verification pass.

Pull Requests

bazel.yml is the main pre-merge verification path for Rust code. It runs Bazel test and Bazel clippy on the supported Bazel targets.
rust-ci.yml keeps the Cargo-native PR checks intentionally small:
- cargo fmt --check
- cargo shear
- argument-comment-lint on Linux, macOS, and Windows
- tools/argument-comment-lint package tests when the lint or its workflow wiring changes

The PR workflow still keeps the Linux lint lane on the default-targets-only invocation for now, but the released linter runs on Linux, macOS, and Windows before merge.

Post-Merge On `main`

bazel.yml also runs on pushes to main. This re-verifies the merged Bazel path and helps keep the BuildBuddy caches warm.
rust-ci-full.yml is the full Cargo-native verification workflow. It keeps the heavier checks off the PR path while still validating them after merge:
- the full Cargo clippy matrix
- the full Cargo nextest matrix
- release-profile Cargo builds
- cross-platform argument-comment-lint
- Linux remote-env tests

Rule Of Thumb

If a build/test/clippy check can be expressed in Bazel, prefer putting the PR-time version in bazel.yml.
Keep rust-ci.yml fast enough that it usually does not dominate PR latency.
Reserve rust-ci-full.yml for heavyweight Cargo-native coverage that Bazel does not replace yet.

README.md

Workflow Strategy

Pull Requests

Post-Merge On main

Rule Of Thumb

Post-Merge On `main`