codex

mirror of https://github.com/pchuan98/codex.git synced 2026-07-01 00:31:56 +08:00

Files

T

Robby He 1a5809624d fix: Prevent slash command popup from activating on invalid inputs (#7704 )

## Slash Command popup issue

#7659

When recalling history, the
composer(`codex_tui::bottom_pane::chat_composer`) restores the previous
prompt text (which may start with `/`) and then calls
`sync_command_popup`. The logic in `sync_command_popup` treats any first
line that starts with `/` and has the caret inside the initial `/name`
token as an active slash command name:

```rust
let is_editing_slash_command_name = if first_line.starts_with('/') && caret_on_first_line {
    let token_end = first_line
        .char_indices()
        .find(|(_, c)| c.is_whitespace())
        .map(|(i, _)| i)
        .unwrap_or(first_line.len());
    cursor <= token_end
} else {
    false
};
```

This detection does not distinguish between an actual interactive slash
command being typed and a normal historical prompt that happens to begin
with `/`. As a result, after history recall, the restored prompt like `/
test` is interpreted as an "editing command name" context and the
slash-command popup is (re)activated. Once `active_popup` is
`ActivePopup::Command`, subsequent `Up` key presses are handled by
`handle_key_event_with_slash_popup` instead of
`handle_key_event_without_popup`, so they no longer trigger
`history.navigate_up(...)` and the session prompt history cannot be
scrolled.

1a5809624d · 2025-12-10 11:38:15 -08:00

History

frames

2025-09-15 00:42:53 -07:00

src

fix: Prevent slash command popup from activating on invalid inputs (#7704 )

2025-12-10 11:38:15 -08:00

tests

chore: delete chatwidget::tests::binary_size_transcript_snapshot tui test (#6759 )

2025-11-17 11:11:41 -08:00

Cargo.toml

Wire with_remote_overrides to construct model families (#7621 )