pakrym-oaiandGitHub daf0f03ac8 Ensure shell command skills trigger approval (#12697) ...

Summary
- detect skill-invoking shell commands based on the original command
string, request approvals when needed, and cache positive decisions per
session
- keep implicit skill invocation emitted after approval and keep skill
approval decline messaging centralized to the shell handler
- expand and adjust skill approval tests to cover shell-based skill
scripts while matching the new detection expectations

Testing
- Not run (not requested)

2026-02-24 12:13:20 -08:00

..

snapshots

Fix compaction context reinjection and model baselines (#12252)

2026-02-20 23:13:08 -08:00

abort_tasks.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

agent_websocket.rs

Send warmup request (#11258)

2026-02-24 08:15:47 -08:00

apply_patch_cli.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

approvals.rs

feat(core) Introduce Feature::RequestPermissions (#11871)

2026-02-24 09:48:57 -08:00

auth_refresh.rs

Fixed a hole in token refresh logic for app server (#11802)

2026-02-18 09:27:04 -08:00

cli_stream.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

client_websockets.rs

Send warmup request (#11258)

2026-02-24 08:15:47 -08:00

client.rs

Prefer v2 websockets if available (#12428)

2026-02-21 20:08:04 +00:00

codex_delegate.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

collaboration_instructions.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

compact_remote.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

compact_resume_fork.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

compact.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

deprecation_notice.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

exec_policy.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

exec.rs

Ensure shell command skills trigger approval (#12697)

2026-02-24 12:13:20 -08:00

fork_thread.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

grep_files.rs

Use use_model (#7121)

2025-11-21 22:10:52 +00:00

hierarchical_agents.rs

Update tests to stop using sse_completed fixture (#10638)

2026-02-04 08:38:06 -08:00

image_rollout.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

items.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

json_result.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

list_dir.rs

Promote shared helpers for suite tests (#6460)

2025-11-13 17:12:10 -08:00

live_cli.rs

feat: introduce codex-utils-cargo-bin as an alternative to assert_cmd::Command (#8496)

2025-12-23 19:29:32 -08:00

live_reload.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

mod.rs

feat(core) Introduce Feature::RequestPermissions (#11871)

2026-02-24 09:48:57 -08:00

model_info_overrides.rs

client side modelinfo overrides (#12101)

2026-02-19 10:38:57 -08:00

model_overrides.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

model_switching.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

model_tools.rs

chore: rm remote models fflag (#11699)

2026-02-17 11:43:16 -08:00

model_visible_layout.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

models_cache_ttl.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

models_etag_responses.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

otel.rs

Add MCP server context to otel tool_result logs (#12267)

2026-02-20 10:26:19 -05:00

override_updates.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

pending_input.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

permissions_messages.rs

feat(core) Introduce Feature::RequestPermissions (#11871)

2026-02-24 09:48:57 -08:00

personality_migration.rs

feat: add nick name to sub-agents (#12320)

2026-02-20 14:39:49 +00:00

personality.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

prompt_caching.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

quota_exceeded.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

read_file.rs

Promote shared helpers for suite tests (#6460)

2025-11-13 17:12:10 -08:00

realtime_conversation.rs

Handle realtime spawn_transcript delegation (#12619)

2026-02-23 14:39:07 -08:00

remote_models.rs

fix: also try matching namespaced prefix for modelinfo candidate (#12658)

2026-02-24 10:57:26 -08:00

request_compression.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

request_permissions.rs

feat(core) Introduce Feature::RequestPermissions (#11871)

2026-02-24 09:48:57 -08:00

request_user_input.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

resume_warning.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

resume.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

review.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

rmcp_client.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

rollout_list_find.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

safety_check_downgrade.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

search_tool.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

seatbelt.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

shell_command.rs

Adjust shell command timeouts for Windows (#11247)

2026-02-09 20:03:32 -08:00

shell_serialization.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

shell_snapshot.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

skill_approval.rs

Ensure shell command skills trigger approval (#12697)

2026-02-24 12:13:20 -08:00

skills.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

sqlite_state.rs

feat: add nick name to sub-agents (#12320)

2026-02-20 14:39:49 +00:00

stream_error_allows_next_turn.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

stream_no_completed.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

subagent_notifications.rs

feat: sub-agent injection (#12152)

2026-02-19 11:32:10 +00:00

text_encoding_fix.rs

Fix: Improve text encoding for shell output in VSCode preview (#6178) (#6182)

2025-11-20 11:04:11 -08:00

tool_harness.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

tool_parallelism.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

tools.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

truncation.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

turn_state.rs

turn metadata: per-turn non-blocking (#11677)

2026-02-13 12:48:29 -08:00

undo.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

unified_exec.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

unstable_features_warning.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

user_notification.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

user_shell_cmd.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

view_image.rs

Return image content from view_image (#12553)

2026-02-22 23:00:08 -08:00

web_search.rs

chore: remove codex-core public protocol/shell re-exports (#12432)

2026-02-20 23:45:35 -08:00

websocket_fallback.rs

Send warmup request (#11258)

2026-02-24 08:15:47 -08:00