mirror of
https://github.com/pchuan98/codex.git
synced 2026-07-01 00:31:56 +08:00
8b7f8af343
We are removing feature-gated shared crates from the `codex-rs` workspace. `codex-common` grouped several unrelated utilities behind `[features]`, which made dependency boundaries harder to reason about and worked against the ongoing effort to eliminate feature flags from workspace crates. Splitting these utilities into dedicated crates under `utils/` aligns this area with existing workspace structure and keeps each dependency explicit at the crate boundary. ## What changed - Removed `codex-rs/common` (`codex-common`) from workspace members and workspace dependencies. - Added six new utility crates under `codex-rs/utils/`: - `codex-utils-cli` - `codex-utils-elapsed` - `codex-utils-sandbox-summary` - `codex-utils-approval-presets` - `codex-utils-oss` - `codex-utils-fuzzy-match` - Migrated the corresponding modules out of `codex-common` into these crates (with tests), and added matching `BUILD.bazel` targets. - Updated direct consumers to use the new crates instead of `codex-common`: - `codex-rs/cli` - `codex-rs/tui` - `codex-rs/exec` - `codex-rs/app-server` - `codex-rs/mcp-server` - `codex-rs/chatgpt` - `codex-rs/cloud-tasks` - Updated workspace lockfile entries to reflect the new dependency graph and removal of `codex-common`.
48 lines
1.4 KiB
Rust
48 lines
1.4 KiB
Rust
//! Standard type to use with the `--sandbox` (`-s`) CLI option.
|
|
//!
|
|
//! This mirrors the variants of [`codex_core::protocol::SandboxPolicy`], but
|
|
//! without any of the associated data so it can be expressed as a simple flag
|
|
//! on the command-line. Users that need to tweak the advanced options for
|
|
//! `workspace-write` can continue to do so via `-c` overrides or their
|
|
//! `config.toml`.
|
|
|
|
use clap::ValueEnum;
|
|
use codex_protocol::config_types::SandboxMode;
|
|
|
|
#[derive(Clone, Copy, Debug, ValueEnum)]
|
|
#[value(rename_all = "kebab-case")]
|
|
pub enum SandboxModeCliArg {
|
|
ReadOnly,
|
|
WorkspaceWrite,
|
|
DangerFullAccess,
|
|
}
|
|
|
|
impl From<SandboxModeCliArg> for SandboxMode {
|
|
fn from(value: SandboxModeCliArg) -> Self {
|
|
match value {
|
|
SandboxModeCliArg::ReadOnly => SandboxMode::ReadOnly,
|
|
SandboxModeCliArg::WorkspaceWrite => SandboxMode::WorkspaceWrite,
|
|
SandboxModeCliArg::DangerFullAccess => SandboxMode::DangerFullAccess,
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
#[test]
|
|
fn maps_cli_args_to_protocol_modes() {
|
|
assert_eq!(SandboxMode::ReadOnly, SandboxModeCliArg::ReadOnly.into());
|
|
assert_eq!(
|
|
SandboxMode::WorkspaceWrite,
|
|
SandboxModeCliArg::WorkspaceWrite.into()
|
|
);
|
|
assert_eq!(
|
|
SandboxMode::DangerFullAccess,
|
|
SandboxModeCliArg::DangerFullAccess.into()
|
|
);
|
|
}
|
|
}
|