Eric Traut 73ed30d7e5 Avoid hang when tool's process spawns grandchild that shares stderr/stdout (#6575) ...

We've received many reports of codex hanging when calling certain tools.
[Here](https://github.com/openai/codex/issues/3204) is one example. This
is likely a major cause. The problem occurs when
`consume_truncated_output` waits for `stdout` and `stderr` to be closed
once the child process terminates. This normally works fine, but it
doesn't handle the case where the child has spawned grandchild processes
that inherits `stdout` and `stderr`.

The fix was originally written by @md-oai in [this
PR](https://github.com/openai/codex/pull/1852), which has gone stale.
I've copied the original fix (which looks sound to me) and added an
integration test to prevent future regressions.

73ed30d7e5 · 2025-11-12 20:08:12 -08:00

History

..

abort_tasks.rs

Prefer wait_for_event over wait_for_event_with_timeout (#6349)

2025-11-06 18:11:11 -08:00

apply_patch_cli.rs

chore: testing on apply_path (#5557)

2025-10-23 17:00:48 +01:00

apply_patch_freeform.rs

chore: testing on freeform apply_patch (#5952)

2025-10-30 10:40:48 -07:00

approvals.rs

Add unified exec escalation handling and tests (#6492)

2025-11-11 08:19:35 -08:00

auth_refresh.rs

Improved token refresh handling to address "Re-connecting" behavior (#6231)

2025-11-05 10:51:57 -08:00

cli_stream.rs

chore: speed-up pipeline (#5812)

2025-10-28 14:08:52 +00:00

client.rs

Set verbosity to low for 5.1 (#6568)

2025-11-13 01:40:52 +00:00

codex_delegate.rs

ignore deltas in codex_delegate (#6208)

2025-11-04 19:21:35 +00:00

compact_resume_fork.rs

feat: compactor 2 (#6027)

2025-10-31 14:27:08 -07:00

compact.rs

Fix warning message phrasing (#6446)

2025-11-09 22:12:28 -08:00

deprecation_notice.rs

Remove shell tool when unified exec is enabled (#6345)

2025-11-06 15:46:24 -08:00

exec.rs

chore: rework tools execution workflow (#5278)

2025-10-20 20:57:37 +01:00

fork_conversation.rs

Add feedback upload request handling (#5682)

2025-10-27 05:53:39 +00:00

grep_files.rs

Add ItemStarted/ItemCompleted events for UserInputItem (#5306)

2025-10-20 13:34:44 -07:00

items.rs

Add item streaming events (#5546)

2025-10-29 22:33:57 +00:00

json_result.rs

Add ItemStarted/ItemCompleted events for UserInputItem (#5306)

2025-10-20 13:34:44 -07:00

list_dir.rs

Add ItemStarted/ItemCompleted events for UserInputItem (#5306)

2025-10-20 13:34:44 -07:00

live_cli.rs

test: faster test execution in codex-core (#2633)

2025-08-24 11:10:53 -07:00

mod.rs

Use codex-linux-sandbox in unified exec (#6480)

2025-11-10 17:17:09 -08:00

model_overrides.rs

feat: reasoning effort as optional (#3527)

2025-09-12 12:06:33 -07:00

model_tools.rs

Change model picker to include gpt5.1 (#6569)

2025-11-12 19:44:53 -08:00

otel.rs

Fix otel tests (#6541)

2025-11-12 16:35:34 +00:00

prompt_caching.rs

[app-server] feat: thread/resume supports history, path, and overrides (#6483)

2025-11-12 22:02:43 +00:00

quota_exceeded.rs

Prefer wait_for_event over wait_for_event_with_timeout. (#6346)

2025-11-06 16:14:43 -08:00

read_file.rs

Add ItemStarted/ItemCompleted events for UserInputItem (#5306)

2025-10-20 13:34:44 -07:00

resume_warning.rs

feat: warning switch model on resume (#6507)

2025-11-12 11:13:37 +00:00

resume.rs

Add new thread items and rewire event parsing to use them (#5418)

2025-10-22 10:14:50 -07:00

review.rs

Prefer wait_for_event over wait_for_event_with_timeout (#6349)

2025-11-06 18:11:11 -08:00

rmcp_client.rs

Prefer wait_for_event over wait_for_event_with_timeout (#6349)

2025-11-06 18:11:11 -08:00

rollout_list_find.rs

feat: annotate conversations with model_provider for filtering (#5658)

2025-10-27 02:03:30 -07:00

seatbelt.rs

fix: Update seatbelt policy for java on macOS (#3987)

2025-10-30 14:25:04 -07:00

shell_serialization.rs

chore: Add shell serialization tests for json (#6043)

2025-10-31 11:01:58 -07:00

stream_error_allows_next_turn.rs

Prefer wait_for_event over wait_for_event_with_timeout (#6349)

2025-11-06 18:11:11 -08:00

stream_no_completed.rs

Prefer wait_for_event over wait_for_event_with_timeout (#6349)

2025-11-06 18:11:11 -08:00

tool_harness.rs

Enable plan tool by default (#5384)

2025-10-21 16:25:05 +00:00

tool_parallelism.rs

Add ItemStarted/ItemCompleted events for UserInputItem (#5306)

2025-10-20 13:34:44 -07:00

tools.rs

Avoid hang when tool's process spawns grandchild that shares stderr/stdout (#6575)

2025-11-12 20:08:12 -08:00

truncation.rs

Truncate total tool calls text (#5979)

2025-10-31 10:30:36 -07:00

undo.rs

test: undo (#6034)

2025-10-31 14:46:24 +00:00

unified_exec.rs

Use codex-linux-sandbox in unified exec (#6480)

2025-11-10 17:17:09 -08:00

user_notification.rs

[app-server] feat: v2 Thread APIs (#6214)

2025-11-05 20:28:43 +00:00

user_shell_cmd.rs

Add user command event types (#6246)

2025-11-10 19:18:45 +00:00

view_image.rs

verify mime type of images (#5888)

2025-10-28 14:52:51 -07:00