Charley Cunningham 47aa1f3b6a Reject request_user_input outside Plan/Pair (#9955) ...

## Context

Previous work in https://github.com/openai/codex/pull/9560 only rejected
`request_user_input` in Execute and Custom modes. Since then, additional
modes
(e.g., Code) were added, so the guard should be mode-agnostic.

## What changed

- Switch the handler to an allowlist: only Plan and PairProgramming are
allowed
- Return the same error for any other mode (including Code)
- Add a Code-mode rejection test alongside the existing Execute/Custom
tests

## Why

This prevents `request_user_input` from being used in modes where it is
not
intended, even as new modes are introduced.

47aa1f3b6a · 2026-01-26 17:12:17 -08:00

History

..

abort_tasks.rs

fix: prevent repeating interrupted turns (#9043)

2026-01-20 13:07:28 -08:00

agent_websocket.rs

Support response.done and add integration tests (#9129)

2026-01-13 16:12:30 +00:00

apply_patch_cli.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

approvals.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

auth_refresh.rs

Attempt to reload auth as a step in 401 recovery (#8880)

2026-01-08 15:06:44 -08:00

cli_stream.rs

feat: rename experimental_instructions_file to model_instructions_file (#9555)

2026-01-21 02:25:08 +00:00

client_websockets.rs

Support end_turn flag (#9698)

2026-01-22 17:27:48 +00:00

client.rs

change collaboration mode to struct (#9793)

2026-01-23 17:00:23 -08:00

codex_delegate.rs

renaming: task to turn (#8963)

2026-01-09 17:31:17 +00:00

collaboration_instructions.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

compact_remote.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

compact_resume_fork.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

compact.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

deprecation_notice.rs

feat: rename experimental_instructions_file to model_instructions_file (#9555)

2026-01-21 02:25:08 +00:00

exec_policy.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

exec.rs

refactoring with_escalated_permissions to use SandboxPermissions instead (#7750)

2025-12-10 17:18:48 +00:00

fork_thread.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

grep_files.rs

Use use_model (#7121)

2025-11-21 22:10:52 +00:00

hierarchical_agents.rs

Rename hierarchical_agents to child_agents_md (#9215)

2026-01-14 19:14:24 +00:00

image_rollout.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

items.rs

Add total (non-partial) TextElement placeholder accessors (#9545)

2026-01-20 14:04:11 -08:00

json_result.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

list_dir.rs

Promote shared helpers for suite tests (#6460)

2025-11-13 17:12:10 -08:00

list_models.rs

feat(tui) /personality (#9718)

2026-01-25 21:59:42 -08:00

live_cli.rs

feat: introduce codex-utils-cargo-bin as an alternative to assert_cmd::Command (#8496)

2025-12-23 19:29:32 -08:00

mod.rs

feat(core) ModelInfo.model_instructions_template (#9597)

2026-01-21 18:11:18 -08:00

model_info_overrides.rs

Override truncation policy at model info level (#8856)

2026-01-07 13:06:20 -08:00

model_overrides.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

model_tools.rs

Feat: request user input tool (#9472)

2026-01-19 10:17:30 -08:00

models_cache_ttl.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

models_etag_responses.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

otel.rs

Add text element metadata to types (#9235)

2026-01-14 16:41:50 -08:00

override_updates.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

pending_input.rs

Add text element metadata to types (#9235)

2026-01-14 16:41:50 -08:00

permissions_messages.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

personality.rs

chore(core) move model_instructions_template config (#9871)

2026-01-26 07:02:11 +00:00

prompt_caching.rs

change collaboration mode to struct (#9793)

2026-01-23 17:00:23 -08:00

quota_exceeded.rs

Add text element metadata to types (#9235)

2026-01-14 16:41:50 -08:00

read_file.rs

Promote shared helpers for suite tests (#6460)

2025-11-13 17:12:10 -08:00

remote_models.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

request_compression.rs

Add text element metadata to types (#9235)

2026-01-14 16:41:50 -08:00

request_user_input.rs

Reject request_user_input outside Plan/Pair (#9955)

2026-01-26 17:12:17 -08:00

resume_warning.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

resume.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

review.rs

feat: ephemeral threads (#9765)

2026-01-24 14:57:40 +00:00

rmcp_client.rs

Add MCP server scopes config and use it as fallback for OAuth login (#9647)

2026-01-26 14:13:04 -08:00

rollout_list_find.rs

Add thread/unarchive to restore archived rollouts (#9843)

2026-01-26 11:24:36 -08:00

seatbelt.rs

fix: introduce AbsolutePathBuf as part of sandbox config (#7856)

2025-12-12 15:25:22 -08:00

shell_command.rs

fix: increase timeout for tests that have been flaking with timeout issues (#8932)

2026-01-08 20:31:03 +00:00

shell_serialization.rs

remove model_family from `config (#7571)

2025-12-04 11:57:58 -08:00

shell_snapshot.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

skills.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

stream_error_allows_next_turn.rs

Add text element metadata to types (#9235)

2026-01-14 16:41:50 -08:00

stream_no_completed.rs

Add text element metadata to types (#9235)

2026-01-14 16:41:50 -08:00

text_encoding_fix.rs

Fix: Improve text encoding for shell output in VSCode preview (#6178) (#6182)

2025-11-20 11:04:11 -08:00

tool_harness.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

tool_parallelism.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

tools.rs

feat: support allowed_sandbox_modes in requirements.toml (#8298)

2025-12-19 21:09:20 +00:00

truncation.rs

Add MCP server scopes config and use it as fallback for OAuth login (#9647)

2026-01-26 14:13:04 -08:00

turn_state.rs

Turn-state sticky routing per turn (#9332)

2026-01-16 09:30:11 -08:00

undo.rs

chore: unify conversation with thread name (#8830)

2026-01-07 17:04:53 +00:00

unified_exec.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

user_notification.rs

Add text element metadata to types (#9235)

2026-01-14 16:41:50 -08:00

user_shell_cmd.rs

chore: defensive shell snapshot (#9609)

2026-01-21 18:41:58 +00:00

view_image.rs

feat(core) update Personality on turn (#9644)

2026-01-22 12:04:23 -08:00

web_search_cached.rs

[search] allow explicitly disabling web search (#9249)

2026-01-15 11:28:57 -08:00