Won Park 1315198853 [codex] Persist built-in image results reported as generating (#28656) ...

## Why

#27920 stopped persisting image-generation items unless their status was
`completed`, preventing failed standalone extension items with empty
results from being saved. Built-in image generation can instead emit a
terminal `response.output_item.done` containing a complete base64 PNG
while the item status remains `generating`. In that case, app-server
emits no `savedPath`, so Codex Apps can render the inline image but
cannot expose a file artifact.

## What changed

- Persist image-generation items whenever `result` contains image data.
Failed terminal items still have empty results and remain unpersisted.
- Update the existing built-in image-generation integration test to
cover a terminal `generating` item and verify both `saved_path` and the
written PNG bytes.

## Validation

- Confirmed with a raw built-in websocket trace: the image progressed
through `in_progress`, `generating`, and `partial_image`, then emitted
one `response.output_item.done` with `status: "generating"` and a
complete PNG result.
- `just test -p codex-core builtin_image_generation_call_persisted` is
currently blocked before test execution by a pre-existing compile error
in `thread-store/src/thread_metadata_sync.rs:171`.

1315198853 · 2026-06-17 06:03:00 +00:00

History

..

common

Clarify model-generated and legacy app path types (#28577)

2026-06-16 20:47:43 +00:00

remote_env_windows

core: render remote environment cwd natively (#28152)

2026-06-16 16:17:47 -07:00

suite

[codex] Persist built-in image results reported as generating (#28656)

2026-06-17 06:03:00 +00:00

all.rs

[codex] Use expect in integration tests (#28441)

2026-06-15 21:53:47 -07:00

responses_headers.rs

feat(core): add metadata field to ResponseItem (#28355)

2026-06-15 15:05:28 -07:00